Skip to contentSkip to conversation

x86/domctl: fix typo in comment

PATCH In review Olaf Hering 3 participants 4 messages Jan 28, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/domctl: fix typo in comment

The array is named msr_policy.

Fixes commit 60529dfeca1

---
 xen/include/public/domctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/include/public/domctl.h +1 -1
index e313da499f..2bb7397923 100644
@@ -675,7 +675,7 @@ struct xen_domctl_cpu_policy {
     uint32_t nr_leaves; /* IN/OUT: Number of leaves in/written to
                          * 'cpuid_policy'. */
     uint32_t nr_msrs;   /* IN/OUT: Number of MSRs in/written to
-                         * 'msr_domain_policy' */
+                         * 'msr_policy' */
     XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) cpuid_policy; /* IN/OUT */
     XEN_GUEST_HANDLE_64(xen_msr_entry_t) msr_policy;    /* IN/OUT */
 

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Olaf Hering

The array is named msr_policy.

Fixes commit 60529dfeca1

Backport: 4.12+

Quoted 9 lines
---
 xen/include/public/domctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/include/public/domctl.h +0 -0
index e313da499f..2bb7397923 100644

xen/include/public/domctl.h struct xen_domctl_cpu_policy { · line 681

Quoted 8 lines
xen/include/public/domctl.h +1 -1
@@ -675,7 +675,7 @@ struct xen_domctl_cpu_policy {
     uint32_t nr_leaves; /* IN/OUT: Number of leaves in/written to
                          * 'cpuid_policy'. */
     uint32_t nr_msrs;   /* IN/OUT: Number of MSRs in/written to
-                         * 'msr_domain_policy' */
+                         * 'msr_policy' */
     XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) cpuid_policy; /* IN/OUT */
     XEN_GUEST_HANDLE_64(xen_msr_entry_t) msr_policy;    /* IN/OUT */
 

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw
Quoted 4 lines · Jan Beulich
Quoted 3 lines · Wei Liu
Quoted 2 lines · Olaf Hering

The array is named msr_policy.

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

Fixes commit 60529dfeca1

Backport: 4.12+

Why? This kind of a change hardly warrants a backport imo.

I think it would be good if we can keep it in sync, but of course it is fine to not backport such fix.

Wei.

Quoted 1 line

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel