Skip to contentSkip to conversation

iio: adc: ad7124: Add direct reg access

PATCH RESEND Superseded Mircea Caprioru 3 participants 3 messages Jan 29, 2020

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 iio: adc: ad7124: Add direct reg access

From: Mircea <[email protected]>

This patch adds the posibility do read and write registers from userspace using the kernel debug direct register access option.

---
 drivers/iio/adc/ad7124.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
drivers/iio/adc/ad7124.c +28 -0
index 52f45b13da4a..38e67e08a79a 100644
@@ -93,6 +93,14 @@ static const unsigned int ad7124_gain[8] = {
 	1, 2, 4, 8, 16, 32, 64, 128
 };
 
+static const unsigned int ad7124_reg_size[] = {
+	1, 2, 3, 3, 2, 1, 3, 3, 1, 2, 2, 2, 2,
+	2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,
+	2, 2, 2, 2, 2, 2, 2, 3, 3, 3, 3, 3, 3,
+	3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3,
+	3, 3, 3, 3, 3
+};
+
 static const int ad7124_master_clk_freq_hz[3] = {
 	[AD7124_LOW_POWER] = 76800,
 	[AD7124_MID_POWER] = 153600,
@@ -360,6 +368,25 @@ static int ad7124_write_raw(struct iio_dev *indio_dev,
 	}
 }
 
+static int ad7124_reg_access(struct iio_dev *indio_dev,
+			     unsigned int reg,
+			     unsigned int writeval,
+			     unsigned int *readval)
+{
+	struct ad7124_state *st = iio_priv(indio_dev);
+	int ret;
+
+
+	if (readval)
+		ret = ad_sd_read_reg(&st->sd, reg, ad7124_reg_size[reg],
+				     readval);
+	else
+		ret = ad_sd_write_reg(&st->sd, reg, ad7124_reg_size[reg],
+				      writeval);
+
+	return ret;
+}
+
 static IIO_CONST_ATTR(in_voltage_scale_available,
 	"0.000001164 0.000002328 0.000004656 0.000009313 0.000018626 0.000037252 0.000074505 0.000149011 0.000298023");
 
@@ -375,6 +402,7 @@ static const struct attribute_group ad7124_attrs_group = {
 static const struct iio_info ad7124_info = {
 	.read_raw = ad7124_read_raw,
 	.write_raw = ad7124_write_raw,
+	.debugfs_reg_access = &ad7124_reg_access,
 	.validate_trigger = ad_sd_validate_trigger,
 	.attrs = &ad7124_attrs_group,
 };
Signature · 1 line
2.17.1
#1 lore raw
Quoted 6 lines · Mircea Caprioru

From: Mircea <[email protected]>

This patch adds the posibility do read and write registers from userspace using the kernel debug direct register access option.

Now this line doesn't match the name you use above on the "From:" line :(

#2 lore raw
In reply to Mircea Caprioru
Quoted 4 lines · Mircea Caprioru

From: Mircea <[email protected]>

This patch adds the posibility do read and write registers from userspace using the kernel debug direct register access option.

Typo: possibility

Quoted 2 lines

[...]

Quoted 6 lines
drivers/iio/adc/ad7124.c +5 -0
+static int ad7124_reg_access(struct iio_dev *indio_dev,
+			     unsigned int reg,
+			     unsigned int writeval,
+			     unsigned int *readval)
+{

drivers/iio/adc/ad7124.c static int ad7124_write_raw(struct iio_dev *indio_dev, · line 385

Quoted 10 lines
drivers/iio/adc/ad7124.c +10 -0
+	struct ad7124_state *st = iio_priv(indio_dev);
+	int ret;
+
+
+	if (readval)
+		ret = ad_sd_read_reg(&st->sd, reg, ad7124_reg_size[reg],
+				     readval);
+	else
+		ret = ad_sd_write_reg(&st->sd, reg, ad7124_reg_size[reg],
+				      writeval);

Needs a bounds check to make sure that reg is less then the number of entries in ad7124_reg_size.