Skip to contentSkip to conversation

runner: Support dynamic subtests in testlists

PATCH In review Petri Latvala 4 participants 8 messages Jan 29, 2020 – Feb 11, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 runner: Support dynamic subtests in testlists

In a very rudimentary and undocumented manner, testlist files can now have dynamic subtests specified. This feature is intended for very special cases, and the main supported mode of operation with testlist files is still the CI-style "run it all no matter what".

The syntax for testlist files is:

igt@binary@subtestname@dynamicsubtestname

As dynamic subtests are not easily listable, any helpers for generating such testlists are not implemented.

If running in multiple-mode, subtests with dynamic subtests specified will run in single-mode instead.

---
 runner/executor.c | 20 +++++++++++++++++---
 runner/job_list.c | 28 ++++++++++++++++++++++------
 2 files changed, 39 insertions(+), 9 deletions(-)
runner/executor.c +17 -3
index 0927d1fd..8c506dcc 100644
@@ -1033,7 +1033,7 @@ execute_test_process(int outfd, int errfd,
 		     struct settings *settings,
 		     struct job_list_entry *entry)
 {
-	char *argv[4] = {};
+	char *argv[6] = {};
 	size_t rootlen;
 
 	dup2(outfd, STDOUT_FILENO);
@@ -1049,17 +1049,31 @@ execute_test_process(int outfd, int errfd,
 
 	if (entry->subtest_count) {
 		size_t argsize;
+		const char *dynbegin;
 		size_t i;
 
 		argv[1] = strdup("--run-subtest");
-		argsize = strlen(entry->subtests[0]);
+
+		if ((dynbegin = strchr(entry->subtests[0], '@')) != NULL)
+			argsize = dynbegin - entry->subtests[0];
+		else
+			argsize = strlen(entry->subtests[0]);
+
 		argv[2] = malloc(argsize + 1);
-		strcpy(argv[2], entry->subtests[0]);
+		memcpy(argv[2], entry->subtests[0], argsize);
+		argv[2][argsize] = '\0';
+
+		if (dynbegin) {
+			argv[3] = strdup("--dynamic-subtest");
+			argv[4] = strdup(dynbegin + 1);
+		}
 
 		for (i = 1; i < entry->subtest_count; i++) {
 			char *sub = entry->subtests[i];
 			size_t sublen = strlen(sub);
 
+			assert(dynbegin == NULL);
+
 			argv[2] = realloc(argv[2], argsize + sublen + 2);
 			argv[2][argsize] = ',';
 			strcpy(argv[2] + argsize + 1, sub);
runner/job_list.c +22 -6
index 93cede75..520a98da 100644
@@ -248,8 +248,12 @@ static bool job_list_from_test_list(struct job_list *job_list,
 			 * If the currently built entry has the same
 			 * binary, add a subtest. Otherwise submit
 			 * what's already built and start a new one.
+			 *
+			 * If the new test has a dynamic subtest
+			 * specified, also start a new entry.
 			 */
-			if (entry.binary && !strcmp(entry.binary, binary)) {
+			if (entry.binary && !strcmp(entry.binary, binary) &&
+			    (delim == NULL || strchr(delim, '@') == NULL)) {
 				if (!delim) {
 					/* ... except we didn't get a subtest */
 					fprintf(stderr,
@@ -275,11 +279,23 @@ static bool job_list_from_test_list(struct job_list *job_list,
 			}
 
 			memset(&entry, 0, sizeof(entry));
-			entry.binary = strdup(binary);
-			if (delim) {
-				entry.subtests = malloc(sizeof(*entry.subtests));
-				entry.subtests[0] = strdup(delim);
-				entry.subtest_count = 1;
+
+			if (delim != NULL && strchr(delim, '@') != NULL) {
+				/* Dynamic subtest specified. Add to job list alone. */
+				char **subtests;
+
+				subtests = malloc(sizeof(char*));
+				subtests[0] = strdup(delim);
+
+				add_job_list_entry(job_list, strdup(binary), subtests, 1);
+				any = true;
+			} else {
+				entry.binary = strdup(binary);
+				if (delim) {
+					entry.subtests = malloc(sizeof(*entry.subtests));
+					entry.subtests[0] = strdup(delim);
+					entry.subtest_count = 1;
+				}
 			}
 
 			free(binary);
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

PATCH 2/2 runner_tests: Unit test dynamic subtest testlist support

Cc Arkadiusz Hiler <[email protected]>
---
 runner/runner_tests.c | 125 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 125 insertions(+)
runner/runner_tests.c +125 -0
index 6b0e6cc4..ed30b3f9 100644
@@ -740,6 +740,66 @@ igt_main
 		}
 	}
 
+	igt_subtest_group {
+		char filename[] = "tmplistXXXXXX";
+		const char testlisttext[] = "igt@dynamic@dynamic-subtest@passing\n"
+			"igt@dynamic@dynamic-subtest@failing\n"
+			"igt@dynamic@different-subtest@passing\n";
+		int multiple;
+		struct job_list *list = malloc(sizeof(*list));
+
+		igt_fixture {
+			int fd;
+			igt_require((fd = mkstemp(filename)) >= 0);
+			igt_require(write(fd, testlisttext, strlen(testlisttext)) == strlen(testlisttext));
+			close(fd);
+			init_job_list(list);
+		}
+
+		for (multiple = 0; multiple < 2; multiple++) {
+			igt_subtest_f("job-list-testlist-dynamic-%s", multiple ? "multiple" : "normal") {
+				const char *argv[] = { "runner",
+						       "--test-list", filename,
+						       multiple ? "--multiple-mode" : "--sync",
+						       testdatadir,
+						       "path-to-results",
+				};
+
+				igt_assert(parse_options(ARRAY_SIZE(argv), (char**)argv, settings));
+				igt_assert(create_job_list(list, settings));
+
+				/*
+				 * Normally we would combine different
+				 * subtests of the same binary to the
+				 * same execution when using
+				 * multiple-mode. If dynamic subtests
+				 * are used, no execution combining
+				 * should occur.
+				 */
+
+				igt_assert_eq(list->size, 3);
+
+				igt_assert_eqstr(list->entries[0].binary, "dynamic");
+				igt_assert_eqstr(list->entries[1].binary, "dynamic");
+				igt_assert_eqstr(list->entries[2].binary, "dynamic");
+
+				igt_assert_eq(list->entries[0].subtest_count, 1);
+				igt_assert_eq(list->entries[1].subtest_count, 1);
+				igt_assert_eq(list->entries[2].subtest_count, 1);
+
+				igt_assert_eqstr(list->entries[0].subtests[0], "dynamic-subtest@passing");
+				igt_assert_eqstr(list->entries[1].subtests[0], "dynamic-subtest@failing");
+				igt_assert_eqstr(list->entries[2].subtests[0], "different-subtest@passing");
+			}
+		}
+
+		igt_fixture {
+			unlink(filename);
+			free_job_list(list);
+			free(list);
+		}
+	}
+
 	igt_subtest_group {
 		char dirname[] = "tmpdirXXXXXX";
 		volatile int dirfd = -1, fd = -1;
@@ -1351,6 +1411,71 @@ igt_main
 			free(list);
 	}
 
+	igt_subtest_group {
+		const char testlisttext[] = "igt@dynamic@dynamic-subtest@passing\n";
+		struct job_list *list = malloc(sizeof(*list));
+		volatile int dirfd = -1;
+		char dirname[] = "tmpdirXXXXXX";
+		volatile int fd;
+		char filename[] = "tmplistXXXXXX";
+
+		igt_fixture {
+			igt_require(mkdtemp(dirname) != NULL);
+			rmdir(dirname);
+
+			igt_require((fd = mkstemp(filename)) >= 0);
+			igt_require(write(fd, testlisttext, strlen(testlisttext)) == strlen(testlisttext));
+			close(fd);
+
+			init_job_list(list);
+		}
+
+		igt_subtest("dynamic-subtests-in-testlist") {
+			struct execute_state state;
+			struct json_object *results, *obj;
+			const char *argv[] = { "runner",
+					       "--test-list", filename,
+					       testdatadir,
+					       dirname,
+			};
+
+			igt_assert(parse_options(ARRAY_SIZE(argv), (char**)argv, settings));
+
+			igt_assert(create_job_list(list, settings));
+			igt_assert_eq(list->size, 1);
+			igt_assert_eq(list->entries[0].subtest_count, 1);
+
+			igt_assert(initialize_execute_state(&state, settings, list));
+			igt_assert(execute(&state, settings, list));
+
+			igt_assert_f((dirfd = open(dirname, O_DIRECTORY | O_RDONLY)) >= 0,
+				     "Execute didn't create the results directory\n");
+			igt_assert_f((results = generate_results_json(dirfd)) != NULL,
+				     "Results parsing failed\n");
+
+			obj = results;
+			igt_assert(json_object_object_get_ex(obj, "tests", &obj));
+
+			/* Check that the dynamic subtest we didn't request is not reported */
+			igt_assert(!json_object_object_get_ex(obj, "igt@dynamic@dynamic-subtest@failing", NULL));
+
+			/* Check that the dynamic subtest we did request is */
+			igt_assert(json_object_object_get_ex(obj, "igt@dynamic@dynamic-subtest@passing", &obj));
+			igt_assert(json_object_object_get_ex(obj, "result", &obj));
+			igt_assert_eqstr(json_object_get_string(obj), "pass");
+
+			igt_assert_eq(json_object_put(results), 1);
+		}
+
+		igt_fixture {
+			unlink(filename);
+			close(dirfd);
+			clear_directory(dirname);
+			free_job_list(list);
+			free(list);
+		}
+	}
+
 	igt_subtest_group {
 		struct job_list *list = malloc(sizeof(*list));
 		volatile int dirfd = -1;
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#2 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] runner: Support dynamic subtests in testlists

In reply to Petri Latvala
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/2] runner: Support dynamic subtests in testlists
URL : https://patchwork.freedesktop.org/series/72719/
State : failure

== Summary ==

CI Bug Log - changes from IGT_5404 -> IGTPW_4027
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_4027 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_4027, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4027:

### IGT changes ###

#### Possible regressions ####

* igt@runner@aborted:
- fi-bsw-kefka: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-bsw-kefka/igt@[email protected]
- fi-bsw-nick: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-bsw-nick/igt@[email protected]
- fi-bsw-n3050: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-bsw-n3050/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_4027 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [PASS][4] -> [TIMEOUT][5] ([fdo#112271] / [i915#816])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-byt-j1900/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-byt-j1900/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][6] -> [FAIL][7] ([i915#178])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-skl-6770hq/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-skl-6770hq/igt@[email protected]

* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [PASS][8] -> [DMESG-FAIL][9] ([i915#553] / [i915#725])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-hsw-4770r/igt@i915_selftest@live_blt.html
- fi-hsw-4770: [PASS][10] -> [DMESG-FAIL][11] ([i915#563])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-hsw-4770/igt@i915_selftest@live_blt.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-hsw-4770/igt@i915_selftest@live_blt.html

* igt@prime_self_import@basic-llseek-bad:
- fi-tgl-y: [PASS][12] -> [DMESG-WARN][13] ([CI#94] / [i915#402]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-tgl-y/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-tgl-y/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_parallel@fds:
- fi-byt-n2820: [FAIL][14] ([i915#694]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-byt-n2820/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-byt-n2820/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][16] ([fdo#111096] / [i915#323]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-kbl-7500u/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-kbl-7500u/igt@[email protected]

* igt@prime_self_import@basic-llseek-size:
- fi-tgl-y: [DMESG-WARN][18] ([CI#94] / [i915#402]) -> [PASS][19] +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-tgl-y/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-tgl-y/igt@[email protected]

#### Warnings ####

* igt@gem_exec_parallel@contexts:
- fi-byt-n2820: [TIMEOUT][20] ([fdo#112271]) -> [FAIL][21] ([i915#694])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-byt-n2820/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-byt-n2820/igt@[email protected]

[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#178]: https://gitlab.freedesktop.org/drm/intel/issues/178
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816

Participating hosts (49 -> 47)
------------------------------

Additional (3): fi-hsw-peppy fi-bxt-dsi fi-pnv-d510
Missing (5): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5404 -> IGTPW_4027

CI-20190529: 20190529
CI_DRM_7837: 4a3438425d35afbf11f3d2c6092642d42c4cf941 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4027: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/index.html
IGT_5404: 4147bab8e3dcaf11bd657b5fb4c109708e94e60c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw

Re: [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] runner: Support dynamic subtests in testlists

Quoted 34 lines · Patchwork

== Series Details ==

Series: series starting with [i-g-t,1/2] runner: Support dynamic subtests in testlists
URL : https://patchwork.freedesktop.org/series/72719/
State : failure

== Summary ==

CI Bug Log - changes from IGT_5404 -> IGTPW_4027
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_4027 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_4027, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4027:

### IGT changes ###

#### Possible regressions ####

Quoted 7 lines

* igt@runner@aborted:
- fi-bsw-kefka: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-bsw-kefka/igt@[email protected]
- fi-bsw-nick: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-bsw-nick/igt@[email protected]
- fi-bsw-n3050: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-bsw-n3050/igt@[email protected]

"New" issues "caused" by Tomi enabling lockdep checking again.

Lakshmi, these will crop up in postmerge now too so you should already have them covered. When you do, please re-report IGTPW_4027.

Signature · 5 lines
Petri Latvala
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#4 lore raw

Re: [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] runner: Support dynamic subtests in testlists

New bug is filed and results are Re-reported.

-----Original Message-----
From: Latvala, Petri <[email protected]>
Sent: Thursday, January 30, 2020 10:57 AM
To: Vudum, Lakshminarayana <[email protected]>
Cc: [email protected]
Subject: Re: ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] runner: Support dynamic subtests in testlists

Quoted 35 lines · Patchwork

== Series Details ==

Series: series starting with [i-g-t,1/2] runner: Support dynamic subtests in testlists
URL : https://patchwork.freedesktop.org/series/72719/
State : failure

== Summary ==

CI Bug Log - changes from IGT_5404 -> IGTPW_4027
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_4027 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_4027, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4027:

### IGT changes ###

#### Possible regressions ####

Quoted 9 lines

* igt@runner@aborted:
- fi-bsw-kefka: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-bsw-kefka/igt@[email protected]
- fi-bsw-nick: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-bsw-nick/igt@[email protected]
- fi-bsw-n3050: NOTRUN -> [FAIL][3]
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-bsw-n3050/igt@r
[email protected]

"New" issues "caused" by Tomi enabling lockdep checking again.

Lakshmi, these will crop up in postmerge now too so you should already have them covered. When you do, please re-report IGTPW_4027.

--
Petri Latvala
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#5 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] runner: Support dynamic subtests in testlists

In reply to Petri Latvala
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/2] runner: Support dynamic subtests in testlists
URL : https://patchwork.freedesktop.org/series/72719/
State : success

== Summary ==

CI Bug Log - changes from IGT_5404 -> IGTPW_4027
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/index.html

Known issues
------------

Here are the changes found in IGTPW_4027 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [PASS][1] -> [TIMEOUT][2] ([fdo#112271] / [i915#816])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-byt-j1900/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-byt-j1900/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][3] -> [FAIL][4] ([i915#178])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-skl-6770hq/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-skl-6770hq/igt@[email protected]

* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [PASS][5] -> [DMESG-FAIL][6] ([i915#553] / [i915#725])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-hsw-4770r/igt@i915_selftest@live_blt.html
- fi-hsw-4770: [PASS][7] -> [DMESG-FAIL][8] ([i915#563])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-hsw-4770/igt@i915_selftest@live_blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-hsw-4770/igt@i915_selftest@live_blt.html

* igt@prime_self_import@basic-llseek-bad:
- fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([CI#94] / [i915#402]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-tgl-y/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-tgl-y/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_parallel@fds:
- fi-byt-n2820: [FAIL][11] ([i915#694]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-byt-n2820/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-byt-n2820/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][13] ([fdo#111096] / [i915#323]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-kbl-7500u/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-kbl-7500u/igt@[email protected]

* igt@prime_self_import@basic-llseek-size:
- fi-tgl-y: [DMESG-WARN][15] ([CI#94] / [i915#402]) -> [PASS][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-tgl-y/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-tgl-y/igt@[email protected]

#### Warnings ####

* igt@gem_exec_parallel@contexts:
- fi-byt-n2820: [TIMEOUT][17] ([fdo#112271]) -> [FAIL][18] ([i915#694])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/fi-byt-n2820/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/fi-byt-n2820/igt@[email protected]

[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#178]: https://gitlab.freedesktop.org/drm/intel/issues/178
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816

Participating hosts (49 -> 47)
------------------------------

Additional (3): fi-hsw-peppy fi-bxt-dsi fi-pnv-d510
Missing (5): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5404 -> IGTPW_4027

CI-20190529: 20190529
CI_DRM_7837: 4a3438425d35afbf11f3d2c6092642d42c4cf941 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4027: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/index.html
IGT_5404: 4147bab8e3dcaf11bd657b5fb4c109708e94e60c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#6 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] runner: Support dynamic subtests in testlists

In reply to Petri Latvala
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/2] runner: Support dynamic subtests in testlists
URL : https://patchwork.freedesktop.org/series/72719/
State : success

== Summary ==

CI Bug Log - changes from IGT_5404_full -> IGTPW_4027_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/index.html

Known issues
------------

Here are the changes found in IGTPW_4027_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_caching@reads:
- shard-hsw: [PASS][1] -> [FAIL][2] ([i915#694])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-hsw6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-hsw8/igt@[email protected]

* igt@gem_ctx_persistence@vcs1-mixed:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb7/igt@[email protected]

* igt@gem_exec_schedule@pi-userfault-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([i915#677])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb6/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@preempt-blt:
- shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([i915#472])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-tglb2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-tglb4/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +14 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb3/igt@[email protected]

* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#112146]) +6 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb3/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb2/igt@[email protected]

* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-kbl6/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-kbl4/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-apl7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-apl4/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109642] / [fdo#111068])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb5/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb1/igt@kms_psr@psr2_sprite_plane_move.html

* igt@kms_setmode@basic:
- shard-kbl: [PASS][21] -> [FAIL][22] ([i915#31])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-kbl7/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-kbl6/igt@[email protected]

* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#112080]) +13 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb5/igt@[email protected]

* igt@prime_mmap_coherency@ioctl-errors:
- shard-hsw: [PASS][25] -> [FAIL][26] ([i915#831])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-hsw2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-hsw2/igt@[email protected]

#### Possible fixes ####

* igt@gem_caching@writes:
- shard-hsw: [FAIL][27] ([i915#694]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-hsw6/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-hsw1/igt@[email protected]

* igt@gem_close_race@basic-threads:
- shard-hsw: [TIMEOUT][29] ([fdo#112271] / [i915#1084]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-hsw5/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-hsw8/igt@[email protected]

* igt@gem_ctx_shared@q-smoketest-bsd2:
- shard-iclb: [SKIP][31] ([fdo#109276]) -> [PASS][32] +12 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb8/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [SKIP][33] ([i915#677]) -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb3/igt@[email protected]

* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][35] ([fdo#112146]) -> [PASS][36] +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb5/igt@[email protected]

* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-hsw: [FAIL][37] ([i915#520]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-hsw6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-hsw5/igt@[email protected]

* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-kbl: [FAIL][39] ([i915#644]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-kbl6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-kbl4/igt@[email protected]

* igt@gem_softpin@noreloc-s3:
- shard-apl: [DMESG-WARN][41] ([i915#180]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-apl1/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-apl3/igt@[email protected]

* igt@i915_pm_rps@waitboost:
- shard-iclb: [FAIL][43] ([i915#413]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb3/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb5/igt@[email protected]

* igt@i915_selftest@live_gtt:
- shard-apl: [TIMEOUT][45] ([fdo#112271]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-apl1/igt@i915_selftest@live_gtt.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-apl8/igt@i915_selftest@live_gtt.html

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][47] ([i915#180]) -> [PASS][48] +5 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-kbl4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-kbl7/igt@[email protected]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-iclb: [TIMEOUT][49] -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb5/igt@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-kbl: [FAIL][51] ([i915#34]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-kbl6/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-kbl7/igt@[email protected]

* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][53] ([fdo#109441]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb1/igt@kms_psr@psr2_sprite_mmap_gtt.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html

* igt@perf_pmu@init-busy-vcs1:
- shard-iclb: [SKIP][55] ([fdo#112080]) -> [PASS][56] +15 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb6/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb2/igt@[email protected]

#### Warnings ####

* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [SKIP][57] ([fdo#112080]) -> [FAIL][58] ([IGT#28])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-iclb6/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-iclb2/igt@[email protected]

* igt@gem_tiled_blits@normal:
- shard-hsw: [FAIL][59] ([i915#818]) -> [FAIL][60] ([i915#694])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-hsw2/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-hsw6/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: [DMESG-WARN][61] ([fdo#111870] / [i915#478]) -> [DMESG-WARN][62] ([fdo#110789] / [fdo#111870] / [i915#478])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5404/shard-snb4/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/shard-snb6/igt@[email protected]

[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818
[i915#831]: https://gitlab.freedesktop.org/drm/intel/issues/831

Participating hosts (8 -> 8)
------------------------------

No changes in participating hosts

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5404 -> IGTPW_4027

CI-20190529: 20190529
CI_DRM_7837: 4a3438425d35afbf11f3d2c6092642d42c4cf941 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4027: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/index.html
IGT_5404: 4147bab8e3dcaf11bd657b5fb4c109708e94e60c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4027/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by on v1 1/2
#7 lore raw
In reply to Petri Latvala
Quoted 12 lines · Petri Latvala

In a very rudimentary and undocumented manner, testlist files can now have dynamic subtests specified. This feature is intended for very special cases, and the main supported mode of operation with testlist files is still the CI-style "run it all no matter what".

The syntax for testlist files is:

igt@binary@subtestname@dynamicsubtestname

As dynamic subtests are not easily listable, any helpers for generating such testlists are not implemented.

Quoted 6 lines

If running in multiple-mode, subtests with dynamic subtests specified will run in single-mode instead.

both patches:

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev