ALSA: uapi: Fix sparse warning
PATCH 1/1 ALSA: uapi: Fix sparse warning
Fix the following sparse warning generated due to
64-bit compat type having fields defined explicitly
with __32:sound/soc/sof/sof-audio.c:46:31: warning: incorrect type in assignment (different base types) sound/soc/sof/sof-audio.c:46:31: expected restricted snd_pcm_state_t [usertype] state sound/soc/sof/sof-audio.c:46:31: got signed int [usertype] state
--- include/uapi/sound/asound.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/uapi/sound/asound.h +2 -2
@@ -564,13 +564,13 @@ typedef char __pad_after_uframe[sizeof(__u64) - sizeof(snd_pcm_uframes_t)];#endif struct __snd_pcm_mmap_status64 { -__s32 state;/* RO: state - SNDRV_PCM_STATE_XXXX */ +snd_pcm_state_t state;/* RO: state - SNDRV_PCM_STATE_XXXX */ __u32 pad1;/* Needed for 64 bit alignment */ __pad_before_uframe __pad1;snd_pcm_uframes_t hw_ptr;/* RO: hw ptr (0...boundary-1) */ __pad_after_uframe __pad2;struct __snd_timespec64 tstamp;/* Timestamp */ -__s32 suspended_state;/* RO: suspended stream state */ +snd_pcm_state_t suspended_state;/* RO: suspended stream state */ __u32 pad3;/* Needed for 64 bit alignment */ struct __snd_timespec64 audio_tstamp;/* sample counter or wall clock */ };
Signature · 6 lines
2.17.1 _______________________________________________ Alsa-devel mailing list [email protected] https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Takashi Iwai
AppliedQuoted 11 lines · Ranjani Sridharan
Fix the following sparse warning generated due to
64-bit compat type having fields defined explicitly
with __32:sound/soc/sof/sof-audio.c:46:31: warning: incorrect type in assignment (different base types)sound/soc/sof/sof-audio.c:46:31: expected restrictedsnd_pcm_state_t[usertype] statesound/soc/sof/sof-audio.c:46:31: got signed int [usertype] stateReported-by Pierre-Louis Bossart <[email protected]>Suggested-by Takashi Iwai <[email protected]>Signed-off-by Ranjani Sridharan <[email protected]>
Thanks, applied.
Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel