Skip to contentSkip to conversation

warp7: Fix the pmic_get() parameter in the DM case

PATCH New Joris Offouga 3 participants 11 messages Jan 29, 2020 – Feb 10, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/4 warp7: Fix the pmic_get() parameter in the DM case

When pmic_get() is used with DM the first parameter must be the complete node name plus the unit address, so fix it accordingly

---
changes v1->v2:
add commit log
change commit message
add reviewed

 board/warp7/warp7.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/warp7/warp7.c +1 -1
index 9efc62f2fb..1ebec93916 100644
@@ -67,7 +67,7 @@ int power_init_board(void)
 	struct udevice *dev;
 	int ret, dev_id, rev_id;
 
-	ret = pmic_get("pfuze3000", &dev);
+	ret = pmic_get("pfuze3000 at 8", &dev);
 	if (ret == -ENODEV)
 		return 0;
 	if (ret != 0)
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 2/4 warp7: remove unused usb configs

With commit 6b503f9e6549("warp7: Switch to DM USB"). These configs are not necessary

---
changes v1->v2:
add 12 digits for commit ID
fix typo in commit log

 include/configs/warp7.h | 4 ----
 1 file changed, 4 deletions(-)
include/configs/warp7.h +0 -4
index da894ec0ca..39c00480bd 100644
@@ -149,12 +149,8 @@
 #define CONFIG_SYS_MMC_ENV_DEV		0
 #define CONFIG_SYS_MMC_ENV_PART		0
 
-/* USB Configs */
-#define CONFIG_EHCI_HCD_INIT_AFTER_RESET
 
 #define CONFIG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CONFIG_MXC_USB_FLAGS		0
-#define CONFIG_USB_MAX_CONTROLLER_COUNT 1 /* Only OTG1 port enabled */
 
 #define CONFIG_IMX_THERMAL
 
Signature · 1 line
2.20.1
#3 lore raw

PATCH v2 2/4 warp7: remove unused usb configs

In reply to Joris Offouga
Quoted 4 lines

With commit 6b503f9e6549("warp7: Switch to DM USB"). These configs are not necessary

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#4 lore raw

PATCH v2 3/4 arm: dts: imx7s-warp7: Move u-boot specific node in u-boot.dtsi

In reply to Joris Offouga

These nodes are not in upstream kernel, so move these in u-boot.dtsi

---
changes v1->v2:
fix stdoutpath in to stdout-path
add commit log

 arch/arm/dts/imx7s-warp-u-boot.dtsi | 10 ++++++++++
 arch/arm/dts/imx7s-warp.dts         |  9 ---------
 2 files changed, 10 insertions(+), 9 deletions(-)
 create mode 100644 arch/arm/dts/imx7s-warp-u-boot.dtsi
arch/arm/dts/imx7s-warp-u-boot.dtsi new file +10 -0
new file mode 100644
index 0000000000..6319840b1c
@@ -0,0 +1,10 @@
+/ {
+    aliases {
+        mmc0 = &usdhc3;
+        usb0 = &usbotg1;
+    };
+
+    chosen {
+        stdout-path = &uart1;
+    };
+};
arch/arm/dts/imx7s-warp.dts +0 -9
index db5ef67eb1..f7ba2c0a24 100644
@@ -17,15 +17,6 @@
 		reg = <0x80000000 0x20000000>;
 	};
 
-	aliases {
-		mmc0 = &usdhc3;
-		usb0 = &usbotg1;
-	};
-
-	chosen {
-		stdout-path = &uart1;
-	};
-
 	gpio-keys {
 		compatible = "gpio-keys";
 		pinctrl-0 = <&pinctrl_gpio>;
Signature · 1 line
2.20.1
#6 lore raw

PATCH v2 3/4 arm: dts: imx7s-warp7: Move u-boot specific node in u-boot.dtsi

In reply to Joris Offouga
Quoted 3 lines

These nodes are not in upstream kernel, so move these in u-boot.dtsi

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#7 lore raw

PATCH v2 4/4 mx7dsabre: Fix usbtog probe when use dfu or ums

In reply to Joris Offouga

Before:
=> ums 0 mmc 0
UMS: LUN 0, dev 0, hwpart 0, sector 0x0, count 0x1dacc00 usb dr_mode not found
CTRL+C - Operation aborted
=> dfu 0 mmc 0
usb dr_mode not found

After :
=> ums 0 mmc 0
UMS: LUN 0, dev 0, hwpart 0, sector 0x0, count 0x1dacc00 => dfu 0 mmc 0

---
changes v1->v2:
none

 arch/arm/dts/imx7d-sdb-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/dts/imx7d-sdb-u-boot.dtsi +4 -0
index 05dd74eee1..b78358fa13 100644
@@ -1,3 +1,7 @@
 &fec2 {
 	status = "disable";
 };
+
+&usbotg1 {
+	dr_mode = "peripheral";
+};
Signature · 1 line
2.20.1
reviewer
#8 lore raw

PATCH v2 4/4 mx7dsabre: Fix usbtog probe when use dfu or ums

Quoted 9 lines · Joris Offouga

Before:
=> ums 0 mmc 0
UMS: LUN 0, dev 0, hwpart 0, sector 0x0, count 0x1dacc00 usb dr_mode not found
CTRL+C - Operation aborted
=> dfu 0 mmc 0
usb dr_mode not found

Quoted 6 lines

After :
=> ums 0 mmc 0
UMS: LUN 0, dev 0, hwpart 0, sector 0x0, count 0x1dacc00 => dfu 0 mmc 0

#9 lore raw

PATCH v2 4/4 mx7dsabre: Fix usbtog probe when use dfu or ums

In reply to Joris Offouga
Quoted 11 lines

Before:
=> ums 0 mmc 0
UMS: LUN 0, dev 0, hwpart 0, sector 0x0, count 0x1dacc00 usb dr_mode not found
CTRL+C - Operation aborted
=> dfu 0 mmc 0
usb dr_mode not found
After :
=> ums 0 mmc 0
UMS: LUN 0, dev 0, hwpart 0, sector 0x0, count 0x1dacc00 => dfu 0 mmc 0

Quoted 2 lines

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#10 lore raw

PATCH v2 1/4 warp7: Fix the pmic_get() parameter in the DM case

In reply to Joris Offouga
Quoted 5 lines

When pmic_get() is used with DM the first parameter must be the complete node name plus the unit address, so fix it accordingly

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================