Skip to contentSkip to conversation

openrisc: configs: Cleanup CONFIG_CROSS_COMPILE

PATCH In review Krzysztof Kozlowski 3 participants 4 messages Jan 30, 2020 – Jan 31, 2020 Openrisc architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 openrisc: configs: Cleanup CONFIG_CROSS_COMPILE

CONFIG_CROSS_COMPILE is gone since commit f1089c92da79 ("kbuild: remove CONFIG_CROSS_COMPILE support").

---
 arch/openrisc/configs/or1ksim_defconfig    | 1 -
 arch/openrisc/configs/simple_smp_defconfig | 1 -
 2 files changed, 2 deletions(-)
arch/openrisc/configs/or1ksim_defconfig +0 -1
index d8ff4f8ffb88..75f2da324d0e 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="or1k-linux-"
 CONFIG_NO_HZ=y
 CONFIG_LOG_BUF_SHIFT=14
 CONFIG_BLK_DEV_INITRD=y
arch/openrisc/configs/simple_smp_defconfig +0 -1
index 64278992df9c..ff49d868e040 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="or1k-linux-"
 CONFIG_LOCALVERSION="-simple-smp"
 CONFIG_NO_HZ=y
 CONFIG_LOG_BUF_SHIFT=14
Signature · 1 line
2.17.1
maintainer
#1 lore raw

+cc: Masahiro,

Quoted 2 lines · Krzysztof Kozlowski

CONFIG_CROSS_COMPILE is gone since commit f1089c92da79 ("kbuild: remove CONFIG_CROSS_COMPILE support").

I see this patch is already in, but does it break 0-day test tools that depend on this CONFIG_CROSS_COMPILE setup? I guess its been in since 2018, so there should be no problem.

Can you also help to update "Documentation/openrisc/openrisc_port.rst"? It mentions the build steps are:

Build the Linux kernel as usual::

make ARCH=openrisc defconfig
make ARCH=openrisc

This now changes, I used to use make ARCH=openrisc CROSS_COMPILE=or1k-linux- is this still going to work?

-Stafford

Quoted 27 lines
---
 arch/openrisc/configs/or1ksim_defconfig    | 1 -
 arch/openrisc/configs/simple_smp_defconfig | 1 -
 2 files changed, 2 deletions(-)
arch/openrisc/configs/or1ksim_defconfig +0 -1
index d8ff4f8ffb88..75f2da324d0e 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="or1k-linux-"
 CONFIG_NO_HZ=y
 CONFIG_LOG_BUF_SHIFT=14
 CONFIG_BLK_DEV_INITRD=y
arch/openrisc/configs/simple_smp_defconfig +0 -1
index 64278992df9c..ff49d868e040 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="or1k-linux-"
 CONFIG_LOCALVERSION="-simple-smp"
 CONFIG_NO_HZ=y
 CONFIG_LOG_BUF_SHIFT=14
Signature · 1 line
2.17.1
#2 lore raw

Hi Stafford,

Quoted 10 lines · Stafford Horne

+cc: Masahiro,

Quoted 2 lines · Krzysztof Kozlowski

CONFIG_CROSS_COMPILE is gone since commit f1089c92da79 ("kbuild: remove CONFIG_CROSS_COMPILE support").

I see this patch is already in, but does it break 0-day test tools that depend on this CONFIG_CROSS_COMPILE setup? I guess its been in since 2018, so there should be no problem.

As far as I understand, the 0-day bot passes CROSS_COMPILE= from the command line because I see it in "make.cross" script, which is attached in reports.

I did not hear any complaint from 0-day bot maintainers.

Quoted 10 lines

Can you also help to update "Documentation/openrisc/openrisc_port.rst"? It mentions the build steps are:

Build the Linux kernel as usual::

make ARCH=openrisc defconfig
make ARCH=openrisc

This now changes, I used to use make ARCH=openrisc CROSS_COMPILE=or1k-linux- is this still going to work?

Yes, it still works.

Quoted 29 lines

-Stafford

Quoted 27 lines
---
 arch/openrisc/configs/or1ksim_defconfig    | 1 -
 arch/openrisc/configs/simple_smp_defconfig | 1 -
 2 files changed, 2 deletions(-)
arch/openrisc/configs/or1ksim_defconfig +0 -1
index d8ff4f8ffb88..75f2da324d0e 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="or1k-linux-"
 CONFIG_NO_HZ=y
 CONFIG_LOG_BUF_SHIFT=14
 CONFIG_BLK_DEV_INITRD=y
arch/openrisc/configs/simple_smp_defconfig +0 -2
index 64278992df9c..ff49d868e040 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="or1k-linux-"
 CONFIG_LOCALVERSION="-simple-smp"
 CONFIG_NO_HZ=y
 CONFIG_LOG_BUF_SHIFT=14
--

2.17.1

Signature · 2 lines
Best Regards
Masahiro Yamada
#3 lore raw
In reply to Stafford Horne
Quoted 14 lines · Stafford Horne

+cc: Masahiro,

Quoted 2 lines · Krzysztof Kozlowski

CONFIG_CROSS_COMPILE is gone since commit f1089c92da79 ("kbuild: remove CONFIG_CROSS_COMPILE support").

I see this patch is already in, but does it break 0-day test tools that depend on this CONFIG_CROSS_COMPILE setup? I guess its been in since 2018, so there should be no problem.

Can you also help to update "Documentation/openrisc/openrisc_port.rst"? It mentions the build steps are:

Quoted 7 lines

Build the Linux kernel as usual::

make ARCH=openrisc defconfig
make ARCH=openrisc

This now changes, I used to use make ARCH=openrisc CROSS_COMPILE=or1k-linux- is this still going to work?

All cross compile platforms are being built like this, so I guess openrisc should not be different. I will send a patch for the doc update.

Best regards,
Krzysztof