Skip to contentSkip to conversation

bitbake.conf: drop pod2man from hosttools

PATCH In review Alexander Kanavin 2 participants 3 messages Jan 31, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bitbake.conf: drop pod2man from hosttools

pod2man writes the current date into manpages, and while later versions of it respect SOURCE_DATE_EPOCH and use that instead, earlier versions do not. This was found to cause reproducibility issues.

This patch replaces host version of pod2man with one from perl-native.

[YOCTO #13755]

---
 meta/conf/bitbake.conf                               | 2 +-
 meta/recipes-devtools/opkg-utils/opkg-utils_0.4.2.bb | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
meta/conf/bitbake.conf +1 -1
index b6aa9f33e92..f7544b35c6e 100644
@@ -488,7 +488,7 @@ HOSTTOOLS += " \
     cpp cut date dd diff diffstat dirname du echo egrep env expand expr false \
     fgrep file find flock g++ gawk gcc getconf getopt git grep gunzip gzip \
     head hostname iconv id install ld ldd ln ls make makeinfo md5sum mkdir mknod \
-    mktemp mv nm objcopy objdump od patch perl pod2man pr printf pwd \
+    mktemp mv nm objcopy objdump od patch perl pr printf pwd \
     python3 ranlib readelf readlink realpath rm rmdir rpcgen sed seq sh sha256sum \
     sleep sort split stat strings strip tail tar tee test touch tr true uname \
     uniq wc wget which xargs \
meta/recipes-devtools/opkg-utils/opkg-utils_0.4.2.bb +2 -0
index 6495726500f..8e7ef00b087 100644
@@ -18,6 +18,8 @@ TARGET_CC_ARCH += "${LDFLAGS}"
 
 RDEPENDS_${PN} += "bash"
 
+inherit perlnative
+
 # For native builds we use the host Python
 PYTHONRDEPS = "python3 python3-shell python3-io python3-math python3-crypt python3-logging python3-fcntl python3-pickle python3-compression python3-stringold"
 PYTHONRDEPS_class-native = ""
Signature · 1 line
2.25.0
#1 lore raw
Quoted 21 lines · Alexander Kanavin

pod2man writes the current date into manpages, and while later versions of it respect SOURCE_DATE_EPOCH and use that instead, earlier versions do not. This was found to cause reproducibility issues.

This patch replaces host version of pod2man with one from perl-native.

[YOCTO #13755]

---
  meta/conf/bitbake.conf                               | 2 +-
  meta/recipes-devtools/opkg-utils/opkg-utils_0.4.2.bb | 2 ++
  2 files changed, 3 insertions(+), 1 deletion(-)
meta/conf/bitbake.conf +0 -0
index b6aa9f33e92..f7544b35c6e 100644

meta/conf/bitbake.conf HOSTTOOLS += " \ · line 491

Quoted 5 lines
meta/conf/bitbake.conf +1 -1
@@ -488,7 +488,7 @@ HOSTTOOLS += " \
      cpp cut date dd diff diffstat dirname du echo egrep env expand expr false \
      fgrep file find flock g++ gawk gcc getconf getopt git grep gunzip gzip \
      head hostname iconv id install ld ldd ln ls make makeinfo md5sum mkdir mknod \
-    mktemp mv nm objcopy objdump od patch perl pod2man pr printf pwd \
+    mktemp mv nm objcopy objdump od patch perl pr printf pwd \

There has been some reluctance to dropping pod2man from the hosttools and requiring perl-native as a build time dependency due to the negative impact on the build time.

meta/recipes-devtools/opkg-utils/opkg-utils_0.4.2.bb TARGET_CC_ARCH += "${LDFLAGS}" · line 22

Quoted 13 lines
meta/conf/bitbake.conf +0 -0
      python3 ranlib readelf readlink realpath rm rmdir rpcgen sed seq sh sha256sum \
      sleep sort split stat strings strip tail tar tee test touch tr true uname \
      uniq wc wget which xargs \
meta/recipes-devtools/opkg-utils/opkg-utils_0.4.2.bb +2 -0
index 6495726500f..8e7ef00b087 100644
@@ -18,6 +18,8 @@ TARGET_CC_ARCH += "${LDFLAGS}"
 
  RDEPENDS_${PN} += "bash"
 
+inherit perlnative
+

Is this the only recipe that needs pod2man?

Quoted 3 lines
meta/recipes-devtools/opkg-utils/opkg-utils_0.4.2.bb +0 -0
  # For native builds we use the host Python
  PYTHONRDEPS = "python3 python3-shell python3-io python3-math python3-crypt python3-logging python3-fcntl python3-pickle python3-compression python3-stringold"
  PYTHONRDEPS_class-native = ""
#2 lore raw
Quoted 4 lines · Joshua Watt

There has been some reluctance to dropping pod2man from the hosttools and requiring perl-native as a build time dependency due to the negative impact on the build time.

In typical builds perl-native is already built fairly early as it is needed by rpm-native
(which in turn is needed by do_package regardless of package format).

Quoted 2 lines

Is this the only recipe that needs pod2man?

No, but the rest of them including binutils should get it thorough opkg-utils dependency. I ran a successful world build to confirm that. (there might be corner cases which the AB will show, but the basic build is covered)

Alex