kconfig: fix broken dependency in randconfig-generated .config
PATCH 1/1 kconfig: fix broken dependency in randconfig-generated .config
Running randconfig on arm64 using KCONFIG_SEED=0x40C5E904 (e.g. on v5.5) produces the .config with CONFIG_EFI=y and CONFIG_CPU_BIG_ENDIAN=y, which does not meet the !CONFIG_CPU_BIG_ENDIAN dependency.
This is because the user choice for CONFIG_CPU_LITTLE_ENDIAN vs CONFIG_CPU_BIG_ENDIAN is set by randomize_choice_values() after the value of CONFIG_EFI is calculated.
When this happens, the has_changed flag should be set.
Currently, it takes the result from the last iteration. It should accumulate all the results of the loop.
---
scripts/kconfig/confdata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/kconfig/confdata.c +1 -1
@@ -1353,7 +1353,7 @@ bool conf_set_all_new_symbols(enum conf_def_mode mode)sym_calc_value (csym);if (mode == def_random) - has_changed =randomize_choice_values (csym); + has_changed |=randomize_choice_values (csym);else {set_all_choice_values (csym); has_changed = true;
Signature · 1 line
2.17.1
Quoted 9 lines · Masahiro Yamada
Running randconfig on arm64 using KCONFIG_SEED=0x40C5E904 (e.g. on v5.5) produces the .config with
CONFIG_EFI=yandCONFIG_CPU_BIG_ENDIAN=y, which does not meet the !CONFIG_CPU_BIG_ENDIAN dependency.This is because the user choice for
CONFIG_CPU_LITTLE_ENDIANvsCONFIG_CPU_BIG_ENDIANis set byrandomize_choice_values()after the value ofCONFIG_EFIis calculated.
Quoted 8 lines
When this happens, the
has_changedflag should be set.Currently, it takes the result from the last iteration. It should accumulate all the results of the loop.
Reported-by Vincenzo Frascino <[email protected]>Signed-off-by Masahiro Yamada <[email protected]>---
Maybe, this could be tagged:
in randconfig")
Quoted 19 lines
scripts/kconfig/confdata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/kconfig/confdata.c +1
-2@@ -1353,7 +1353,7 @@ bool conf_set_all_new_symbols(enum conf_def_mode mode)sym_calc_value (csym);if (mode == def_random) - has_changed =randomize_choice_values (csym); + has_changed |=randomize_choice_values (csym);else {set_all_choice_values (csym); has_changed = true; --2.17.1
Signature · 2 lines
Best Regards Masahiro Yamada
Vincenzo Frascino
Reviewed-byQuoted 15 lines · Masahiro Yamada
Quoted 14 lines · Masahiro Yamada
Running randconfig on arm64 using KCONFIG_SEED=0x40C5E904 (e.g. on v5.5) produces the .config with
CONFIG_EFI=yandCONFIG_CPU_BIG_ENDIAN=y, which does not meet the !CONFIG_CPU_BIG_ENDIAN dependency.This is because the user choice for
CONFIG_CPU_LITTLE_ENDIANvsCONFIG_CPU_BIG_ENDIANis set byrandomize_choice_values()after the value ofCONFIG_EFIis calculated.When this happens, the
has_changedflag should be set.Currently, it takes the result from the last iteration. It should accumulate all the results of the loop.
Quoted 11 lines
Quoted 3 lines
Reported-by Vincenzo Frascino <[email protected]>Signed-off-by Masahiro Yamada <[email protected]>---
Maybe, this could be tagged:
Fixes 3b9a19e08960 ("kconfig: loop as long as we changed some symbolsin randconfig")
Quoted 23 lines
Quoted 21 lines
scripts/kconfig/confdata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/kconfig/confdata.c +1
-2@@ -1353,7 +1353,7 @@ bool conf_set_all_new_symbols(enum conf_def_mode mode)sym_calc_value (csym);if (mode == def_random) - has_changed =randomize_choice_values (csym); + has_changed |=randomize_choice_values (csym);else {set_all_choice_values (csym); has_changed = true; --2.17.1
Signature · 2 lines
Regards, Vincenzo