perf test: Fix test trace+probe_vfs_getname.sh
PATCH v2 1/1 perf test: Fix test trace+probe_vfs_getname.sh
This test places a kprobe to function getname_flags() in the kernel which has the following prototype:
struct filename *
getname_flags(const char __user *filename, int flags, int *empty)
Variable filename points to a filename located in user space memory. Looking at
commit 88903c464321c ("tracing/probe: Add ustring type for user-space string") the kprobe should indicate that user space memory is accessed.
So I suggest the following patch to specify user space memory access. Try type 'ustring' first and use type 'string' in case 'ustring' is not supported.
Signed-off-by Thomas Richter <[email protected]>
--- tools/perf/tests/shell/lib/probe_vfs_getname.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/perf/tests/shell/lib/probe_vfs_getname.sh +3 -1
@@ -13,7 +13,9 @@ add_probe_vfs_getname() { local verbose=$1 if [ $had_vfs_getname -eq 1 ] ; then line=$(perf probe -L getname_flags 2>&1 | egrep 'result.*=.*filename;' | sed -r 's/[[:space:]]+([[:digit:]]+)[[:space:]]+result->uptr.*/\1/') - perf probe -q "vfs_getname=getname_flags:${line} pathname=result->name:string" || \ + perf probe -q "vfs_getname=getname_flags:${line} pathname=result->uptr:ustring" || \ + perf probe $verbose "vfs_getname=getname_flags:${line} pathname=filename:ustring" || \ + perf probe -q "vfs_getname=getname_flags:${line} pathname=result->uptr:string" || \ perf probe $verbose "vfs_getname=getname_flags:${line} pathname=filename:string" fi }
Signature · 1 line
2.21.0