peap: Ensure TLV uniqueness
PATCH 1/1 peap: Ensure TLV uniqueness
Processing the duplicated TLVs while connecting to a malicious AP may lead to overflow of the response buffer. This patch ensures that the duplicated TLVs are not parsed.
--- src/eap-peap.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
src/eap-peap.c +12 -0
@@ -353,6 +353,8 @@ static int eap_extensions_process_tlvs(struct eap_state *eap,int response_len =0 ;uint16_t tlv_type;uint16_t tlv_value_len; +bool seen_result_tlv = false; +bool seen_cryptobinding_tlv = false;while (data_len >=EAP_EXTENSIONS_TLV_HEADER_LEN ) {int response_tlv_len =0 ;
@@ -370,12 +372,22 @@ static int eap_extensions_process_tlvs(struct eap_state *eap,switch (tlv_type) {case EAP_EXTENSIONS_TLV_TYPE_RESULT : +if (seen_result_tlv) +return -EBADMSG ; + + seen_result_tlv = true; + response_tlv_len =eap_extensions_handle_result_tlv (eap, data, tlv_value_len, response, result);break ;case EAP_EXTENSIONS_TLV_TYPE_CRYPTOBINDING : +if (seen_cryptobinding_tlv) +return -EBADMSG ; + + seen_cryptobinding_tlv = true; + response_tlv_len =eap_extensions_handle_cryptobinding_tlv (eap, data, tlv_value_len, response);
Signature · 1 line
2.13.6
Denis Kenzior
AppliedHi Tim,
Quoted 7 lines · Tim Kourt
Processing the duplicated TLVs while connecting to a malicious AP may lead to overflow of the response buffer. This patch ensures that the duplicated TLVs are not parsed.
--- src/eap-peap.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Applied, thanks.
Regards,
-Denis