drm: shmobile: Reduce include dependencies
PATCH v3 1/1 drm: shmobile: Reduce include dependencies
This file doesn't need everything provided by <linux/kernel.h>. All it needs are some types, which are provided by <drm/drm_mode.h>.
Drop unneeded <linux/kernel.h> completely.
---
v3: Drop header completely (Laurent)
include/linux/platform_data/shmob_drm.h | 2 -- 1 file changed, 2 deletions(-)
include/linux/platform_data/shmob_drm.h +0 -2
@@ -10,8 +10,6 @@#ifndef __SHMOB_DRM_H__#define __SHMOB_DRM_H__ -#include <linux/kernel.h> -#include <drm/drm_mode.h> enum shmob_drm_clk_source {
Signature · 1 line
2.24.1
Quoted 4 lines · Andy Shevchenko
This file doesn't need everything provided by <
linux/kernel.h>. All it needs are some types, which are provided by <drm/drm_mode.h>.Drop unneeded <
linux/kernel.h> completely.
Any comments on this?
Quoted 23 lines
Signed-off-by Andy Shevchenko <[email protected]>---
v3: Drop header completely (Laurent)include/linux/platform_data/shmob_drm.h | 2 -- 1 file changed, 2 deletions(-)include/linux/platform_data/shmob_drm.h +0
-2@@ -10,8 +10,6 @@#ifndef __SHMOB_DRM_H__#define __SHMOB_DRM_H__ -#include <linux/kernel.h> -#include <drm/drm_mode.h> enum shmob_drm_clk_source {Signature · 1 line
2.24.1
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi Andy,
Thank you for the patch, and sorry for the delay.
Quoted 2 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko
This file doesn't need everything provided by <
linux/kernel.h>.
s/everything/anything/
Quoted 5 lines
Quoted 3 lines
All it needs are some types, which are provided by <
drm/drm_mode.h>.Drop unneeded <
linux/kernel.h> completely.Any comments on this?
Feel free to push :-)
Quoted 19 lines
Quoted 19 lines
Signed-off-by Andy Shevchenko <[email protected]>---
v3: Drop header completely (Laurent)include/linux/platform_data/shmob_drm.h | 2 -- 1 file changed, 2 deletions(-)include/linux/platform_data/shmob_drm.h +0
-2@@ -10,8 +10,6 @@#ifndef __SHMOB_DRM_H__#define __SHMOB_DRM_H__ -#include <linux/kernel.h> -#include <drm/drm_mode.h> enum shmob_drm_clk_source {
Signature · 3 lines
Regards, Laurent Pinchart
Imre Deak
AppliedQuoted 12 lines · Laurent Pinchart
Hi Andy,
Thank you for the patch, and sorry for the delay.
Quoted 2 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko
This file doesn't need everything provided by <
linux/kernel.h>.s/everything/anything/
Quoted 2 lines
Quoted 2 lines
All it needs are some types, which are provided by <
drm/drm_mode.h>.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Drop unneeded <
linux/kernel.h> completely.Any comments on this?
Reviewed-by Laurent Pinchart <[email protected]>Feel free to push :-)
Pushed to drm-misc-next, thanks for the patch and review.
Quoted 29 lines
Quoted 20 lines
Quoted 20 lines
Signed-off-by Andy Shevchenko <[email protected]>---
v3: Drop header completely (Laurent)include/linux/platform_data/shmob_drm.h | 2 -- 1 file changed, 2 deletions(-)include/linux/platform_data/shmob_drm.h +0
-2@@ -10,8 +10,6 @@#ifndef __SHMOB_DRM_H__#define __SHMOB_DRM_H__ -#include <linux/kernel.h> -#include <drm/drm_mode.h> enum shmob_drm_clk_source {Signature · 7 lines
Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel