Skip to contentSkip to conversation

mmc: sdhci-msm: Mark sdhci_msm_cqe_disable static

PATCH In review Stephen Boyd 4 participants 4 messages Feb 6, 2020 – Feb 13, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: sdhci-msm: Mark sdhci_msm_cqe_disable static

This function is not exported and only used in this file. Mark it static.

Cc Ritesh Harjani <[email protected]>
Cc Veerabhadrarao Badiganti <[email protected]>
Cc Adrian Hunter <[email protected]>
Cc Douglas Anderson <[email protected]>
---
 drivers/mmc/host/sdhci-msm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-msm.c +1 -1
index c3a160c18047..3955fa5db43c 100644
@@ -1590,7 +1590,7 @@ static u32 sdhci_msm_cqe_irq(struct sdhci_host *host, u32 intmask)
 	return 0;
 }
 
-void sdhci_msm_cqe_disable(struct mmc_host *mmc, bool recovery)
+static void sdhci_msm_cqe_disable(struct mmc_host *mmc, bool recovery)
 {
 	struct sdhci_host *host = mmc_priv(mmc);
 	unsigned long flags;
Signature · 1 line
Sent by a computer, using git, on the internet
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 4 lines · Stephen Boyd

This function is not exported and only used in this file. Mark it static.

Quoted 8 lines
Cc Ritesh Harjani <[email protected]>
Cc Veerabhadrarao Badiganti <[email protected]>
Cc Adrian Hunter <[email protected]>
Cc Douglas Anderson <[email protected]>
---
 drivers/mmc/host/sdhci-msm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Fixes 87a8df0dce6a ("mmc: sdhci-msm: Add CQHCI support for sdhci-msm")
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Stephen Boyd
Quoted 8 lines · Stephen Boyd

This function is not exported and only used in this file. Mark it static.

Cc Ritesh Harjani <[email protected]>
Cc Veerabhadrarao Badiganti <[email protected]>
Cc Adrian Hunter <[email protected]>
Cc Douglas Anderson <[email protected]>
Quoted 18 lines
---
 drivers/mmc/host/sdhci-msm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-msm.c +1 -1
index c3a160c18047..3955fa5db43c 100644
@@ -1590,7 +1590,7 @@ static u32 sdhci_msm_cqe_irq(struct sdhci_host *host, u32 intmask)
 	return 0;
 }
 
-void sdhci_msm_cqe_disable(struct mmc_host *mmc, bool recovery)
+static void sdhci_msm_cqe_disable(struct mmc_host *mmc, bool recovery)
 {
 	struct sdhci_host *host = mmc_priv(mmc);
 	unsigned long flags;
#3 lore raw
In reply to Stephen Boyd
Quoted 9 lines · Stephen Boyd

This function is not exported and only used in this file. Mark it static.

Cc Ritesh Harjani <[email protected]>
Cc Veerabhadrarao Badiganti <[email protected]>
Cc Adrian Hunter <[email protected]>
Cc Douglas Anderson <[email protected]>

Applied for fixes, thanks!

Kind regards
Uffe

Quoted 20 lines
---
 drivers/mmc/host/sdhci-msm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-msm.c +1 -2
index c3a160c18047..3955fa5db43c 100644
@@ -1590,7 +1590,7 @@ static u32 sdhci_msm_cqe_irq(struct sdhci_host *host, u32 intmask)
        return 0;
 }
 
-void sdhci_msm_cqe_disable(struct mmc_host *mmc, bool recovery)
+static void sdhci_msm_cqe_disable(struct mmc_host *mmc, bool recovery)
 {
        struct sdhci_host *host = mmc_priv(mmc);
        unsigned long flags;
--

Sent by a computer, using git, on the internet