RDMA/siw: Remove unwanted WARN_ON in siw_cm_llp_data_ready()
Subsystems (2)
PATCH 1/1 RDMA/siw: Remove unwanted WARN_ON in siw_cm_llp_data_ready()
Warnings like below can fill up the dmesg while disconnecting RDMA connections.
Hence, removing the unwanted WARN_ON.
[72103.557612] WARNING: CPU: 6 PID: 0 at drivers/infiniband/sw/siw/siw_cm.c:1229 siw_cm_llp_data_ready+0xc1/0xd0 [siw] [72103.557677] RIP: 0010:siw_cm_llp_data_ready+0xc1/0xd0 [siw] [72103.557693] Call Trace: [72103.557699] <IRQ> [72103.557711] tcp_data_queue+0x226/0xb40 [72103.557714] tcp_rcv_established+0x220/0x620 [72103.557720] tcp_v4_do_rcv+0x12a/0x1e0 [72103.557722] tcp_v4_rcv+0xb05/0xc00 [72103.557728] ip_local_deliver_finish+0x69/0x210 [72103.557730] ip_local_deliver+0x6b/0xe0 [72103.557735] ip_rcv+0x273/0x362 [72103.557740] __netif_receive_skb_core+0xb35/0xc30 [72103.557752] netif_receive_skb_internal+0x3d/0xb0 [72103.557754] napi_gro_frags+0x13b/0x200 [72103.557788] t4_ethrx_handler+0x433/0x7d0 [cxgb4] [72103.557800] process_responses+0x318/0x580 [cxgb4] [72103.557820] napi_rx_handler+0x14/0x100 [cxgb4] [72103.557822] net_rx_action+0x149/0x3b0 [72103.557826] __do_softirq+0xe3/0x30a [72103.557831] irq_exit+0x100/0x110 [72103.557834] do_IRQ+0x7f/0xe0 [72103.557837] common_interrupt+0xf/0xf [72103.557838] </IRQ>
Signed-off-by Krishnamraju Eraparaju <[email protected]>
--- drivers/infiniband/sw/siw/siw_cm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/infiniband/sw/siw/siw_cm.c +2 -3
@@ -1225,10 +1225,9 @@ static void siw_cm_llp_data_ready(struct sock *sk)read_lock (&sk->sk_callback_lock); cep =sk_to_cep (sk); -if (!cep) { -WARN_ON (1 ); +if (!cep) goto out; - } +siw_dbg_cep (cep,"state: %d\n" , cep->state);switch (cep->state) {
Signature · 1 line
2.23.0.rc0
Jason Gunthorpe
AppliedQuoted 30 lines · Krishnamraju Eraparaju
Warnings like below can fill up the dmesg while disconnecting RDMA connections.
Hence, removing the unwantedWARN_ON.[72103.557612] WARNING: CPU: 6 PID: 0 at drivers/infiniband/sw/siw/siw_cm.c:1229 siw_cm_llp_data_ready+0xc1/0xd0 [siw] [72103.557677] RIP: 0010:siw_cm_llp_data_ready+0xc1/0xd0 [siw] [72103.557693] Call Trace: [72103.557699] <IRQ> [72103.557711] tcp_data_queue+0x226/0xb40 [72103.557714] tcp_rcv_established+0x220/0x620 [72103.557720] tcp_v4_do_rcv+0x12a/0x1e0 [72103.557722] tcp_v4_rcv+0xb05/0xc00 [72103.557728] ip_local_deliver_finish+0x69/0x210 [72103.557730] ip_local_deliver+0x6b/0xe0 [72103.557735] ip_rcv+0x273/0x362 [72103.557740] __netif_receive_skb_core+0xb35/0xc30 [72103.557752] netif_receive_skb_internal+0x3d/0xb0 [72103.557754] napi_gro_frags+0x13b/0x200 [72103.557788] t4_ethrx_handler+0x433/0x7d0 [cxgb4] [72103.557800] process_responses+0x318/0x580 [cxgb4] [72103.557820] napi_rx_handler+0x14/0x100 [cxgb4] [72103.557822] net_rx_action+0x149/0x3b0 [72103.557826] __do_softirq+0xe3/0x30a [72103.557831] irq_exit+0x100/0x110 [72103.557834] do_IRQ+0x7f/0xe0 [72103.557837] common_interrupt+0xf/0xf [72103.557838] </IRQ>
Quoted 4 lines
Signed-off-by Krishnamraju Eraparaju <[email protected]>--- drivers/infiniband/sw/siw/siw_cm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
Applied to for-rc, thanks
Jason