Skip to contentSkip to conversation

oeqa: Use --disable-maintainer-mode configure option

PATCH Superseded Khem Raj 4 participants 4 messages Feb 8, 2020

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH v3 1/1 oeqa: Use --disable-maintainer-mode configure option

since the versions of autotools might differ, and difference in timestamps for configure and system can result in reconfigure lets avoid that by touching the configure script to match system time

Avoids
error: newly created file is older than distributed files!

[YOCTO #13779]

---
v2: Touch configure to match timestamps with system
Move the touch cmd to configure step itself
v3: Use --disable-maintainer-mode

 meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
 meta/lib/oeqa/sdk/cases/buildcpio.py     | 2 +-
 meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
meta/lib/oeqa/runtime/cases/buildcpio.py +1 -1
index 4bd72dd37e..d0f91668b2 100644
@@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase):
     @OEHasPackage(['autoconf'])
     def test_cpio(self):
         self.project.download_archive()
-        self.project.run_configure()
+        self.project.run_configure('--disable-maintainer-mode','')
         self.project.run_make()
         self.project.run_install()
meta/lib/oeqa/sdk/cases/buildcpio.py +1 -1
index b0beafb38f..902e93f623 100644
@@ -28,7 +28,7 @@ class BuildCpioTest(OESDKTestCase):
             self.assertTrue(os.path.isdir(dirs["source"]))
             os.makedirs(dirs["build"])
 
-            self._run("cd {build} && {source}/configure $CONFIGURE_FLAGS".format(**dirs))
+            self._run("cd {build} && {source}/configure --disable-maintainer-mode $CONFIGURE_FLAGS".format(**dirs))
             self._run("cd {build} && make -j".format(**dirs))
             self._run("cd {build} && make install DESTDIR={install}".format(**dirs))
 
meta/lib/oeqa/selftest/cases/meta_ide.py +1 -1
index 809142559a..87cc2844a8 100644
@@ -43,7 +43,7 @@ class MetaIDE(OESelftestTestCase):
                         "https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
                         self.tmpdir_metaideQA, self.td['DATETIME'], dl_dir=dl_dir)
         self.project.download_archive()
-        self.assertEqual(self.project.run_configure(), 0,
+        self.assertEqual(self.project.run_configure('--disable-maintainer-mode',''), 0,
                         msg="Running configure failed")
         self.assertEqual(self.project.run_make(), 0,
                         msg="Running make failed")
Signature · 1 line
2.25.0
#1 lore raw

✗ patchtest: failure for oeqa: Use --disable-maintainer-mode configure option

== Series Details ==

Series: oeqa: Use --disable-maintainer-mode configure option
Revision: 1
URL : https://patchwork.openembedded.org/series/22483/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 6f6a6bbac6)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#2 lore raw
In reply to Khem Raj
Quoted 4 lines · Khem Raj

since the versions of autotools might differ, and difference in timestamps for configure and system can result in reconfigure lets avoid that by touching the configure script to match system time

Maybe align commit message with patch, and mention --disable-maintainer-mode ?

Jacob

Quoted 56 lines

Avoids
error: newly created file is older than distributed files!

[YOCTO #13779]

---
v2: Touch configure to match timestamps with system
Move the touch cmd to configure step itself
v3: Use --disable-maintainer-mode

  meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
  meta/lib/oeqa/sdk/cases/buildcpio.py     | 2 +-
  meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)
meta/lib/oeqa/runtime/cases/buildcpio.py +1 -1
index 4bd72dd37e..d0f91668b2 100644
@@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase):
      @OEHasPackage(['autoconf'])
      def test_cpio(self):
          self.project.download_archive()
-        self.project.run_configure()
+        self.project.run_configure('--disable-maintainer-mode','')
          self.project.run_make()
          self.project.run_install()
meta/lib/oeqa/sdk/cases/buildcpio.py +1 -1
index b0beafb38f..902e93f623 100644
@@ -28,7 +28,7 @@ class BuildCpioTest(OESDKTestCase):
              self.assertTrue(os.path.isdir(dirs["source"]))
              os.makedirs(dirs["build"])
 
-            self._run("cd {build} && {source}/configure $CONFIGURE_FLAGS".format(**dirs))
+            self._run("cd {build} && {source}/configure --disable-maintainer-mode $CONFIGURE_FLAGS".format(**dirs))
              self._run("cd {build} && make -j".format(**dirs))
              self._run("cd {build} && make install DESTDIR={install}".format(**dirs))
 
meta/lib/oeqa/selftest/cases/meta_ide.py +1 -1
index 809142559a..87cc2844a8 100644
@@ -43,7 +43,7 @@ class MetaIDE(OESelftestTestCase):
                          "https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
                          self.tmpdir_metaideQA, self.td['DATETIME'], dl_dir=dl_dir)
          self.project.download_archive()
-        self.assertEqual(self.project.run_configure(), 0,
+        self.assertEqual(self.project.run_configure('--disable-maintainer-mode',''), 0,
                          msg="Running configure failed")
          self.assertEqual(self.project.run_make(), 0,
                          msg="Running make failed")
#3 lore raw
In reply to Khem Raj
Quoted 8 lines · Khem Raj

since the versions of autotools might differ, and difference in timestamps for configure and system can result in reconfigure lets avoid
that by touching the configure script to match system time

Avoids
error: newly created file is older than distributed files!

Quoted 8 lines

[YOCTO #13779]

---
v2: Touch configure to match timestamps with system
Move the touch cmd to configure step itself
v3: Use --disable-maintainer-mode

I tweaked the commit message but it failed during testing:

https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/1545
https://autobuilder.yoctoproject.org/typhoon/#/builders/73/builds/1541
(and on other arches too)

Cheers,

Richard