i915/pm_backlight: ensure driver is loaded before checking backlight
PATCH 1/1 i915/pm_backlight: ensure driver is loaded before checking backlight
Checking the existence of the backlight interface before ensuring the driver is loaded skips whenever the test is run without the driver loaded. None of the tests would work properly if they were run as the first thing or after tests that unload the driver.
Open the driver (and thus probe it as needed) as the first thing.
(This is the low-hanging fruit. A proper test for skipping would be based on the presence of embedded displays, not based on the presence of the interface we're aiming to test.)
--- tests/i915/i915_pm_backlight.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
tests/i915/i915_pm_backlight.c +4 -4
@@ -195,10 +195,6 @@ igt_maindrmModeModeInfo *mode;igt_plane_t *primary; -/* Get the max value and skip the whole test if sysfs interface not available */ -igt_skip_on (backlight_read (&old,"brightness" )); -igt_assert (backlight_read (&context.max,"max_brightness" ) >-1 ); -/* * Backlight tests requires the output to be enabled, * try to enable all.
@@ -206,6 +202,10 @@ igt_mainkmstest_set_vt_graphics_mode ();igt_display_require (&display,drm_open_driver (DRIVER_INTEL )); +/* Get the max value and skip the whole test if sysfs interface not available */ +igt_skip_on (backlight_read (&old,"brightness" )); +igt_assert (backlight_read (&context.max,"max_brightness" ) >-1 ); +/* should be ../../cardX-$output */ igt_assert_lt (12 ,readlink (BACKLIGHT_PATH "/device" , full_name,sizeof (full_name) -1 )); name =basename (full_name);
Signature · 6 lines
2.20.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Jani Nikula (2020-02-11 11:16:34)
Quoted 6 lines
Checking the existence of the backlight interface before ensuring the driver is loaded skips whenever the test is run without the driver loaded. None of the tests would work properly if they were run as the first thing or after tests that unload the driver.
Open the driver (and thus probe it as needed) as the first thing.
Quoted 3 lines
(This is the low-hanging fruit. A proper test for skipping would be based on the presence of embedded displays, not based on the presence of the interface we're aiming to test.)
Slightly different test idea. Here we say this is a test for particular interface, what you have in mind is a requirement that if available HW, the kernel *must* provide an interface. (I don't really like userspace demanding the kernel makes something available, for the cases were it really can't be done due to some flaw or another. From the HW vendor perspective, such a conformance test is understandable -- but we are focusing on the interfaces the kernel does expose and verifying that work as expected.)
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 14 lines · Chris Wilson
Quoting Jani Nikula (2020-02-11 11:16:34)
Quoted 6 lines
Checking the existence of the backlight interface before ensuring the driver is loaded skips whenever the test is run without the driver loaded. None of the tests would work properly if they were run as the first thing or after tests that unload the driver.
Open the driver (and thus probe it as needed) as the first thing.
Reviewed-by Chris Wilson <[email protected]>Quoted 3 lines
(This is the low-hanging fruit. A proper test for skipping would be based on the presence of embedded displays, not based on the presence of the interface we're aiming to test.)
Quoted 8 lines
Slightly different test idea. Here we say this is a test for particular interface, what you have in mind is a requirement that if available HW, the kernel *must* provide an interface. (I don't really like userspace demanding the kernel makes something available, for the cases were it really can't be done due to some flaw or another. From the HW vendor perspective, such a conformance test is understandable -- but we are focusing on the interfaces the kernel does expose and verifying that work as expected.)
That's fair. I'll drop the parenthesized paragraph before pushing.
Thanks for the reviews.
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 5 lines · Jani Nikula
Checking the existence of the backlight interface before ensuring the driver is loaded skips whenever the test is run without the driver loaded. None of the tests would work properly if they were run as the first thing or after tests that unload the driver.
Quoted 7 lines
Open the driver (and thus probe it as needed) as the first thing.
(This is the low-hanging fruit. A proper test for skipping would be based on the presence of embedded displays, not based on the presence of the interface we're aiming to test.)
Signed-off-by Jani Nikula <[email protected]>
Quoted 37 lines
--- tests/i915/i915_pm_backlight.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)tests/i915/i915_pm_backlight.c +4
-4@@ -195,10 +195,6 @@ igt_maindrmModeModeInfo *mode;igt_plane_t *primary; -/* Get the max value and skip the whole test if sysfs interface not available */ -igt_skip_on (backlight_read (&old,"brightness" )); -igt_assert (backlight_read (&context.max,"max_brightness" ) >-1 ); -/* * Backlight tests requires the output to be enabled, * try to enable all. @@ -206,6 +202,10 @@ igt_mainkmstest_set_vt_graphics_mode ();igt_display_require (&display,drm_open_driver (DRIVER_INTEL )); +/* Get the max value and skip the whole test if sysfs interface not available */ +igt_skip_on (backlight_read (&old,"brightness" )); +igt_assert (backlight_read (&context.max,"max_brightness" ) >-1 ); +/* should be ../../cardX-$output */ igt_assert_lt (12 ,readlink (BACKLIGHT_PATH "/device" , full_name,sizeof (full_name) -1 )); name =basename (full_name);Signature · 6 lines
2.20.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for i915/pm_backlight: ensure driver is loaded before checking backlight
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: i915/pm_backlight: ensure driver is loaded before checking backlight
URL : https://patchwork.freedesktop.org/series/73287/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7909 -> IGTPW_4126
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_4126 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_4126, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4126/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_4126:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_blt:
- fi-snb-2520m: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7909/fi-snb-2520m/igt@i915_selftest@live_blt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4126/fi-snb-2520m/igt@i915_selftest@live_blt.html
Known issues
------------
Here are the changes found in IGTPW_4126 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][3] -> [FAIL][4] ([i915#178])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7909/fi-skl-6770hq/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4126/fi-skl-6770hq/igt@[email protected]
* igt@i915_selftest@live_execlists:
- fi-icl-y: [PASS][5] -> [DMESG-FAIL][6] ([fdo#108569])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7909/fi-icl-y/igt@i915_selftest@live_execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4126/fi-icl-y/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_gem_contexts:
- fi-cfl-8700k: [PASS][7] -> [INCOMPLETE][8] ([i915#424])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7909/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4126/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
- fi-cml-s: [PASS][9] -> [DMESG-FAIL][10] ([i915#877])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7909/fi-cml-s/igt@i915_selftest@live_gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4126/fi-cml-s/igt@i915_selftest@live_gem_contexts.html
* igt@i915_selftest@live_gtt:
- fi-kbl-7500u: [PASS][11] -> [TIMEOUT][12] ([fdo#112271])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7909/fi-kbl-7500u/igt@i915_selftest@live_gtt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4126/fi-kbl-7500u/igt@i915_selftest@live_gtt.html
#### Possible fixes ####
* igt@i915_selftest@live_blt:
- fi-skl-6600u: [INCOMPLETE][13] ([fdo#112429]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7909/fi-skl-6600u/igt@i915_selftest@live_blt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4126/fi-skl-6600u/igt@i915_selftest@live_blt.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][15] ([fdo#111096] / [i915#323]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7909/fi-kbl-7500u/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4126/fi-kbl-7500u/igt@[email protected]
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[fdo#112429]: https://bugs.freedesktop.org/show_bug.cgi?id=112429
[i915#178]: https://gitlab.freedesktop.org/drm/intel/issues/178
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
[i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877
Participating hosts (51 -> 46)
------------------------------
Additional (1): fi-glk-dsi
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5435 -> IGTPW_4126
CI-20190529: 20190529
CI_DRM_7909: fe7b665ac9055da66900b250fd01e0d9ec4c2a3c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4126: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4126/index.html
IGT_5435: 2b6d4476dde53c363b8808ed9f0dd5547ac78641 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4126/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for i915/pm_backlight: ensure driver is loaded before checking backlight (rev2)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: i915/pm_backlight: ensure driver is loaded before checking backlight (rev2)
URL : https://patchwork.freedesktop.org/series/73287/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7914_full -> IGTPW_4130_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/index.html
Known issues
------------
Here are the changes found in IGTPW_4130_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110841])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb1/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#232])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-glk1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-glk1/igt@[email protected]
* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112146]) +6 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb2/igt@[email protected]
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([i915#677]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb1/igt@[email protected]
* igt@gen7_exec_parse@basic-offset:
- shard-hsw: [PASS][9] -> [FAIL][10] ([i915#694]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-hsw5/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-hsw5/igt@[email protected]
* igt@i915_pm_rps@reset:
- shard-iclb: [PASS][11] -> [FAIL][12] ([i915#413])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb1/igt@[email protected]
* igt@kms_big_fb@linear-8bpp-rotate-0:
- shard-tglb: [PASS][13] -> [FAIL][14] ([i915#1172])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-tglb8/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-tglb6/igt@[email protected]
* igt@kms_big_fb@x-tiled-16bpp-rotate-0:
- shard-tglb: [PASS][15] -> [DMESG-FAIL][16] ([i915#402])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-tglb2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-tglb2/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding:
- shard-tglb: [PASS][17] -> [FAIL][18] ([fdo#111703])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-tglb8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-tglb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +6 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-kbl3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-kbl4/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled:
- shard-tglb: [PASS][21] -> [FAIL][22] ([i915#559])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-tglb2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-tglb6/igt@[email protected]
* igt@kms_flip@flip-vs-absolute-wf_vblank:
- shard-tglb: [PASS][23] -> [FAIL][24] ([i915#488])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-tglb3/igt@kms_flip@flip-vs-absolute-wf_vblank.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-tglb2/igt@kms_flip@flip-vs-absolute-wf_vblank.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: [PASS][25] -> [FAIL][26] ([i915#79]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-glk4/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-glk8/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
- shard-tglb: [PASS][27] -> [FAIL][28] ([i915#1183])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-tglb7/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-tglb2/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-apl: [PASS][29] -> [DMESG-WARN][30] ([i915#180]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-apl7/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-apl8/igt@[email protected]
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-tglb: [PASS][31] -> [SKIP][32] ([i915#668]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-tglb6/igt@kms_psr@psr2_cursor_plane_onoff.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-tglb5/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +4 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb2/igt@kms_psr@psr2_suspend.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb1/igt@kms_psr@psr2_suspend.html
* igt@perf_pmu@busy-check-all-vcs1:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#112080]) +10 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb5/igt@[email protected]
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109276]) +22 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb4/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb6/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_isolation@vcs1-clean:
- shard-iclb: [SKIP][39] ([fdo#112080]) -> [PASS][40] +6 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb5/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb2/igt@[email protected]
* igt@gem_exec_schedule@deep-bsd:
- shard-iclb: [SKIP][41] ([fdo#112146]) -> [PASS][42] +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb4/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb3/igt@[email protected]
* igt@gem_partial_pwrite_pread@reads-display:
- shard-hsw: [FAIL][43] ([i915#694]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-hsw1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-hsw7/igt@[email protected]
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [FAIL][45] ([i915#644]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-glk5/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-glk2/igt@[email protected]
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-snb: [DMESG-WARN][47] ([fdo#111870] / [i915#478]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-snb2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-snb2/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][49] ([i915#716]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-glk5/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-glk3/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][51] ([i915#454]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb3/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb7/igt@[email protected]
* igt@i915_pm_rps@waitboost:
- shard-iclb: [FAIL][53] ([i915#413]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb8/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb3/igt@[email protected]
* igt@kms_color@pipe-a-ctm-negative:
- shard-tglb: [FAIL][55] ([i915#1149]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-tglb2/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-tglb1/igt@[email protected]
* igt@kms_color@pipe-c-ctm-max:
- shard-kbl: [FAIL][57] ([i915#168]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-kbl6/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-kbl4/igt@[email protected]
- shard-apl: [FAIL][59] ([i915#168]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-apl7/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-apl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-256x256-onscreen:
- shard-tglb: [FAIL][61] ([fdo#111703]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-tglb3/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-tglb2/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen:
- shard-apl: [FAIL][63] ([i915#54]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-apl2/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-apl8/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-blt-ytiled:
- shard-tglb: [DMESG-FAIL][65] ([i915#402]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-tglb6/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-tglb1/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled:
- shard-tglb: [FAIL][67] ([i915#559]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-tglb3/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-tglb3/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-snb: [DMESG-WARN][69] ([i915#478]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-snb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-indfb-scaledprimary:
- shard-tglb: [SKIP][71] ([i915#668]) -> [PASS][72] +5 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-tglb3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-tglb8/igt@[email protected]
* {igt@kms_hdr@bpc-switch-suspend}:
- shard-apl: [DMESG-WARN][73] ([i915#180]) -> [PASS][74] +5 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-apl1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-apl6/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][75] ([i915#180]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-kbl6/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-kbl2/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-none:
- shard-apl: [FAIL][77] ([i915#899]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-apl8/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-apl6/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][79] ([fdo#109642] / [fdo#111068]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb6/igt@kms_psr2_su@page_flip.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][81] ([fdo#109441]) -> [PASS][82] +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@perf@rc6-disable:
- shard-iclb: [SKIP][83] ([i915#405]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb7/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb6/igt@[email protected]
- shard-hsw: [SKIP][85] ([fdo#109271]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-hsw2/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-hsw2/igt@[email protected]
- shard-kbl: [SKIP][87] ([fdo#109271]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-kbl3/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-kbl2/igt@[email protected]
- shard-apl: [SKIP][89] ([fdo#109271]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-apl1/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-apl2/igt@[email protected]
- shard-tglb: [SKIP][91] ([fdo#111719] / [i915#405]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-tglb2/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-tglb3/igt@[email protected]
- shard-glk: [SKIP][93] ([fdo#109271]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-glk9/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-glk2/igt@[email protected]
* igt@perf@short-reads:
- shard-apl: [TIMEOUT][95] ([fdo#112271] / [i915#51]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-apl2/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-apl2/igt@[email protected]
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][97] ([fdo#109276]) -> [PASS][98] +14 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb6/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb2/igt@[email protected]
* igt@prime_mmap_coherency@ioctl-errors:
- shard-hsw: [FAIL][99] ([i915#831]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-hsw7/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-hsw6/igt@[email protected]
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][101] ([fdo#112080]) -> [FAIL][102] ([IGT#28])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-iclb8/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-iclb4/igt@[email protected]
* igt@gem_tiled_blits@interruptible:
- shard-hsw: [FAIL][103] ([i915#694]) -> [FAIL][104] ([i915#818])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-hsw5/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-hsw5/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [FAIL][105] ([i915#454]) -> [SKIP][106] ([i915#468]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-tglb7/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-tglb2/igt@[email protected]
* igt@i915_pm_rpm@sysfs-read:
- shard-snb: [SKIP][107] ([fdo#109271]) -> [INCOMPLETE][108] ([i915#82])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-snb4/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-snb5/igt@[email protected]
* igt@i915_pm_rpm@universal-planes:
- shard-snb: [INCOMPLETE][109] ([i915#82]) -> [SKIP][110] ([fdo#109271])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-snb2/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-snb2/igt@[email protected]
* igt@runner@aborted:
- shard-snb: ([FAIL][111], [FAIL][112], [FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118]) ([fdo#111870] / [i915#1077] / [i915#698]) -> ([FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126]) ([fdo#111870] / [i915#1077])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-snb2/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-snb5/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-snb5/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-snb2/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-snb4/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-snb2/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-snb2/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7914/shard-snb5/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-snb2/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-snb2/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-snb4/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-snb2/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-snb2/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-snb6/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-snb6/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/shard-snb6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#111719]: https://bugs.freedesktop.org/show_bug.cgi?id=111719
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1077]: https://gitlab.freedesktop.org/drm/intel/issues/1077
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1172]: https://gitlab.freedesktop.org/drm/intel/issues/1172
[i915#1183]: https://gitlab.freedesktop.org/drm/intel/issues/1183
[i915#168]: https://gitlab.freedesktop.org/drm/intel/issues/168
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#232]: https://gitlab.freedesktop.org/drm/intel/issues/232
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#405]: https://gitlab.freedesktop.org/drm/intel/issues/405
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#488]: https://gitlab.freedesktop.org/drm/intel/issues/488
[i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#559]: https://gitlab.freedesktop.org/drm/intel/issues/559
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#698]: https://gitlab.freedesktop.org/drm/intel/issues/698
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#831]: https://gitlab.freedesktop.org/drm/intel/issues/831
[i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899
Participating hosts (10 -> 8)
------------------------------
Missing (2): pig-skl-6260u pig-glk-j5005
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5435 -> IGTPW_4130
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_7914: e674658d367fffb7611ef546b3cd5ec1a372ad34 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4130: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/index.html
IGT_5435: 2b6d4476dde53c363b8808ed9f0dd5547ac78641 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4130/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 5 lines · Jani Nikula
Checking the existence of the backlight interface before ensuring the driver is loaded skips whenever the test is run without the driver loaded. None of the tests would work properly if they were run as the first thing or after tests that unload the driver.
Quoted 7 lines
Open the driver (and thus probe it as needed) as the first thing.
(This is the low-hanging fruit. A proper test for skipping would be based on the presence of embedded displays, not based on the presence of the interface we're aiming to test.)
Signed-off-by Jani Nikula <[email protected]>
Pushed, thanks for the reviews.
BR,
Jani.
Quoted 30 lines
--- tests/i915/i915_pm_backlight.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)tests/i915/i915_pm_backlight.c +4
-4@@ -195,10 +195,6 @@ igt_maindrmModeModeInfo *mode;igt_plane_t *primary; -/* Get the max value and skip the whole test if sysfs interface not available */ -igt_skip_on (backlight_read (&old,"brightness" )); -igt_assert (backlight_read (&context.max,"max_brightness" ) >-1 ); -/* * Backlight tests requires the output to be enabled, * try to enable all. @@ -206,6 +202,10 @@ igt_mainkmstest_set_vt_graphics_mode ();igt_display_require (&display,drm_open_driver (DRIVER_INTEL )); +/* Get the max value and skip the whole test if sysfs interface not available */ +igt_skip_on (backlight_read (&old,"brightness" )); +igt_assert (backlight_read (&context.max,"max_brightness" ) >-1 ); +/* should be ../../cardX-$output */ igt_assert_lt (12 ,readlink (BACKLIGHT_PATH "/device" , full_name,sizeof (full_name) -1 )); name =basename (full_name);
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev