Skip to contentSkip to conversation

nvme: Don't deter users from enabling hwmon support

PATCH In review Jean Delvare 4 participants 4 messages Feb 11, 2020 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme: Don't deter users from enabling hwmon support

I see no good reason for the "If unsure, say N" advice in the description of the NVME_HWMON configuration option. It is not dangerous, it does not select any other option, and has a fairly low overhead.

As the option is already not enabled by default, further suggesting hesitant users to not enable it is not useful anyway. Unlike some other options where the description alone may not be sufficient for users to make a decision, NVME_HWMON is pretty simple to grasp in my opinion, so just let the user do what they want.

Cc Christoph Hellwig <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Keith Busch <[email protected]>
---
 drivers/nvme/host/Kconfig |    2 --
 1 file changed, 2 deletions(-)
drivers/nvme/host/Kconfig +0 -2
@@ -31,8 +31,6 @@ config NVME_HWMON
 	  a hardware monitoring device will be created for each NVMe drive
 	  in the system.
 
-	  If unsure, say N.
-
 config NVME_FABRICS
 	tristate
 
Signature · 7 lines
Jean Delvare
SUSE L3 Support

_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Jean Delvare

I see no good reason for the "If unsure, say N" advice in the description of the NVME_HWMON configuration option. It is not dangerous, it does not select any other option, and has a fairly low overhead.

As the option is already not enabled by default, further suggesting hesitant users to not enable it is not useful anyway. Unlike some other options where the description alone may not be sufficient for users to make a decision, NVME_HWMON is pretty simple to grasp in my opinion, so just let the user do what they want.

Quoted 4 lines
Cc Christoph Hellwig <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Keith Busch <[email protected]>
Quoted 9 lines
---
  drivers/nvme/host/Kconfig |    2 --
  1 file changed, 2 deletions(-)

drivers/nvme/host/Kconfig config NVME_HWMON · line 36

Quoted 8 lines
drivers/nvme/host/Kconfig +0 -2
@@ -31,8 +31,6 @@ config NVME_HWMON
  	  a hardware monitoring device will be created for each NVMe drive
  	  in the system.
 
-	  If unsure, say N.
-
  config NVME_FABRICS
  	tristate
 

_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme

Reviewed-by on v1 1/1
#2 lore raw
In reply to Jean Delvare
Quoted 11 lines · Jean Delvare

I see no good reason for the "If unsure, say N" advice in the description of the NVME_HWMON configuration option. It is not dangerous, it does not select any other option, and has a fairly low overhead.

As the option is already not enabled by default, further suggesting hesitant users to not enable it is not useful anyway. Unlike some other options where the description alone may not be sufficient for users to make a decision, NVME_HWMON is pretty simple to grasp in my opinion, so just let the user do what they want.

Quoted 4 lines
Cc Christoph Hellwig<[email protected]>
Cc Guenter Roeck<[email protected]>
Cc Keith Busch<[email protected]>

_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme

maintainer
#3 lore raw
In reply to Jean Delvare
Quoted 4 lines · Jean Delvare

I see no good reason for the "If unsure, say N" advice in the description of the NVME_HWMON configuration option. It is not dangerous, it does not select any other option, and has a fairly low overhead.

The initial commit probably used one of the other Kconfig options that contained the same wording as a template. But okay, the overly cautious description here looks fine to remove.

Quoted 7 lines

As the option is already not enabled by default, further suggesting hesitant users to not enable it is not useful anyway. Unlike some other options where the description alone may not be sufficient for users to make a decision, NVME_HWMON is pretty simple to grasp in my opinion, so just let the user do what they want.

Added to nvme-5.7 with the reviewer's tags. Thanks!

_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme