4.19.104-stable review
Subsystems (2)
Greg Kroah-Hartman
maintainercover 4.19.104-stable review
This is the start of the stable review cycle for the 4.19.104 release. There are 52 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 15 Feb 2020 15:16:41 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.104-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 4.19.104-rc1
Peter Zijlstra <[email protected]>
x86/stackframe, x86/ftrace: Add pt_regs frame annotations
Peter Zijlstra <[email protected]>
x86/stackframe: Move ENCODE_FRAME_POINTER to asm/frame.h
Anand Lodnoor <[email protected]>
scsi: megaraid_sas: Do not initiate OCR if controller is not in ready state
Nicolai Stange <[email protected]>
libertas: make lbs_ibss_join_existing() return error code on rates overflow
Nicolai Stange <[email protected]>
libertas: don't exit from lbs_ibss_join_existing() with RCU read lock held
Qing Xu <[email protected]>
mwifiex: Fix possible buffer overflows in mwifiex_cmd_append_vsie_tlv()
Qing Xu <[email protected]>
mwifiex: Fix possible buffer overflows in mwifiex_ret_wmm_get_status()
Geert Uytterhoeven <[email protected]>
pinctrl: sh-pfc: r8a7778: Fix duplicate SDSELF_B and SD1_CLK_B
Gustavo A. R. Silva <[email protected]>
media: i2c: adv748x: Fix unsafe macros
Eric Biggers <[email protected]>
crypto: atmel-sha - fix error handling when setting hmac key
Eric Biggers <[email protected]>
crypto: artpec6 - return correct error code for failed setkey()
YueHaibing <[email protected]>
mtd: sharpslpart: Fix unsigned comparison to zero
Nathan Chancellor <[email protected]>
mtd: onenand_base: Adjust indentation in onenand_read_ops_nolock
Eric Auger <[email protected]>
KVM: arm64: pmu: Don't increment SW_INCR if PMCR.E is unset
James Morse <[email protected]>
KVM: arm: Make inject_abt32() inject an external abort instead
James Morse <[email protected]>
KVM: arm: Fix DFSR setting for non-LPAE aarch32 guests
Gavin Shan <[email protected]>
KVM: arm/arm64: Fix young bit from mmu notifier
Suzuki K Poulose <[email protected]>
arm64: ptrace: nofpsimd: Fail FP/SIMD regset operations
Suzuki K Poulose <[email protected]>
arm64: cpufeature: Fix the type of no FP/SIMD capability
Olof Johansson <[email protected]>
ARM: 8949/1: mm: mark free_memmap as __init
Eric Auger <[email protected]>
KVM: arm/arm64: vgic-its: Fix restoration of unmapped collections
Shameer Kolothum <[email protected]>
iommu/arm-smmu-v3: Populate VMID field for CMDQ_OP_TLBI_NH_VA
Alexey Kardashevskiy <[email protected]>
powerpc/pseries: Allow not having ibm, hypertas-functions::hcall-multi-tce for DDW
Tyrel Datwyler <[email protected]>
powerpc/pseries/vio: Fix iommu_table use-after-free refcount warning
Zhengyuan Liu <[email protected]>
tools/power/acpi: fix compilation error
Alexandre Belloni <[email protected]>
ARM: dts: at91: sama5d3: define clock rate range for tcb1
Alexandre Belloni <[email protected]>
ARM: dts: at91: sama5d3: fix maximum peripheral clock rates
Tero Kristo <[email protected]>
ARM: dts: am43xx: add support for clkout1 clock
Ingo van Lil <[email protected]>
ARM: dts: at91: Reenable UART TX pull-ups
Mika Westerberg <[email protected]>
platform/x86: intel_mid_powerbtn: Take a copy of ddata
Jose Abreu <[email protected]>
ARC: [plat-axs10x]: Add missing multicast filter number to GMAC node
Andy Shevchenko <[email protected]>
rtc: cmos: Stop using shared IRQ
Paul Kocialkowski <[email protected]>
rtc: hym8563: Return -EINVAL if the time is known to be invalid
Geert Uytterhoeven <[email protected]>
spi: spi-mem: Fix inverted logic in op sanity check
Boris Brezillon <[email protected]>
spi: spi-mem: Add extra sanity checks on the op param
Brandon Maier <[email protected]>
gpio: zynq: Report gpio direction at boot
Shubhrajyoti Datta <[email protected]>
serial: uartps: Add a timeout to the tx empty wait
Robert Milkowski <[email protected]>
NFSv4: try lease recovery on NFS4ERR_EXPIRED
Trond Myklebust <[email protected]>
NFS/pnfs: Fix pnfs_generic_prepare_to_resend_writes()
Trond Myklebust <[email protected]>
NFS: Revalidate the file size on a fatal write error
Geert Uytterhoeven <[email protected]>
nfs: NFS_SWAP should depend on SWAP
Logan Gunthorpe <[email protected]>
PCI: Don't disable bridge BARs when assigning bus resources
Logan Gunthorpe <[email protected]>
PCI/switchtec: Fix vep_vector_number ioread width
Bryan O'Donoghue <[email protected]>
ath10k: pci: Only dump ATH10K_MEM_REGION_TYPE_IOREG when safe
Navid Emamdoost <[email protected]>
PCI/IOV: Fix memory leak in pci_iov_add_virtfn()
Bean Huo <[email protected]>
scsi: ufs: Fix ufshcd_probe_hba() reture value in case ufshcd_scsi_add_wlus() fails
Michael Guralnik <[email protected]>
RDMA/uverbs: Verify MR access flags
Jason Gunthorpe <[email protected]>
RDMA/core: Fix locking in ib_uverbs_event_read
Håkon Bugge <[email protected]>
RDMA/netlink: Do not always generate an ACK for some netlink operations
Jack Morgenstein <[email protected]>
IB/mlx4: Fix memory leak in add_gid error flow
Sunil Muthuswamy <[email protected]>
hv_sock: Remove the accept port restriction
Ranjani Sridharan <[email protected]>
ASoC: pcm: update FE/BE trigger order based on the command
-------------
Diffstat:
Makefile | 4 +- arch/arc/boot/dts/axs10x_mb.dtsi | 1 + arch/arm/boot/dts/am43xx-clocks.dtsi | 54 ++++++++++++++++ arch/arm/boot/dts/at91sam9260.dtsi | 12 ++-- arch/arm/boot/dts/at91sam9261.dtsi | 6 +- arch/arm/boot/dts/at91sam9263.dtsi | 6 +- arch/arm/boot/dts/at91sam9g45.dtsi | 8 +-- arch/arm/boot/dts/at91sam9rl.dtsi | 8 +-- arch/arm/boot/dts/sama5d3.dtsi | 28 ++++----- arch/arm/boot/dts/sama5d3_can.dtsi | 4 +- arch/arm/boot/dts/sama5d3_tcb1.dtsi | 1 + arch/arm/boot/dts/sama5d3_uart.dtsi | 4 +- arch/arm/mm/init.c | 2 +- arch/arm64/kernel/cpufeature.c | 2 +- arch/arm64/kernel/ptrace.c | 21 +++++++ arch/powerpc/platforms/pseries/iommu.c | 43 ++++++++----- arch/powerpc/platforms/pseries/vio.c | 2 + arch/x86/entry/calling.h | 15 ----- arch/x86/entry/entry_32.S | 16 ----- arch/x86/include/asm/frame.h | 49 +++++++++++++++ arch/x86/kernel/ftrace_32.S | 3 + arch/x86/kernel/ftrace_64.S | 3 + drivers/crypto/atmel-sha.c | 7 +-- drivers/crypto/axis/artpec6_crypto.c | 2 +- drivers/gpio/gpio-zynq.c | 23 +++++++ drivers/infiniband/core/addr.c | 2 +- drivers/infiniband/core/sa_query.c | 4 +- drivers/infiniband/core/uverbs_main.c | 32 +++++----- drivers/infiniband/hw/mlx4/main.c | 20 ++++-- drivers/iommu/arm-smmu-v3.c | 1 + drivers/media/i2c/adv748x/adv748x.h | 8 +-- drivers/mtd/nand/onenand/onenand_base.c | 82 ++++++++++++------------- drivers/mtd/parsers/sharpslpart.c | 4 +- drivers/net/wireless/ath/ath10k/pci.c | 19 +++++- drivers/net/wireless/marvell/libertas/cfg.c | 2 + drivers/net/wireless/marvell/mwifiex/scan.c | 7 +++ drivers/net/wireless/marvell/mwifiex/wmm.c | 4 ++ drivers/pci/iov.c | 9 ++- drivers/pci/setup-bus.c | 20 ++++-- drivers/pci/switch/switchtec.c | 2 +- drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 4 +- drivers/platform/x86/intel_mid_powerbtn.c | 5 +- drivers/rtc/rtc-cmos.c | 2 +- drivers/rtc/rtc-hym8563.c | 2 +- drivers/scsi/megaraid/megaraid_sas_base.c | 3 +- drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 +- drivers/scsi/megaraid/megaraid_sas_fusion.h | 1 + drivers/scsi/ufs/ufshcd.c | 3 +- drivers/spi/spi-mem.c | 54 ++++++++++++++-- drivers/tty/serial/xilinx_uartps.c | 14 +++-- fs/nfs/Kconfig | 2 +- fs/nfs/direct.c | 4 +- fs/nfs/nfs3xdr.c | 5 +- fs/nfs/nfs4proc.c | 5 ++ fs/nfs/nfs4xdr.c | 5 +- fs/nfs/pnfs_nfs.c | 7 +-- fs/nfs/write.c | 12 +++- include/rdma/ib_verbs.h | 3 + net/vmw_vsock/hyperv_transport.c | 68 +++------------------ sound/soc/soc-pcm.c | 95 +++++++++++++++++++++-------- tools/power/acpi/Makefile.config | 2 +- virt/kvm/arm/aarch32.c | 14 +++-- virt/kvm/arm/mmu.c | 3 +- virt/kvm/arm/pmu.c | 3 + virt/kvm/arm/vgic/vgic-its.c | 3 +- 65 files changed, 562 insertions(+), 300 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 1/52 ASoC: pcm: update FE/BE trigger order based on the command
From: Ranjani Sridharan <[email protected]>
[ Upstream commit acbf27746ecfa96b290b54cc7f05273482ea128a ]
Currently, the trigger orders SND_SOC_DPCM_TRIGGER_PRE/POST determine the order in which FE DAI and BE DAI are triggered. In the case of SND_SOC_DPCM_TRIGGER_PRE, the FE DAI is triggered before the BE DAI and in the case of SND_SOC_DPCM_TRIGGER_POST, the BE DAI is triggered before the FE DAI. And this order remains the same irrespective of the trigger command.
In the case of the SOF driver, during playback, the FW expects the BE DAI to be triggered before the FE DAI during the START trigger. The BE DAI trigger handles the starting of Link DMA and so it must be started before the FE DAI is started to prevent xruns during pause/release. This can be addressed by setting the trigger order for the FE dai link to SND_SOC_DPCM_TRIGGER_POST. But during the STOP trigger, the FW expects the FE DAI to be triggered before the BE DAI. Retaining the same order during the START and STOP commands, results in FW error as the DAI component in the FW is still active.
The issue can be fixed by mirroring the trigger order of FE and BE DAI's during the START and STOP trigger. So, with the trigger order set to SND_SOC_DPCM_TRIGGER_PRE, the FE DAI will be trigger first during SNDRV_PCM_TRIGGER_START/STOP/RESUME and the BE DAI will be triggered first during the STOP/SUSPEND/PAUSE commands. Conversely, with the trigger order set to SND_SOC_DPCM_TRIGGER_POST, the BE DAI will be triggered first during the SNDRV_PCM_TRIGGER_START/STOP/RESUME commands and the FE DAI will be triggered first during the SNDRV_PCM_TRIGGER_STOP/SUSPEND/PAUSE commands.
--- sound/soc/soc-pcm.c | 95 ++++++++++++++++++++++++++++++++------------- 1 file changed, 68 insertions(+), 27 deletions(-)
sound/soc/soc-pcm.c +68 -27
@@ -2341,42 +2341,81 @@ int dpcm_be_dai_trigger(struct snd_soc_pcm_runtime *fe, int stream, }EXPORT_SYMBOL_GPL (dpcm_be_dai_trigger); +static int dpcm_dai_trigger_fe_be (struct snd_pcm_substream *substream, +int cmd,bool fe_first) +{ +struct snd_soc_pcm_runtime *fe = substream->private_data; +int ret; + +/* call trigger on the frontend before the backend. */ +if (fe_first) { +dev_dbg (fe->dev,"ASoC: pre trigger FE %s cmd %d\n" , + fe->dai_link->name, cmd); + + ret =soc_pcm_trigger (substream, cmd); +if (ret <0 ) +return ret; + + ret =dpcm_be_dai_trigger (fe, substream->stream, cmd); +return ret; + } + +/* call trigger on the frontend after the backend. */ + ret =dpcm_be_dai_trigger (fe, substream->stream, cmd); +if (ret <0 ) +return ret; + +dev_dbg (fe->dev,"ASoC: post trigger FE %s cmd %d\n" , + fe->dai_link->name, cmd); + + ret =soc_pcm_trigger (substream, cmd); + +return ret; +} +static int dpcm_fe_dai_do_trigger (struct snd_pcm_substream *substream,int cmd) {struct snd_soc_pcm_runtime *fe = substream->private_data; -int stream = substream->stream, ret; +int stream = substream->stream; +int ret =0 ;enum snd_soc_dpcm_trigger trigger = fe->dai_link->trigger[stream]; fe->dpcm[stream].runtime_update =SND_SOC_DPCM_UPDATE_FE ;switch (trigger) {case SND_SOC_DPCM_TRIGGER_PRE : -/* call trigger on the frontend before the backend. */ - -dev_dbg (fe->dev,"ASoC: pre trigger FE %s cmd %d\n" , - fe->dai_link->name, cmd); - - ret =soc_pcm_trigger (substream, cmd); -if (ret <0 ) { -dev_err (fe->dev,"ASoC: trigger FE failed %d\n" , ret); - goto out; +switch (cmd) { +case SNDRV_PCM_TRIGGER_START : +case SNDRV_PCM_TRIGGER_RESUME : +case SNDRV_PCM_TRIGGER_PAUSE_RELEASE : + ret =dpcm_dai_trigger_fe_be (substream, cmd, true); +break ; +case SNDRV_PCM_TRIGGER_STOP : +case SNDRV_PCM_TRIGGER_SUSPEND : +case SNDRV_PCM_TRIGGER_PAUSE_PUSH : + ret =dpcm_dai_trigger_fe_be (substream, cmd, false); +break ; +default : + ret = -EINVAL ; +break ; } - - ret =dpcm_be_dai_trigger (fe, substream->stream, cmd);break ;case SND_SOC_DPCM_TRIGGER_POST : -/* call trigger on the frontend after the backend. */ - - ret =dpcm_be_dai_trigger (fe, substream->stream, cmd); -if (ret <0 ) { -dev_err (fe->dev,"ASoC: trigger FE failed %d\n" , ret); - goto out; +switch (cmd) { +case SNDRV_PCM_TRIGGER_START : +case SNDRV_PCM_TRIGGER_RESUME : +case SNDRV_PCM_TRIGGER_PAUSE_RELEASE : + ret =dpcm_dai_trigger_fe_be (substream, cmd, false); +break ; +case SNDRV_PCM_TRIGGER_STOP : +case SNDRV_PCM_TRIGGER_SUSPEND : +case SNDRV_PCM_TRIGGER_PAUSE_PUSH : + ret =dpcm_dai_trigger_fe_be (substream, cmd, true); +break ; +default : + ret = -EINVAL ; +break ; } - -dev_dbg (fe->dev,"ASoC: post trigger FE %s cmd %d\n" , - fe->dai_link->name, cmd); - - ret =soc_pcm_trigger (substream, cmd);break ;case SND_SOC_DPCM_TRIGGER_BESPOKE :/* bespoke trigger() - handles both FE and BEs */
@@ -2385,10 +2424,6 @@ static int dpcm_fe_dai_do_trigger(struct snd_pcm_substream *substream, int cmd) fe->dai_link->name, cmd); ret =soc_pcm_bespoke_trigger (substream, cmd); -if (ret <0 ) { -dev_err (fe->dev,"ASoC: trigger FE failed %d\n" , ret); - goto out; - }break ;default : dev_err(fe->dev, "ASoC: invalid trigger cmd %d for %s\n", cmd,
@@ -2397,6 +2432,12 @@ static int dpcm_fe_dai_do_trigger(struct snd_pcm_substream *substream, int cmd) goto out; } +if (ret <0 ) { +dev_err (fe->dev,"ASoC: trigger FE cmd: %d failed: %d\n" , + cmd, ret); + goto out; + } +switch (cmd) {case SNDRV_PCM_TRIGGER_START :case SNDRV_PCM_TRIGGER_RESUME :
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 2/52 hv_sock: Remove the accept port restriction
In reply to Greg Kroah-HartmanFrom: Sunil Muthuswamy <[email protected]>
[ Upstream commit c742c59e1fbd022b64d91aa9a0092b3a699d653c ]
Currently, hv_sock restricts the port the guest socket can accept connections on. hv_sock divides the socket port namespace into two parts for server side (listening socket), 0-0x7FFFFFFF & 0x80000000-0xFFFFFFFF (there are no restrictions on client port namespace). The first part (0-0x7FFFFFFF) is reserved for sockets where connections can be accepted. The second part (0x80000000-0xFFFFFFFF) is reserved for allocating ports for the peer (host) socket, once a connection is accepted. This reservation of the port namespace is specific to hv_sock and not known by the generic vsock library (ex: af_vsock). This is problematic because auto-binds/ephemeral ports are handled by the generic vsock library and it has no knowledge of this port reservation and could allocate a port that is not compatible with hv_sock (and legitimately so). The issue hasn't surfaced so far because the auto-bind code of vsock (__vsock_bind_stream) prior to the change 'VSOCK: bind to random port for VMADDR_PORT_ANY' would start walking up from LAST_RESERVED_PORT (1023) and start assigning ports. That will take a large number of iterations to hit 0x7FFFFFFF. But, after the above change to randomize port selection, the issue has started coming up more frequently.
There has really been no good reason to have this port reservation logic in hv_sock from the get go. Reserving a local port for peer ports is not how things are handled generally. Peer ports should reflect the peer port. This fixes the issue by lifting the port reservation, and also returns the right peer port. Since the code converts the GUID to the peer port (by using the first 4 bytes), there is a possibility of conflicts, but that seems like a reasonable risk to take, given this is limited to vsock and that only applies to all local sockets.
--- net/vmw_vsock/hyperv_transport.c | 68 +++++--------------------------- 1 file changed, 9 insertions(+), 59 deletions(-)
net/vmw_vsock/hyperv_transport.c +9 -59
@@ -144,28 +144,15 @@ struct hvsock {**************************************************************************** * The only valid Service GUIDs, from the perspectives of both the host and * * Linux VM, that can be connected by the other end, must conform to this * -* format: <port>-facb-11e6-bd58-64006a7986d3, and the "port" must be in * -* this range [0, 0x7FFFFFFF]. * +* format: <port>-facb-11e6-bd58-64006a7986d3. * **************************************************************************** * * When we write apps on the host to connect(), the GUID ServiceID is used. * When we write apps in Linux VM to connect(), we only need to specify the * port and the driver will form the GUID and use that to request the host. * -* From the perspective of Linux VM: -* 1. the local ephemeral port (i.e. the local auto-bound port when we call -* connect() without explicit bind()) is generated by __vsock_bind_stream(), -* and the range is [1024, 0xFFFFFFFF). -* 2. the remote ephemeral port (i.e. the auto-generated remote port for -* a connect request initiated by the host's connect()) is generated by -* hvs_remote_addr_init() and the range is [0x80000000, 0xFFFFFFFF). */ -#define MAX_LISTEN_PORT ((u32)0x7FFFFFFF) -#define MAX_VM_LISTEN_PORT MAX_LISTEN_PORT -#define MAX_HOST_LISTEN_PORT MAX_LISTEN_PORT -#define MIN_HOST_EPHEMERAL_PORT (MAX_HOST_LISTEN_PORT + 1) -/* 00000000-facb-11e6-bd58-64006a7986d3 */ static const uuid_le srv_id_template = UUID_LE(0x00000000, 0xfacb, 0x11e6, 0xbd, 0x58,
@@ -188,33 +175,6 @@ static void hvs_addr_init(struct sockaddr_vm *addr, const uuid_le *svr_id)vsock_addr_init (addr,VMADDR_CID_ANY , port); } -static void hvs_remote_addr_init (struct sockaddr_vm *remote, -struct sockaddr_vm *local) -{ -static u32 host_ephemeral_port =MIN_HOST_EPHEMERAL_PORT ; -struct sock *sk; - -vsock_addr_init (remote,VMADDR_CID_ANY ,VMADDR_PORT_ANY ); - -while (1 ) { -/* Wrap around ? */ -if (host_ephemeral_port <MIN_HOST_EPHEMERAL_PORT || - host_ephemeral_port ==VMADDR_PORT_ANY ) - host_ephemeral_port =MIN_HOST_EPHEMERAL_PORT ; - - remote->svm_port = host_ephemeral_port++; - - sk =vsock_find_connected_socket (remote, local); -if (!sk) { -/* Found an available ephemeral port */ -return ; - } - -/* Release refcnt got in vsock_find_connected_socket */ -sock_put (sk); - } -} -static void hvs_set_channel_pending_send_size (struct vmbus_channel *chan) { set_channel_pending_send_size(chan,
@@ -342,12 +302,7 @@ static void hvs_open_connection(struct vmbus_channel *chan) if_type = &chan->offermsg.offer.if_type; if_instance = &chan->offermsg.offer.if_instance; conn_from_host = chan->offermsg.offer.u.pipe.user_def[0 ]; - -/* The host or the VM should only listen on a port in -* [0, MAX_LISTEN_PORT] -*/ -if (!is_valid_srv_id (if_type) || -get_port_by_srv_id (if_type) >MAX_LISTEN_PORT ) +if (!is_valid_srv_id (if_type))return ;hvs_addr_init (&addr, conn_from_host ? if_type : if_instance);
@@ -371,6 +326,13 @@ static void hvs_open_connection(struct vmbus_channel *chan) new->sk_state =TCP_SYN_SENT ; vnew =vsock_sk (new); + +hvs_addr_init (&vnew->local_addr, if_type); + +/* Remote peer is always the host */ +vsock_addr_init (&vnew->remote_addr, +VMADDR_CID_HOST ,VMADDR_PORT_ANY ); + vnew->remote_addr.svm_port =get_port_by_srv_id (if_instance); hvs_new = vnew->trans; hvs_new->chan = chan; }else {
@@ -410,8 +372,6 @@ static void hvs_open_connection(struct vmbus_channel *chan) sk->sk_ack_backlog++;hvs_addr_init (&vnew->local_addr, if_type); -hvs_remote_addr_init (&vnew->remote_addr, &vnew->local_addr); - hvs_new->vm_srv_id = *if_type; hvs_new->host_srv_id = *if_instance;
@@ -716,16 +676,6 @@ static bool hvs_stream_is_active(struct vsock_sock *vsk)static bool hvs_stream_allow (u32 cid,u32 port) { -/* The host's port range [MIN_HOST_EPHEMERAL_PORT, 0xFFFFFFFF) is -* reserved as ephemeral ports, which are used as the host's ports -* when the host initiates connections. -* -* Perform this check in the guest so an immediate error is produced -* instead of a timeout. -*/ -if (port >MAX_HOST_LISTEN_PORT ) -return false; -if (cid ==VMADDR_CID_HOST )return true;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 3/52 IB/mlx4: Fix memory leak in add_gid error flow
In reply to Greg Kroah-HartmanFrom: Jack Morgenstein <[email protected]>
commit eaad647e5cc27f7b46a27f3b85b14c4c8a64bffa upstream.
In procedure mlx4_ib_add_gid(), if the driver is unable to update the FW gid table, there is a memory leak in the driver's copy of the gid table:
the gid entry's context buffer is not freed.
If such an error occurs, free the entry's context buffer, and mark the entry as available (by setting its context pointer to NULL).
--- drivers/infiniband/hw/mlx4/main.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-)
drivers/infiniband/hw/mlx4/main.c +16 -4
@@ -246,6 +246,13 @@ static int mlx4_ib_update_gids(struct gireturn mlx4_ib_update_gids_v1 (gids, ibdev, port_num); } +static void free_gid_entry (struct gid_entry *entry) +{ +memset (&entry->gid,0 ,sizeof (entry->gid)); +kfree (entry->ctx); + entry->ctx =NULL ; +} +static int mlx4_ib_add_gid (const struct ib_gid_attr *attr,void **context) {struct mlx4_ib_dev *ibdev =to_mdev (attr->device);
@@ -306,6 +313,8 @@ static int mlx4_ib_add_gid(const struct GFP_ATOMIC);if (!gids) { ret = -ENOMEM ; + *context =NULL ; +free_gid_entry (&port_gid_table->gids[free]); }else {for (i =0 ; i <MLX4_MAX_PORT_GIDS ; i++) {memcpy (&gids[i].gid, &port_gid_table->gids[i].gid,sizeof (union ib_gid ));
@@ -317,6 +326,12 @@ static int mlx4_ib_add_gid(const structif (!ret && hw_update) { ret =mlx4_ib_update_gids (gids, ibdev, attr->port_num); +if (ret) { +spin_lock_bh (&iboe->lock); + *context =NULL ; +free_gid_entry (&port_gid_table->gids[free]); +spin_unlock_bh (&iboe->lock); + }kfree (gids); }
@@ -346,10 +361,7 @@ static int mlx4_ib_del_gid(const structif (!ctx->refcount) {unsigned int real_index = ctx->real_index; -memset (&port_gid_table->gids[real_index].gid,0 , -sizeof (port_gid_table->gids[real_index].gid)); -kfree (port_gid_table->gids[real_index].ctx); - port_gid_table->gids[real_index].ctx =NULL ; +free_gid_entry (&port_gid_table->gids[real_index]); hw_update =1 ; } }
Greg Kroah-Hartman
maintainerPATCH 4/52 RDMA/netlink: Do not always generate an ACK for some netlink operations
In reply to Greg Kroah-HartmanFrom: Håkon Bugge <[email protected]>
commit a242c36951ecd24bc16086940dbe6b522205c461 upstream.
In rdma_nl_rcv_skb(), the local variable err is assigned the return value of the supplied callback function, which could be one of ib_nl_handle_resolve_resp(), ib_nl_handle_set_timeout(), or ib_nl_handle_ip_res_resp(). These three functions all return skb->len on success.
rdma_nl_rcv_skb() is merely a copy of netlink_rcv_skb(). The callback functions used by the latter have the convention: "Returns 0 on success or a negative error code".
In particular, the statement (equal for both functions):
if (nlh->nlmsg_flags & NLM_F_ACK || err)
implies that rdma_nl_rcv_skb() always will ack a message, independent of the NLM_F_ACK being set in nlmsg_flags or not.
The fix could be to change the above statement, but it is better to keep the two *_rcv_skb() functions equal in this respect and instead change the three callback functions in the rdma subsystem to the correct convention.
--- drivers/infiniband/core/addr.c | 2 +- drivers/infiniband/core/sa_query.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/infiniband/core/addr.c +1 -1
@@ -136,7 +136,7 @@ int ib_nl_handle_ip_res_resp(struct sk_bif (ib_nl_is_good_ip_resp (nlh))ib_nl_process_good_ip_rsep (nlh); -return skb->len; +return 0 ; } static int ib_nl_ip_send_msg(struct rdma_dev_addr *dev_addr,
drivers/infiniband/core/sa_query.c +2 -2
@@ -1078,7 +1078,7 @@ int ib_nl_handle_set_timeout(struct sk_b } settimeout_out: -return skb->len; +return 0 ; }static inline int ib_nl_is_good_resolve_resp (const struct nlmsghdr *nlh)
@@ -1149,7 +1149,7 @@ int ib_nl_handle_resolve_resp(struct sk_ } resp_out: -return skb->len; +return 0 ; }static void free_sm_ah (struct kref *kref)
Greg Kroah-Hartman
maintainerPATCH 5/52 RDMA/core: Fix locking in ib_uverbs_event_read
In reply to Greg Kroah-HartmanFrom: Jason Gunthorpe <[email protected]>
commit 14e23bd6d22123f6f3b2747701fa6cd4c6d05873 upstream.
This should not be using ib_dev to test for disassociation, during disassociation is_closed is set under lock and the waitq is triggered.
Instead check is_closed and be sure to re-obtain the lock to test the value after the wait_event returns.
--- drivers/infiniband/core/uverbs_main.c | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-)
drivers/infiniband/core/uverbs_main.c +14 -18
@@ -273,7 +273,6 @@ void ib_uverbs_release_file(struct kref }static ssize_t ib_uverbs_event_read (struct ib_uverbs_event_queue *ev_queue, -struct ib_uverbs_file *uverbs_file,struct file *filp,char __user *buf,size_t count,loff_t *pos,size_t eventsz)
@@ -291,19 +290,16 @@ static ssize_t ib_uverbs_event_read(struif (wait_event_interruptible (ev_queue->poll_wait, (!list_empty (&ev_queue->event_list) || -/* The barriers built into wait_event_interruptible() -* and wake_up() guarentee this will see the null set -* without using RCU -*/ - !uverbs_file->device->ib_dev))) + ev_queue->is_closed)))return -ERESTARTSYS ; +spin_lock_irq (&ev_queue->lock); +/* If device was disassociated and no event exists set an error */ -if (list_empty (&ev_queue->event_list) && - !uverbs_file->device->ib_dev) +if (list_empty (&ev_queue->event_list) && ev_queue->is_closed) { +spin_unlock_irq (&ev_queue->lock);return -EIO ; - -spin_lock_irq (&ev_queue->lock); + } } event = list_entry(ev_queue->event_list.next, struct ib_uverbs_event, list);
@@ -338,8 +334,7 @@ static ssize_t ib_uverbs_async_event_rea {struct ib_uverbs_async_event_file *file = filp->private_data; -return ib_uverbs_event_read (&file->ev_queue, file->uverbs_file, filp, - buf, count, pos, +return ib_uverbs_event_read (&file->ev_queue, filp, buf, count, pos,sizeof (struct ib_uverbs_async_event_desc )); }
@@ -349,9 +344,8 @@ static ssize_t ib_uverbs_comp_event_readstruct ib_uverbs_completion_event_file *comp_ev_file = filp->private_data; -return ib_uverbs_event_read (&comp_ev_file->ev_queue, - comp_ev_file->uobj.ufile, filp, - buf, count, pos, +return ib_uverbs_event_read (&comp_ev_file->ev_queue, filp, buf, count, + pos,sizeof (struct ib_uverbs_comp_event_desc )); }
@@ -374,7 +368,9 @@ static __poll_t ib_uverbs_event_poll(strstatic __poll_t ib_uverbs_async_event_poll (struct file *filp,struct poll_table_struct *wait) { -return ib_uverbs_event_poll (filp->private_data, filp, wait); +struct ib_uverbs_async_event_file *file = filp->private_data; + +return ib_uverbs_event_poll (&file->ev_queue, filp, wait); } static __poll_t ib_uverbs_comp_event_poll(struct file *filp,
@@ -388,9 +384,9 @@ static __poll_t ib_uverbs_comp_event_polstatic int ib_uverbs_async_event_fasync (int fd,struct file *filp,int on) { -struct ib_uverbs_event_queue *ev_queue = filp->private_data; +struct ib_uverbs_async_event_file *file = filp->private_data; -return fasync_helper (fd, filp, on, &ev_queue->async_queue); +return fasync_helper (fd, filp, on, &file->ev_queue.async_queue); }static int ib_uverbs_comp_event_fasync (int fd,struct file *filp,int on)
Greg Kroah-Hartman
maintainerPATCH 6/52 RDMA/uverbs: Verify MR access flags
In reply to Greg Kroah-HartmanFrom: Michael Guralnik <[email protected]>
commit ca95c1411198c2d87217c19d44571052cdc94725 upstream.
Verify that MR access flags that are passed from user are all supported ones, otherwise an error is returned.
--- include/rdma/ib_verbs.h | 3 +++ 1 file changed, 3 insertions(+)
include/rdma/ib_verbs.h +3 -0
@@ -3864,6 +3864,9 @@ static inline int ib_check_mr_access(int !(flags & IB_ACCESS_LOCAL_WRITE))return -EINVAL ; +if (flags & ~IB_ACCESS_SUPPORTED ) +return -EINVAL ; +return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 7/52 scsi: ufs: Fix ufshcd_probe_hba() reture value in case ufshcd_scsi_add_wlus() fails
In reply to Greg Kroah-HartmanFrom: Bean Huo <[email protected]>
commit b9fc5320212efdfb4e08b825aaa007815fd11d16 upstream.
A non-zero error value likely being returned by ufshcd_scsi_add_wlus() in case of failure of adding the WLs, but ufshcd_probe_hba() doesn't use this value, and doesn't report this failure to upper caller. This patch is to fix this issue.
--- drivers/scsi/ufs/ufshcd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/scsi/ufs/ufshcd.c +2 -1
@@ -6685,7 +6685,8 @@ static int ufshcd_probe_hba(struct ufs_hufshcd_init_icc_levels (hba);/* Add required well known logical units to scsi mid layer */ -if (ufshcd_scsi_add_wlus (hba)) + ret =ufshcd_scsi_add_wlus (hba); +if (ret) goto out;/* Initialize devfreq after UFS device is detected */
Greg Kroah-Hartman
maintainerPATCH 8/52 PCI/IOV: Fix memory leak in pci_iov_add_virtfn()
In reply to Greg Kroah-HartmanFrom: Navid Emamdoost <[email protected]>
commit 8c386cc817878588195dde38e919aa6ba9409d58 upstream.
In the implementation of pci_iov_add_virtfn() the allocated virtfn is leaked if pci_setup_device() fails. The error handling is not calling pci_stop_and_remove_bus_device(). Change the goto label to failed2.
--- drivers/pci/iov.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/pci/iov.c +4 -5
@@ -188,10 +188,10 @@ int pci_iov_add_virtfn(struct pci_dev *dsprintf (buf,"virtfn%u" , id); rc =sysfs_create_link (&dev->dev.kobj, &virtfn->dev.kobj, buf);if (rc) - goto failed2; + goto failed1; rc =sysfs_create_link (&virtfn->dev.kobj, &dev->dev.kobj,"physfn" );if (rc) - goto failed3; + goto failed2;kobject_uevent (&virtfn->dev.kobj,KOBJ_CHANGE );
@@ -199,11 +199,10 @@ int pci_iov_add_virtfn(struct pci_dev *dreturn 0 ; -failed3: -sysfs_remove_link (&dev->dev.kobj, buf); failed2: -pci_stop_and_remove_bus_device (virtfn); +sysfs_remove_link (&dev->dev.kobj, buf); failed1: +pci_stop_and_remove_bus_device (virtfn);pci_dev_put (dev); failed0:virtfn_remove_bus (dev->bus, bus);
Greg Kroah-Hartman
maintainerPATCH 9/52 ath10k: pci: Only dump ATH10K_MEM_REGION_TYPE_IOREG when safe
In reply to Greg Kroah-HartmanFrom: Bryan O'Donoghue <[email protected]>
commit d239380196c4e27a26fa4bea73d2bf994c14ec2d upstream.
ath10k_pci_dump_memory_reg() will try to access memory of type ATH10K_MEM_REGION_TYPE_IOREG however, if a hardware restart is in progress this can crash a system.
Individual ioread32() time has been observed to jump from 15-20 ticks to > 80k ticks followed by a secure-watchdog bite and a system reset.
Work around this corner case by only issuing the read transaction when the driver state is ATH10K_STATE_ON.
Tested-on: QCA9988 PCI 10.4-3.9.0.2-00044
--- drivers/net/wireless/ath/ath10k/pci.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath10k/pci.c +17 -2
@@ -1613,11 +1613,22 @@ static int ath10k_pci_dump_memory_reg(st {struct ath10k_pci *ar_pci =ath10k_pci_priv (ar);u32 i; +int ret; + +mutex_lock (&ar->conf_mutex); +if (ar->state !=ATH10K_STATE_ON ) { +ath10k_warn (ar,"Skipping pci_dump_memory_reg invalid state\n" ); + ret = -EIO ; + goto done; + }for (i =0 ; i < region->len; i +=4 ) *(u32 *)(buf + i) =ioread32 (ar_pci->mem + region->start + i); -return region->len; + ret = region->len; +done: +mutex_unlock (&ar->conf_mutex); +return ret; }/* if an error happened returns < 0, otherwise the length */
@@ -1713,7 +1724,11 @@ static void ath10k_pci_dump_memory(struc count =ath10k_pci_dump_memory_sram (ar, current_region, buf);break ;case ATH10K_MEM_REGION_TYPE_IOREG : - count =ath10k_pci_dump_memory_reg (ar, current_region, buf); + ret =ath10k_pci_dump_memory_reg (ar, current_region, buf); +if (ret <0 ) +break ; + + count = ret;break ;default : ret =ath10k_pci_dump_memory_generic (ar, current_region, buf);
Greg Kroah-Hartman
maintainerPATCH 10/52 PCI/switchtec: Fix vep_vector_number ioread width
In reply to Greg Kroah-HartmanFrom: Logan Gunthorpe <[email protected]>
commit 9375646b4cf03aee81bc6c305aa18cc80b682796 upstream.
vep_vector_number is actually a 16 bit register which should be read with ioread16() instead of ioread32().
--- drivers/pci/switch/switchtec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/switch/switchtec.c +1 -1
@@ -1186,7 +1186,7 @@ static int switchtec_init_isr(struct swiif (nvecs <0 )return nvecs; - event_irq =ioread32 (&stdev->mmio_part_cfg->vep_vector_number); + event_irq =ioread16 (&stdev->mmio_part_cfg->vep_vector_number);if (event_irq <0 || event_irq >= nvecs)return -EFAULT ;
Greg Kroah-Hartman
maintainerPATCH 11/52 PCI: Dont disable bridge BARs when assigning bus resources
In reply to Greg Kroah-HartmanFrom: Logan Gunthorpe <[email protected]>
commit 9db8dc6d0785225c42a37be7b44d1b07b31b8957 upstream.
Some PCI bridges implement BARs in addition to bridge windows. For example, here's a PLX switch:
04:00.0 PCI bridge: PLX Technology, Inc. PEX 8724 24-Lane, 6-Port PCI
Express Gen 3 (8 GT/s) Switch, 19 x 19mm FCBGA (rev ca) (prog-if 00 [Normal decode])
Flags: bus master, fast devsel, latency 0, IRQ 30, NUMA node 0 Memory at 90a00000 (32-bit, non-prefetchable) [size=256K]
Bus: primary=04, secondary=05, subordinate=0a, sec-latency=0 I/O behind bridge: 00002000-00003fff
Memory behind bridge: 90000000-909fffff
Prefetchable memory behind bridge: 0000380000800000-0000380000bfffff
Previously, when the kernel assigned resource addresses (with the pci=realloc command line parameter, for example) it could clear the struct resource corresponding to the BAR. When this happened, lspci would report this BAR as "ignored":
Region 0: Memory at <ignored> (32-bit, non-prefetchable) [size=256K]
This is because the kernel reports a zero start address and zero flags in the corresponding sysfs resource file and in /proc/bus/pci/devices. Investigation with 'lspci -x', however, shows the BIOS-assigned address will still be programmed in the device's BAR registers.
It's clearly a bug that the kernel lost track of the BAR value, but in most cases, this still won't result in a visible issue because nothing uses the memory, so nothing is affected. However, when an IOMMU is in use, it will not reserve this space in the IOVA because the kernel no longer thinks the range is valid. (See dmar_init_reserved_ranges() for the Intel implementation of this.)
Without the proper reserved range, a DMA mapping may allocate an IOVA that matches a bridge BAR, which results in DMA accesses going to the BAR instead of the intended RAM.
The problem was in pci_assign_unassigned_root_bus_resources(). When any resource from a bridge device fails to get assigned, the code set the resource's flags to zero. This makes sense for bridge windows, as they will be re-enabled later, but for regular BARs, it makes the kernel permanently lose track of the fact that they decode address space.
Change pci_assign_unassigned_root_bus_resources() and pci_assign_unassigned_bridge_resources() so they only clear "res->flags" for bridge *windows*, not bridge BARs.
--- drivers/pci/setup-bus.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-)
drivers/pci/setup-bus.c +16 -4
@@ -1820,12 +1820,18 @@ again:/* restore size and flags */ list_for_each_entry (fail_res, &fail_head, list) {struct resource *res = fail_res->res; +int idx; res->start = fail_res->start; res->end = fail_res->end; res->flags = fail_res->flags; -if (fail_res->dev->subordinate) - res->flags =0 ; + +if (pci_is_bridge (fail_res->dev)) { + idx = res - &fail_res->dev->resource[0 ]; +if (idx >=PCI_BRIDGE_RESOURCES && + idx <=PCI_BRIDGE_RESOURCE_END ) + res->flags =0 ; + } }free_list (&fail_head);
@@ -2066,12 +2072,18 @@ again:/* restore size and flags */ list_for_each_entry (fail_res, &fail_head, list) {struct resource *res = fail_res->res; +int idx; res->start = fail_res->start; res->end = fail_res->end; res->flags = fail_res->flags; -if (fail_res->dev->subordinate) - res->flags =0 ; + +if (pci_is_bridge (fail_res->dev)) { + idx = res - &fail_res->dev->resource[0 ]; +if (idx >=PCI_BRIDGE_RESOURCES && + idx <=PCI_BRIDGE_RESOURCE_END ) + res->flags =0 ; + } }free_list (&fail_head);
Greg Kroah-Hartman
maintainerPATCH 12/52 nfs: NFS_SWAP should depend on SWAP
In reply to Greg Kroah-HartmanFrom: Geert Uytterhoeven <[email protected]>
commit 474c4f306eefbb21b67ebd1de802d005c7d7ecdc upstream.
If CONFIG_SWAP=n, it does not make much sense to offer the user the option to enable support for swapping over NFS, as that will still fail at run time:
# swapon /swap
swapon: /swap: swapon failed: Function not implementedFix this by adding a dependency on CONFIG_SWAP.
--- fs/nfs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/Kconfig +1 -1
@@ -89,7 +89,7 @@ config NFS_V4 config NFS_SWAP bool "Provide swap over NFS support" default n - depends on NFS_FS + depends on NFS_FS && SWAP select SUNRPC_SWAP help This option enables swapon to work on files located on NFS mounts.
Greg Kroah-Hartman
maintainerPATCH 13/52 NFS: Revalidate the file size on a fatal write error
In reply to Greg Kroah-HartmanFrom: Trond Myklebust <[email protected]>
commit 0df68ced55443243951d02cc497be31fadf28173 upstream.
If we suffer a fatal error upon writing a file, which causes us to need to revalidate the entire mapping, then we should also revalidate the file size.
--- fs/nfs/write.c | 8 ++++++++ 1 file changed, 8 insertions(+)
fs/nfs/write.c +8 -0
@@ -240,7 +240,15 @@ out:/* A writeback failed: mark the page as bad, and invalidate the page cache */ static void nfs_set_pageerror (struct address_space *mapping) { +struct inode *inode = mapping->host; +nfs_zap_mapping (mapping->host, mapping); +/* Force file size revalidation */ +spin_lock (&inode->i_lock); +NFS_I (inode)->cache_validity |=NFS_INO_REVAL_FORCED | +NFS_INO_REVAL_PAGECACHE | +NFS_INO_INVALID_SIZE ; +spin_unlock (&inode->i_lock); }/*
Greg Kroah-Hartman
maintainerPATCH 14/52 NFS/pnfs: Fix pnfs_generic_prepare_to_resend_writes()
In reply to Greg Kroah-HartmanFrom: Trond Myklebust <[email protected]>
commit 221203ce6406273cf00e5c6397257d986c003ee6 upstream.
Instead of making assumptions about the commit verifier contents, change the commit code to ensure we always check that the verifier was set by the XDR code.
--- fs/nfs/direct.c | 4 ++-- fs/nfs/nfs3xdr.c | 5 ++++- fs/nfs/nfs4xdr.c | 5 ++++- fs/nfs/pnfs_nfs.c | 7 +++---- fs/nfs/write.c | 4 +++- 5 files changed, 16 insertions(+), 9 deletions(-)
fs/nfs/direct.c +2 -2
@@ -261,10 +261,10 @@ static int nfs_direct_cmp_commit_data_ve data->ds_commit_index);/* verifier not set so always fail */ -if (verfp->committed <0 ) +if (verfp->committed <0 || data->res.verf->committed <=NFS_UNSTABLE )return 1 ; -return nfs_direct_cmp_verf (verfp, &data->verf); +return nfs_direct_cmp_verf (verfp, data->res.verf); }/**
fs/nfs/nfs3xdr.c +4 -1
@@ -2380,6 +2380,7 @@ static int nfs3_xdr_dec_commit3res(struc void *data) {struct nfs_commitres *result = data; +struct nfs_writeverf *verf = result->verf;enum nfs_stat status;int error;
@@ -2392,7 +2393,9 @@ static int nfs3_xdr_dec_commit3res(struc result->op_status = status;if (status !=NFS3_OK ) goto out_status; - error =decode_writeverf3 (xdr, &result->verf->verifier); + error =decode_writeverf3 (xdr, &verf->verifier); +if (!error) + verf->committed =NFS_FILE_SYNC ; out:return error; out_status:
fs/nfs/nfs4xdr.c +4 -1
@@ -4439,11 +4439,14 @@ static int decode_write_verifier(structstatic int decode_commit (struct xdr_stream *xdr,struct nfs_commitres *res) { +struct nfs_writeverf *verf = res->verf;int status; status =decode_op_hdr (xdr,OP_COMMIT );if (!status) - status =decode_write_verifier (xdr, &res->verf->verifier); + status =decode_write_verifier (xdr, &verf->verifier); +if (!status) + verf->committed =NFS_FILE_SYNC ;return status; }
fs/nfs/pnfs_nfs.c +3 -4
@@ -30,12 +30,11 @@ EXPORT_SYMBOL_GPL(pnfs_generic_rw_releas/* Fake up some data that will cause nfs_commit_release to retry the writes. */ void pnfs_generic_prepare_to_resend_writes (struct nfs_commit_data *data) { -struct nfs_page *first =nfs_list_entry (data->pages.next); +struct nfs_writeverf *verf = data->res.verf; data->task.tk_status =0 ; -memcpy (&data->verf.verifier, &first->wb_verf, -sizeof (data->verf.verifier)); - data->verf.verifier.data[0 ]++;/* ensure verifier mismatch */ +memset (&verf->verifier,0 ,sizeof (verf->verifier)); + verf->committed =NFS_UNSTABLE ; }EXPORT_SYMBOL_GPL (pnfs_generic_prepare_to_resend_writes);
fs/nfs/write.c +3 -1
@@ -1814,6 +1814,7 @@ static void nfs_commit_done(struct rpc_tstatic void nfs_commit_release_pages (struct nfs_commit_data *data) { +const struct nfs_writeverf *verf = data->res.verf;struct nfs_page *req;int status = data->task.tk_status;struct nfs_commit_info cinfo;
@@ -1840,7 +1841,8 @@ static void nfs_commit_release_pages(str/* Okay, COMMIT succeeded, apparently. Check the verifier * returned by the server against all stored verfs. */ -if (!nfs_write_verifier_cmp (&req->wb_verf, &data->verf.verifier)) { +if (verf->committed >NFS_UNSTABLE && + !nfs_write_verifier_cmp (&req->wb_verf, &verf->verifier)) {/* We have a match */ if (req->wb_page)nfs_inode_remove_request (req);
Greg Kroah-Hartman
maintainerPATCH 15/52 NFSv4: try lease recovery on NFS4ERR_EXPIRED
In reply to Greg Kroah-HartmanFrom: Robert Milkowski <[email protected]>
commit 924491f2e476f7234d722b24171a4daff61bbe13 upstream.
Currently, if an nfs server returns NFS4ERR_EXPIRED to open(), we return EIO to applications without even trying to recover.
--- fs/nfs/nfs4proc.c | 5 +++++ 1 file changed, 5 insertions(+)
fs/nfs/nfs4proc.c +5 -0
@@ -3089,6 +3089,11 @@ static struct nfs4_state *nfs4_do_open(s exception.retry =1 ;continue ; } +if (status == -NFS4ERR_EXPIRED ) { +nfs4_schedule_lease_recovery (server->nfs_client); + exception.retry =1 ; +continue ; + }if (status == -EAGAIN ) {/* We must have found a delegation */ exception.retry =1 ;
Greg Kroah-Hartman
maintainerPATCH 16/52 serial: uartps: Add a timeout to the tx empty wait
In reply to Greg Kroah-HartmanFrom: Shubhrajyoti Datta <[email protected]>
commit 277375b864e8147975b064b513f491e2a910e66a upstream
In case the cable is not connected then the target gets into an infinite wait for tx empty.
Add a timeout to the tx empty wait.
--- drivers/tty/serial/xilinx_uartps.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)
drivers/tty/serial/xilinx_uartps.c +10 -4
@@ -26,6 +26,7 @@#include <linux/of.h> #include <linux/module.h> #include <linux/pm_runtime.h> +#include <linux/iopoll.h> #define CDNS_UART_TTY_NAME "ttyPS"#define CDNS_UART_NAME "xuartps"
@@ -34,6 +35,7 @@#define CDNS_UART_NR_PORTS 2#define CDNS_UART_FIFO_SIZE 64/* FIFO size */ #define CDNS_UART_REGISTER_SPACE 0x1000 +#define TX_TIMEOUT 500000/* Rx Trigger level */ static int rx_trigger_level =56 ;
@@ -681,16 +683,20 @@ static void cdns_uart_set_termios(struct uart_port *port,unsigned int cval =0 ;unsigned int baud, minbaud, maxbaud;unsigned long flags; -unsigned int ctrl_reg, mode_reg; +unsigned int ctrl_reg, mode_reg, val; +int err;spin_lock_irqsave (&port->lock, flags);/* Wait for the transmit FIFO to empty before making changes */ if (!(readl (port->membase +CDNS_UART_CR ) &CDNS_UART_CR_TX_DIS )) { -while (!(readl (port->membase +CDNS_UART_SR ) & -CDNS_UART_SR_TXEMPTY )) { -cpu_relax (); + err =readl_poll_timeout (port->membase +CDNS_UART_SR , + val, (val &CDNS_UART_SR_TXEMPTY ), +1000 ,TX_TIMEOUT ); +if (err) { +dev_err (port->dev,"timed out waiting for tx empty" ); +return ; } }
Signature · 1 line
2.20.1
Re: [PATCH 4.19 16/52] serial: uartps: Add a timeout to the tx empty wait
Hi!
Quoted 5 lines
commit
277375b864e8147975b064b513f491e2a910e66aupstreamIn case the cable is not connected then the target gets into an infinite wait for tx empty.
Add a timeout to the tx empty wait.
Was this tested? Because it does not work...
Quoted 8 lines
Reported-by Jean-Francois Dagenais <[email protected]>Signed-off-by Shubhrajyoti Datta <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>Cc stable <[email protected]> # 4.19Signed-off-by Mathieu Poirier <[email protected]>Signed-off-by Sasha Levin <[email protected]>(quoted diff) +0
-0@@ -681,16 +683,20 @@ static void cdns_uart_set_termios(struct uart_port *port,
...
Quoted 9 lines
drivers/tty/serial/xilinx_uartps.c +1
-1+int err;spin_lock_irqsave (&port->lock, flags);/* Wait for the transmit FIFO to empty before making changes */ if (!(readl (port->membase +CDNS_UART_CR ) &CDNS_UART_CR_TX_DIS )) { - while (!(readl(port->membase + CDNS_UART_SR) &
drivers/tty/serial/xilinx_uartps.c static void cdns_uart_set_termios(struct uart_port *port, · line 701
Quoted 10 lines
drivers/tty/serial/xilinx_uartps.c +6
-2- CDNS_UART_SR_TXEMPTY)) { -cpu_relax (); + err =readl_poll_timeout (port->membase +CDNS_UART_SR , + val, (val &CDNS_UART_SR_TXEMPTY ), +1000 ,TX_TIMEOUT ); +if (err) { +dev_err (port->dev,"timed out waiting for tx empty" ); +return ; } }
It will return with lock held and interrupts disabled. Mainline takes spinlock later, so it does not have a problem.
Merging 107475685abfdee504bb0ef4824f15797f6d2d4d before this one should fix the problem.
Best regards,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Greg Kroah-Hartman
maintainerRe: [PATCH 4.19 16/52] serial: uartps: Add a timeout to the tx empty wait
Quoted 42 lines · Pavel Machek
Hi!
Quoted 5 lines
commit
277375b864e8147975b064b513f491e2a910e66aupstreamIn case the cable is not connected then the target gets into an infinite wait for tx empty.
Add a timeout to the tx empty wait.Was this tested? Because it does not work...
Quoted 8 lines
Reported-by Jean-Francois Dagenais <[email protected]>Signed-off-by Shubhrajyoti Datta <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>Cc stable <[email protected]> # 4.19Signed-off-by Mathieu Poirier <[email protected]>Signed-off-by Sasha Levin <[email protected]>(quoted diff) +0
-0@@ -681,16 +683,20 @@ static void cdns_uart_set_termios(struct uart_port *port,...
Quoted 9 lines
drivers/tty/serial/xilinx_uartps.c +1
-1+int err;spin_lock_irqsave (&port->lock, flags);/* Wait for the transmit FIFO to empty before making changes */ if (!(readl (port->membase +CDNS_UART_CR ) &CDNS_UART_CR_TX_DIS )) { - while (!(readl(port->membase + CDNS_UART_SR) &drivers/tty/serial/xilinx_uartps.c static void cdns_uart_set_termios(struct uart_port *port, · line 701
Quoted 10 lines
drivers/tty/serial/xilinx_uartps.c +6
-2- CDNS_UART_SR_TXEMPTY)) { -cpu_relax (); + err =readl_poll_timeout (port->membase +CDNS_UART_SR , + val, (val &CDNS_UART_SR_TXEMPTY ), +1000 ,TX_TIMEOUT ); +if (err) { +dev_err (port->dev,"timed out waiting for tx empty" ); +return ; } }It will return with lock held and interrupts disabled. Mainline takes spinlock later, so it does not have a problem.
Quoted 2 lines
Merging
107475685abfdee504bb0ef4824f15797f6d2d4dbefore this one should fix the problem.
Good catch, that's a mess. I'll go queue this up now.
greg k-h
Greg Kroah-Hartman
maintainerPATCH 17/52 gpio: zynq: Report gpio direction at boot
In reply to Greg Kroah-HartmanFrom: Brandon Maier <[email protected]>
commit 6169005ceb8c715582eca70df3912cd2b351ede2 upstream
The Zynq's gpios can be configured by the bootloader. But Linux will erroneously report all gpios as inputs unless we implement get_direction().
--- drivers/gpio/gpio-zynq.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)
drivers/gpio/gpio-zynq.c +23 -0
@@ -357,6 +357,28 @@ static int zynq_gpio_dir_out(struct gpio_chip *chip, unsigned int pin,return 0 ; } +/** +* zynq_gpio_get_direction - Read the direction of the specified GPIO pin +* @chip: gpio_chip instance to be worked on +* @pin: gpio pin number within the device +* +* This function returns the direction of the specified GPIO. +* +* Return: 0 for output, 1 for input +*/ +static int zynq_gpio_get_direction (struct gpio_chip *chip,unsigned int pin) +{ +u32 reg; +unsigned int bank_num, bank_pin_num; +struct zynq_gpio *gpio =gpiochip_get_data (chip); + +zynq_gpio_get_bank_pin (pin, &bank_num, &bank_pin_num, gpio); + + reg =readl_relaxed (gpio->base_addr +ZYNQ_GPIO_DIRM_OFFSET (bank_num)); + +return !(reg &BIT (bank_pin_num)); +} +/** * zynq_gpio_irq_mask - Disable the interrupts for a gpio pin * @irq_data: per irq and chip data passed down to chip functions
@@ -829,6 +851,7 @@ static int zynq_gpio_probe(struct platform_device *pdev) chip->free = zynq_gpio_free; chip->direction_input = zynq_gpio_dir_in; chip->direction_output = zynq_gpio_dir_out; + chip->get_direction = zynq_gpio_get_direction; chip->base =of_alias_get_id (pdev->dev.of_node,"gpio" ); chip->ngpio = gpio->p_data->ngpio;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 18/52 spi: spi-mem: Add extra sanity checks on the op param
In reply to Greg Kroah-HartmanFrom: Boris Brezillon <[email protected]>
commit 380583227c0c7f52383b0cd5c0e2de93ed31d553 upstream
Some combinations are simply not valid and should be rejected before the op is passed to the SPI controller driver.
Add an spi_mem_check_op() helper and use it in spi_mem_exec_op() and spi_mem_supports_op() to make sure the spi-mem operation is valid.
--- drivers/spi/spi-mem.c | 54 ++++++++++++++++++++++++++++++++++++++----- 1 file changed, 48 insertions(+), 6 deletions(-)
drivers/spi/spi-mem.c +48 -6
@@ -12,6 +12,8 @@#include "internals.h" +#define SPI_MEM_MAX_BUSWIDTH 4 +/** * spi_controller_dma_map_mem_op_data() - DMA-map the buffer attached to a * memory operation
@@ -149,6 +151,44 @@ static bool spi_mem_default_supports_op(struct spi_mem *mem, }EXPORT_SYMBOL_GPL (spi_mem_default_supports_op); +static bool spi_mem_buswidth_is_valid (u8 buswidth) +{ +if (hweight8 (buswidth) >1 || buswidth >SPI_MEM_MAX_BUSWIDTH ) +return false; + +return true; +} + +static int spi_mem_check_op (const struct spi_mem_op *op) +{ +if (!op->cmd.buswidth) +return -EINVAL ; + +if ((op->addr.nbytes && !op->addr.buswidth) || + (op->dummy.nbytes && !op->dummy.buswidth) || + (op->data.nbytes && !op->data.buswidth)) +return -EINVAL ; + +if (spi_mem_buswidth_is_valid (op->cmd.buswidth) || +spi_mem_buswidth_is_valid (op->addr.buswidth) || +spi_mem_buswidth_is_valid (op->dummy.buswidth) || +spi_mem_buswidth_is_valid (op->data.buswidth)) +return -EINVAL ; + +return 0 ; +} + +static bool spi_mem_internal_supports_op (struct spi_mem *mem, +const struct spi_mem_op *op) +{ +struct spi_controller *ctlr = mem->spi->controller; + +if (ctlr->mem_ops && ctlr->mem_ops->supports_op) +return ctlr->mem_ops->supports_op (mem, op); + +return spi_mem_default_supports_op (mem, op); +} +/** * spi_mem_supports_op() - Check if a memory device and the controller it is * connected to support a specific memory operation
@@ -166,12 +206,10 @@ EXPORT_SYMBOL_GPL(spi_mem_default_supports_op);*/ bool spi_mem_supports_op (struct spi_mem *mem,const struct spi_mem_op *op) { -struct spi_controller *ctlr = mem->spi->controller; - -if (ctlr->mem_ops && ctlr->mem_ops->supports_op) -return ctlr->mem_ops->supports_op (mem, op); +if (spi_mem_check_op (op)) +return false; -return spi_mem_default_supports_op (mem, op); +return spi_mem_internal_supports_op (mem, op); }EXPORT_SYMBOL_GPL (spi_mem_supports_op);
@@ -196,7 +234,11 @@ int spi_mem_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)u8 *tmpbuf;int ret; -if (!spi_mem_supports_op (mem, op)) + ret =spi_mem_check_op (op); +if (ret) +return ret; + +if (!spi_mem_internal_supports_op (mem, op))return -ENOTSUPP ;if (ctlr->mem_ops) {
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 19/52 spi: spi-mem: Fix inverted logic in op sanity check
In reply to Greg Kroah-HartmanFrom: Geert Uytterhoeven <[email protected]>
[ Upstream commit aea3877e24f3acc6145094848dbb85f9ce85674a ]
On r8a7791/koelsch:
m25p80 spi0.0: error -22 reading 9f
m25p80: probe of spi0.0 failed with error -22
Apparently the logic in spi_mem_check_op() is wrong, rejecting the spi-mem operation if any buswidth is valid, instead of invalid.
--- drivers/spi/spi-mem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/spi/spi-mem.c +4 -4
@@ -169,10 +169,10 @@ static int spi_mem_check_op(const struct spi_mem_op *op) (op->data.nbytes && !op->data.buswidth))return -EINVAL ; -if (spi_mem_buswidth_is_valid (op->cmd.buswidth) || -spi_mem_buswidth_is_valid (op->addr.buswidth) || -spi_mem_buswidth_is_valid (op->dummy.buswidth) || -spi_mem_buswidth_is_valid (op->data.buswidth)) +if (!spi_mem_buswidth_is_valid (op->cmd.buswidth) || + !spi_mem_buswidth_is_valid (op->addr.buswidth) || + !spi_mem_buswidth_is_valid (op->dummy.buswidth) || + !spi_mem_buswidth_is_valid (op->data.buswidth))return -EINVAL ;return 0 ;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 20/52 rtc: hym8563: Return -EINVAL if the time is known to be invalid
In reply to Greg Kroah-HartmanFrom: Paul Kocialkowski <[email protected]>
commit f236a2a2ebabad0848ad0995af7ad1dc7029e895 upstream.
The current code returns -EPERM when the voltage loss bit is set. Since the bit indicates that the time value is not valid, return -EINVAL instead, which is the appropriate error code for this situation.
--- drivers/rtc/rtc-hym8563.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-hym8563.c +1 -1
@@ -105,7 +105,7 @@ static int hym8563_rtc_read_time(structif (!hym8563->valid) {dev_warn (&client->dev,"no valid clock/calendar values available\n" ); -return -EPERM ; +return -EINVAL ; } ret =i2c_smbus_read_i2c_block_data (client,HYM8563_SEC ,7 , buf);
Greg Kroah-Hartman
maintainerPATCH 21/52 rtc: cmos: Stop using shared IRQ
In reply to Greg Kroah-HartmanFrom: Andy Shevchenko <[email protected]>
commit b6da197a2e9670df6f07e6698629e9ce95ab614e upstream.
As reported by Guilherme G. Piccoli:
---8<---8<---8<---
The rtc-cmos interrupt setting was changed in the commit 079062b28fb4 ("rtc: cmos: prevent kernel warning on IRQ flags mismatch") in order to allow shared interrupts; according to that commit's description, some machine got kernel warnings due to the interrupt line being shared between rtc-cmos and other hardware, and rtc-cmos didn't allow IRQ sharing that time.
After the aforementioned commit though it was observed a huge increase in lost HPET interrupts in some systems, observed through the following kernel message:
[...] hpet1: lost 35 rtc interrupts
After investigation, it was narrowed down to the shared interrupts usage when having the kernel option "irqpoll" enabled. In this case, all IRQ handlers are called for non-timer interrupts, if such handlers are setup in shared IRQ lines. The rtc-cmos IRQ handler could be set to hpet_rtc_interrupt(), which will produce the kernel "lost interrupts" message after doing work - lots of readl/writel to HPET registers, which are known to be slow.
Although "irqpoll" is not a default kernel option, it's used in some contexts, one being the kdump kernel (which is an already "impaired" kernel usually running with 1 CPU available), so the performance burden could be considerable. Also, the same issue would happen (in a shorter extent though) when using "irqfixup" kernel option.
In a quick experiment, a virtual machine with uptime of 2 minutes produced
Quoted 1 line
300 calls to
hpet_rtc_interrupt()when "irqpoll" was set, whereas without
sharing interrupts this number reduced to 1 interrupt. Machines with more hardware than a VM should generate even more unnecessary HPET interrupts in this scenario.
---8<---8<---8<---
After looking into the rtc-cmos driver history and DSDT table from the Microsoft Surface 3, we may notice that Hans de Goede submitted a correct fix (see dependency below). Thus, we simply revert the culprit commit.
Depends-on: a1e23a42f1bd ("rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs")
--- drivers/rtc/rtc-cmos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-cmos.c +1 -1
@@ -854,7 +854,7 @@ cmos_do_probe(struct device *dev, struct rtc_cmos_int_handler = cmos_interrupt; retval =request_irq (rtc_irq, rtc_cmos_int_handler, -IRQF_SHARED ,dev_name (&cmos_rtc.rtc->dev), +0 ,dev_name (&cmos_rtc.rtc->dev), cmos_rtc.rtc);if (retval <0 ) {dev_dbg (dev,"IRQ %d is already in use\n" , rtc_irq);
Greg Kroah-Hartman
maintainerPATCH 22/52 ARC: [plat-axs10x]: Add missing multicast filter number to GMAC node
In reply to Greg Kroah-HartmanFrom: Jose Abreu <[email protected]>
commit 7980dff398f86a618f502378fa27cf7e77449afa upstream.
Add a missing property to GMAC node so that multicast filtering works correctly.
--- arch/arc/boot/dts/axs10x_mb.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arc/boot/dts/axs10x_mb.dtsi +1 -0
@@ -80,6 +80,7 @@ interrupt-names = "macirq"; phy-mode = "rgmii"; snps,pbl = < 32 >; + snps,multicast-filter-bins = <256>; clocks = <&apbclk>; clock-names = "stmmaceth"; max-speed = <100>;
Greg Kroah-Hartman
maintainerPATCH 23/52 platform/x86: intel_mid_powerbtn: Take a copy of ddata
In reply to Greg Kroah-HartmanFrom: Mika Westerberg <[email protected]>
commit 5e0c94d3aeeecc68c573033f08d9678fecf253bd upstream.
The driver gets driver_data from memory that is marked as const (which is probably put to read-only memory) and it then modifies it. This likely causes some sort of fault to happen.
Fix this by taking a copy of the structure.
--- drivers/platform/x86/intel_mid_powerbtn.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/platform/x86/intel_mid_powerbtn.c +3 -2
@@ -158,9 +158,10 @@ static int mid_pb_probe(struct platform_input_set_capability (input,EV_KEY ,KEY_POWER ); - ddata = (struct mid_pb_ddata *)id->driver_data; + ddata =devm_kmemdup (&pdev->dev, (void *)id->driver_data, +sizeof (*ddata),GFP_KERNEL );if (!ddata) -return -ENODATA ; +return -ENOMEM ; ddata->dev = &pdev->dev; ddata->irq = irq;
Greg Kroah-Hartman
maintainerPATCH 24/52 ARM: dts: at91: Reenable UART TX pull-ups
In reply to Greg Kroah-HartmanFrom: Ingo van Lil <[email protected]>
commit 9d39d86cd4af2b17b970d63307daad71f563d207 upstream.
Pull-ups for SAM9 UART/USART TX lines were disabled in a previous commit. However, several chips in the SAM9 family require pull-ups to prevent the TX lines from falling (and causing an endless break condition) when the transceiver is disabled.
Quoted 1 line
From the SAM9G20 datasheet, 32.5.1: "To prevent the TXD line from
falling when the USART is disabled, the use of an internal pull up is mandatory.". This commit reenables the pull-ups for all chips having that sentence in their datasheets.
--- arch/arm/boot/dts/at91sam9260.dtsi | 12 ++++++------ arch/arm/boot/dts/at91sam9261.dtsi | 6 +++--- arch/arm/boot/dts/at91sam9263.dtsi | 6 +++--- arch/arm/boot/dts/at91sam9g45.dtsi | 8 ++++---- arch/arm/boot/dts/at91sam9rl.dtsi | 8 ++++---- 5 files changed, 20 insertions(+), 20 deletions(-)
arch/arm/boot/dts/at91sam9260.dtsi +6 -6
@@ -434,7 +434,7 @@ usart0 { pinctrl_usart0: usart0-0 { atmel,pins = - <AT91_PIOB 4 AT91_PERIPH_A AT91_PINCTRL_NONE + <AT91_PIOB 4 AT91_PERIPH_A AT91_PINCTRL_PULL_UP AT91_PIOB 5 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
@@ -468,7 +468,7 @@ usart1 { pinctrl_usart1: usart1-0 { atmel,pins = - <AT91_PIOB 6 AT91_PERIPH_A AT91_PINCTRL_NONE + <AT91_PIOB 6 AT91_PERIPH_A AT91_PINCTRL_PULL_UP AT91_PIOB 7 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
@@ -486,7 +486,7 @@ usart2 { pinctrl_usart2: usart2-0 { atmel,pins = - <AT91_PIOB 8 AT91_PERIPH_A AT91_PINCTRL_NONE + <AT91_PIOB 8 AT91_PERIPH_A AT91_PINCTRL_PULL_UP AT91_PIOB 9 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
@@ -504,7 +504,7 @@ usart3 { pinctrl_usart3: usart3-0 { atmel,pins = - <AT91_PIOB 10 AT91_PERIPH_A AT91_PINCTRL_NONE + <AT91_PIOB 10 AT91_PERIPH_A AT91_PINCTRL_PULL_UP AT91_PIOB 11 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
@@ -522,7 +522,7 @@ uart0 { pinctrl_uart0: uart0-0 { atmel,pins = - <AT91_PIOA 31 AT91_PERIPH_B AT91_PINCTRL_NONE + <AT91_PIOA 31 AT91_PERIPH_B AT91_PINCTRL_PULL_UP AT91_PIOA 30 AT91_PERIPH_B AT91_PINCTRL_PULL_UP>; }; };
@@ -530,7 +530,7 @@ uart1 { pinctrl_uart1: uart1-0 { atmel,pins = - <AT91_PIOB 12 AT91_PERIPH_A AT91_PINCTRL_NONE + <AT91_PIOB 12 AT91_PERIPH_A AT91_PINCTRL_PULL_UP AT91_PIOB 13 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; }; };
arch/arm/boot/dts/at91sam9261.dtsi +3 -3
@@ -328,7 +328,7 @@ usart0 { pinctrl_usart0: usart0-0 { atmel,pins = - <AT91_PIOC 8 AT91_PERIPH_A AT91_PINCTRL_NONE>, + <AT91_PIOC 8 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>, <AT91_PIOC 9 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
@@ -346,7 +346,7 @@ usart1 { pinctrl_usart1: usart1-0 { atmel,pins = - <AT91_PIOC 12 AT91_PERIPH_A AT91_PINCTRL_NONE>, + <AT91_PIOC 12 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>, <AT91_PIOC 13 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
@@ -364,7 +364,7 @@ usart2 { pinctrl_usart2: usart2-0 { atmel,pins = - <AT91_PIOC 14 AT91_PERIPH_A AT91_PINCTRL_NONE>, + <AT91_PIOC 14 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>, <AT91_PIOC 15 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
arch/arm/boot/dts/at91sam9263.dtsi +3 -3
@@ -437,7 +437,7 @@ usart0 { pinctrl_usart0: usart0-0 { atmel,pins = - <AT91_PIOA 26 AT91_PERIPH_A AT91_PINCTRL_NONE + <AT91_PIOA 26 AT91_PERIPH_A AT91_PINCTRL_PULL_UP AT91_PIOA 27 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
@@ -455,7 +455,7 @@ usart1 { pinctrl_usart1: usart1-0 { atmel,pins = - <AT91_PIOD 0 AT91_PERIPH_A AT91_PINCTRL_NONE + <AT91_PIOD 0 AT91_PERIPH_A AT91_PINCTRL_PULL_UP AT91_PIOD 1 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
@@ -473,7 +473,7 @@ usart2 { pinctrl_usart2: usart2-0 { atmel,pins = - <AT91_PIOD 2 AT91_PERIPH_A AT91_PINCTRL_NONE + <AT91_PIOD 2 AT91_PERIPH_A AT91_PINCTRL_PULL_UP AT91_PIOD 3 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
arch/arm/boot/dts/at91sam9g45.dtsi +4 -4
@@ -555,7 +555,7 @@ usart0 { pinctrl_usart0: usart0-0 { atmel,pins = - <AT91_PIOB 19 AT91_PERIPH_A AT91_PINCTRL_NONE + <AT91_PIOB 19 AT91_PERIPH_A AT91_PINCTRL_PULL_UP AT91_PIOB 18 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
@@ -573,7 +573,7 @@ usart1 { pinctrl_usart1: usart1-0 { atmel,pins = - <AT91_PIOB 4 AT91_PERIPH_A AT91_PINCTRL_NONE + <AT91_PIOB 4 AT91_PERIPH_A AT91_PINCTRL_PULL_UP AT91_PIOB 5 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
@@ -591,7 +591,7 @@ usart2 { pinctrl_usart2: usart2-0 { atmel,pins = - <AT91_PIOB 6 AT91_PERIPH_A AT91_PINCTRL_NONE + <AT91_PIOB 6 AT91_PERIPH_A AT91_PINCTRL_PULL_UP AT91_PIOB 7 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
@@ -609,7 +609,7 @@ usart3 { pinctrl_usart3: usart3-0 { atmel,pins = - <AT91_PIOB 8 AT91_PERIPH_A AT91_PINCTRL_NONE + <AT91_PIOB 8 AT91_PERIPH_A AT91_PINCTRL_PULL_UP AT91_PIOB 9 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
arch/arm/boot/dts/at91sam9rl.dtsi +4 -4
@@ -681,7 +681,7 @@ usart0 { pinctrl_usart0: usart0-0 { atmel,pins = - <AT91_PIOA 6 AT91_PERIPH_A AT91_PINCTRL_NONE>, + <AT91_PIOA 6 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>, <AT91_PIOA 7 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
@@ -720,7 +720,7 @@ usart1 { pinctrl_usart1: usart1-0 { atmel,pins = - <AT91_PIOA 11 AT91_PERIPH_A AT91_PINCTRL_NONE>, + <AT91_PIOA 11 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>, <AT91_PIOA 12 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
@@ -743,7 +743,7 @@ usart2 { pinctrl_usart2: usart2-0 { atmel,pins = - <AT91_PIOA 13 AT91_PERIPH_A AT91_PINCTRL_NONE>, + <AT91_PIOA 13 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>, <AT91_PIOA 14 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
@@ -766,7 +766,7 @@ usart3 { pinctrl_usart3: usart3-0 { atmel,pins = - <AT91_PIOB 0 AT91_PERIPH_A AT91_PINCTRL_NONE>, + <AT91_PIOB 0 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>, <AT91_PIOB 1 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; };
Greg Kroah-Hartman
maintainerPATCH 25/52 ARM: dts: am43xx: add support for clkout1 clock
In reply to Greg Kroah-HartmanFrom: Tero Kristo <[email protected]>
commit 01053dadb79d63b65f7b353e68b4b6ccf4effedb upstream.
clkout1 clock node and its generation tree was missing. Add this based on the data on TRM and PRCM functional spec.
commit 664ae1ab2536 ("ARM: dts: am43xx: add clkctrl nodes") effectively reverted this commit 8010f13a40d3 ("ARM: dts: am43xx: add support for clkout1 clock") which is needed for the ov2659 camera sensor clock definition hence it is being re-applied here.
Note that because of the current dts node name dependency for mapping to clock domain, we must still use "clkout1-*ck" naming instead of generic "clock@" naming for the node. And because of this, it's probably best to apply the dts node addition together along with the other clock changes.
--- arch/arm/boot/dts/am43xx-clocks.dtsi | 54 +++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)
arch/arm/boot/dts/am43xx-clocks.dtsi +54 -0
@@ -707,6 +707,60 @@ ti,bit-shift = <8>; reg = <0x2a48>; }; + + clkout1_osc_div_ck: clkout1-osc-div-ck { + #clock-cells = <0>; + compatible = "ti,divider-clock"; + clocks = <&sys_clkin_ck>; + ti,bit-shift = <20>; + ti,max-div = <4>; + reg = <0x4100>; + }; + + clkout1_src2_mux_ck: clkout1-src2-mux-ck { + #clock-cells = <0>; + compatible = "ti,mux-clock"; + clocks = <&clk_rc32k_ck>, <&sysclk_div>, <&dpll_ddr_m2_ck>, + <&dpll_per_m2_ck>, <&dpll_disp_m2_ck>, + <&dpll_mpu_m2_ck>; + reg = <0x4100>; + }; + + clkout1_src2_pre_div_ck: clkout1-src2-pre-div-ck { + #clock-cells = <0>; + compatible = "ti,divider-clock"; + clocks = <&clkout1_src2_mux_ck>; + ti,bit-shift = <4>; + ti,max-div = <8>; + reg = <0x4100>; + }; + + clkout1_src2_post_div_ck: clkout1-src2-post-div-ck { + #clock-cells = <0>; + compatible = "ti,divider-clock"; + clocks = <&clkout1_src2_pre_div_ck>; + ti,bit-shift = <8>; + ti,max-div = <32>; + ti,index-power-of-two; + reg = <0x4100>; + }; + + clkout1_mux_ck: clkout1-mux-ck { + #clock-cells = <0>; + compatible = "ti,mux-clock"; + clocks = <&clkout1_osc_div_ck>, <&clk_rc32k_ck>, + <&clkout1_src2_post_div_ck>, <&dpll_extdev_m2_ck>; + ti,bit-shift = <16>; + reg = <0x4100>; + }; + + clkout1_ck: clkout1-ck { + #clock-cells = <0>; + compatible = "ti,gate-clock"; + clocks = <&clkout1_mux_ck>; + ti,bit-shift = <23>; + reg = <0x4100>; + }; }; &prcm {
Greg Kroah-Hartman
maintainerPATCH 26/52 ARM: dts: at91: sama5d3: fix maximum peripheral clock rates
In reply to Greg Kroah-HartmanFrom: Alexandre Belloni <[email protected]>
commit ee0aa926ddb0bd8ba59e33e3803b3b5804e3f5da upstream.
Currently the maximum rate for peripheral clock is calculated based on a typical 133MHz MCK. The maximum frequency is defined in the datasheet as a ratio to MCK. Some sama5d3 platforms are using a 166MHz MCK. Update the device trees to match the maximum rate based on 166MHz.
--- arch/arm/boot/dts/sama5d3.dtsi | 28 ++++++++++++++-------------- arch/arm/boot/dts/sama5d3_can.dtsi | 4 ++-- arch/arm/boot/dts/sama5d3_uart.dtsi | 4 ++-- 3 files changed, 18 insertions(+), 18 deletions(-)
arch/arm/boot/dts/sama5d3.dtsi +14 -14
@@ -1187,49 +1187,49 @@ usart0_clk: usart0_clk { #clock-cells = <0>; reg = <12>; - atmel,clk-output-range = <0 66000000>; + atmel,clk-output-range = <0 83000000>; }; usart1_clk: usart1_clk { #clock-cells = <0>; reg = <13>; - atmel,clk-output-range = <0 66000000>; + atmel,clk-output-range = <0 83000000>; }; usart2_clk: usart2_clk { #clock-cells = <0>; reg = <14>; - atmel,clk-output-range = <0 66000000>; + atmel,clk-output-range = <0 83000000>; }; usart3_clk: usart3_clk { #clock-cells = <0>; reg = <15>; - atmel,clk-output-range = <0 66000000>; + atmel,clk-output-range = <0 83000000>; }; uart0_clk: uart0_clk { #clock-cells = <0>; reg = <16>; - atmel,clk-output-range = <0 66000000>; + atmel,clk-output-range = <0 83000000>; }; twi0_clk: twi0_clk { reg = <18>; #clock-cells = <0>; - atmel,clk-output-range = <0 16625000>; + atmel,clk-output-range = <0 41500000>; }; twi1_clk: twi1_clk { #clock-cells = <0>; reg = <19>; - atmel,clk-output-range = <0 16625000>; + atmel,clk-output-range = <0 41500000>; }; twi2_clk: twi2_clk { #clock-cells = <0>; reg = <20>; - atmel,clk-output-range = <0 16625000>; + atmel,clk-output-range = <0 41500000>; }; mci0_clk: mci0_clk {
@@ -1245,19 +1245,19 @@ spi0_clk: spi0_clk { #clock-cells = <0>; reg = <24>; - atmel,clk-output-range = <0 133000000>; + atmel,clk-output-range = <0 166000000>; }; spi1_clk: spi1_clk { #clock-cells = <0>; reg = <25>; - atmel,clk-output-range = <0 133000000>; + atmel,clk-output-range = <0 166000000>; }; tcb0_clk: tcb0_clk { #clock-cells = <0>; reg = <26>; - atmel,clk-output-range = <0 133000000>; + atmel,clk-output-range = <0 166000000>; }; pwm_clk: pwm_clk {
@@ -1268,7 +1268,7 @@ adc_clk: adc_clk { #clock-cells = <0>; reg = <29>; - atmel,clk-output-range = <0 66000000>; + atmel,clk-output-range = <0 83000000>; }; dma0_clk: dma0_clk {
@@ -1299,13 +1299,13 @@ ssc0_clk: ssc0_clk { #clock-cells = <0>; reg = <38>; - atmel,clk-output-range = <0 66000000>; + atmel,clk-output-range = <0 83000000>; }; ssc1_clk: ssc1_clk { #clock-cells = <0>; reg = <39>; - atmel,clk-output-range = <0 66000000>; + atmel,clk-output-range = <0 83000000>; }; sha_clk: sha_clk {
arch/arm/boot/dts/sama5d3_can.dtsi +2 -2
@@ -37,13 +37,13 @@ can0_clk: can0_clk { #clock-cells = <0>; reg = <40>; - atmel,clk-output-range = <0 66000000>; + atmel,clk-output-range = <0 83000000>; }; can1_clk: can1_clk { #clock-cells = <0>; reg = <41>; - atmel,clk-output-range = <0 66000000>; + atmel,clk-output-range = <0 83000000>; }; }; };
arch/arm/boot/dts/sama5d3_uart.dtsi +2 -2
@@ -42,13 +42,13 @@ uart0_clk: uart0_clk { #clock-cells = <0>; reg = <16>; - atmel,clk-output-range = <0 66000000>; + atmel,clk-output-range = <0 83000000>; }; uart1_clk: uart1_clk { #clock-cells = <0>; reg = <17>; - atmel,clk-output-range = <0 66000000>; + atmel,clk-output-range = <0 83000000>; }; }; };
Greg Kroah-Hartman
maintainerPATCH 27/52 ARM: dts: at91: sama5d3: define clock rate range for tcb1
In reply to Greg Kroah-HartmanFrom: Alexandre Belloni <[email protected]>
commit a7e0f3fc01df4b1b7077df777c37feae8c9e8b6d upstream.
The clock rate range for the TCB1 clock is missing. define it in the device tree.
--- arch/arm/boot/dts/sama5d3_tcb1.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/sama5d3_tcb1.dtsi +1 -0
@@ -23,6 +23,7 @@ tcb1_clk: tcb1_clk { #clock-cells = <0>; reg = <27>; + atmel,clk-output-range = <0 166000000>; }; }; };
Greg Kroah-Hartman
maintainerPATCH 28/52 tools/power/acpi: fix compilation error
In reply to Greg Kroah-HartmanFrom: Zhengyuan Liu <[email protected]>
commit 1985f8c7f9a42a651a9750d6fcadc74336d182df upstream.
If we compile tools/acpi target in the top source directory, we'd get a compilation error showing as bellow:
# make tools/acpi DESCEND power/acpi DESCEND tools/acpidbg CC tools/acpidbg/acpidbg.o Assembler messages: Fatal error: can't create /home/lzy/kernel-upstream/power/acpi/\ tools/acpidbg/acpidbg.o: No such file or directory ../../Makefile.rules:26: recipe for target '/home/lzy/kernel-upstream/\ power/acpi/tools/acpidbg/acpidbg.o' failed make[3]: *** [/home/lzy/kernel-upstream//power/acpi/tools/acpidbg/\ acpidbg.o] Error 1 Makefile:19: recipe for target 'acpidbg' failed make[2]: *** [acpidbg] Error 2 Makefile:54: recipe for target 'acpi' failed make[1]: *** [acpi] Error 2 Makefile:1607: recipe for target 'tools/acpi' failed make: *** [tools/acpi] Error 2
--- tools/power/acpi/Makefile.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/power/acpi/Makefile.config +1 -1
@@ -18,7 +18,7 @@ include $(srctree)/../../scripts/Makefil OUTPUT=$(srctree)/ ifeq ("$(origin O)", "command line") - OUTPUT := $(O)/power/acpi/ + OUTPUT := $(O)/tools/power/acpi/ endif #$(info Determined 'OUTPUT' to be $(OUTPUT))
Greg Kroah-Hartman
maintainerPATCH 29/52 powerpc/pseries/vio: Fix iommu_table use-after-free refcount warning
In reply to Greg Kroah-HartmanFrom: Tyrel Datwyler <[email protected]>
commit aff8c8242bc638ba57247ae1ec5f272ac3ed3b92 upstream.
Commit e5afdf9dd515 ("powerpc/vfio_spapr_tce: Add reference counting to iommu_table") missed an iommu_table allocation in the pseries vio code. The iommu_table is allocated with kzalloc and as a result the associated kref gets a value of zero. This has the side effect that during a DLPAR remove of the associated virtual IOA the iommu_tce_table_put() triggers a use-after-free underflow warning.
Call Trace: [c0000002879e39f0] [c00000000071ecb4] refcount_warn_saturate+0x184/0x190
(unreliable)
[c0000002879e3a50] [c0000000000500ac] iommu_tce_table_put+0x9c/0xb0 [c0000002879e3a70] [c0000000000f54e4] vio_dev_release+0x34/0x70 [c0000002879e3aa0] [c00000000087cfa4] device_release+0x54/0xf0 [c0000002879e3b10] [c000000000d64c84] kobject_cleanup+0xa4/0x240 [c0000002879e3b90] [c00000000087d358] put_device+0x28/0x40 [c0000002879e3bb0] [c0000000007a328c] dlpar_remove_slot+0x15c/0x250 [c0000002879e3c50] [c0000000007a348c] remove_slot_store+0xac/0xf0 [c0000002879e3cd0] [c000000000d64220] kobj_attr_store+0x30/0x60 [c0000002879e3cf0] [c0000000004ff13c] sysfs_kf_write+0x6c/0xa0 [c0000002879e3d10] [c0000000004fde4c] kernfs_fop_write+0x18c/0x260 [c0000002879e3d60] [c000000000410f3c] __vfs_write+0x3c/0x70 [c0000002879e3d80] [c000000000415408] vfs_write+0xc8/0x250 [c0000002879e3dd0] [c0000000004157dc] ksys_write+0x7c/0x120 [c0000002879e3e20] [c00000000000b278] system_call+0x5c/0x68
Further, since the refcount was always zero the iommu_tce_table_put() fails to call the iommu_table release function resulting in a leak.
Fix this issue be initilizing the iommu_table kref immediately after allocation.
--- arch/powerpc/platforms/pseries/vio.c | 2 ++ 1 file changed, 2 insertions(+)
arch/powerpc/platforms/pseries/vio.c +2 -0
@@ -1195,6 +1195,8 @@ static struct iommu_table *vio_build_iomif (tbl ==NULL )return NULL ; +kref_init (&tbl->it_kref); +of_parse_dma_window (dev->dev.of_node, dma_window, &tbl->it_index, &offset, &size);
Greg Kroah-Hartman
maintainerPATCH 30/52 powerpc/pseries: Allow not having ibm, hypertas-functions::hcall-multi-tce for DDW
In reply to Greg Kroah-HartmanFrom: Alexey Kardashevskiy <[email protected]>
commit 7559d3d295f3365ea7ac0c0274c05e633fe4f594 upstream.
By default a pseries guest supports a H_PUT_TCE hypercall which maps a single IOMMU page in a DMA window. Additionally the hypervisor may support H_PUT_TCE_INDIRECT/H_STUFF_TCE which update multiple TCEs at once; this is advertised via the device tree /rtas/ibm,hypertas-functions property which Linux converts to FW_FEATURE_MULTITCE.
FW_FEATURE_MULTITCE is checked when dma_iommu_ops is used; however the code managing the huge DMA window (DDW) ignores it and calls H_PUT_TCE_INDIRECT even if it is explicitly disabled via the "multitce=off" kernel command line parameter.
This adds FW_FEATURE_MULTITCE checking to the DDW code path.
This changes tce_build_pSeriesLP to take liobn and page size as the huge window does not have iommu_table descriptor which usually the place to store these numbers.
--- arch/powerpc/platforms/pseries/iommu.c | 43 ++++++++++++++++++++++----------- 1 file changed, 29 insertions(+), 14 deletions(-)
arch/powerpc/platforms/pseries/iommu.c +29 -14
@@ -167,10 +167,10 @@ static unsigned long tce_get_pseries(strreturn be64_to_cpu (*tcep); } -static void tce_free_pSeriesLP (struct iommu_table *,long ,long ); +static void tce_free_pSeriesLP (unsigned long liobn,long ,long );static void tce_freemulti_pSeriesLP (struct iommu_table *,long ,long ); -static int tce_build_pSeriesLP (struct iommu_table *tbl,long tcenum, +static int tce_build_pSeriesLP (unsigned long liobn,long tcenum,long tceshift,long npages,unsigned long uaddr,enum dma_data_direction direction,unsigned long attrs)
@@ -181,25 +181,25 @@ static int tce_build_pSeriesLP(struct ioint ret =0 ;long tcenum_start = tcenum, npages_start = npages; - rpn =__pa (uaddr) >>TCE_SHIFT ; + rpn =__pa (uaddr) >> tceshift; proto_tce =TCE_PCI_READ ;if (direction !=DMA_TO_DEVICE ) proto_tce |=TCE_PCI_WRITE ;while (npages--) { - tce = proto_tce | (rpn &TCE_RPN_MASK ) <<TCE_RPN_SHIFT ; - rc =plpar_tce_put ((u64 )tbl->it_index, (u64 )tcenum <<12 , tce); + tce = proto_tce | (rpn &TCE_RPN_MASK ) << tceshift; + rc =plpar_tce_put ((u64 )liobn, (u64 )tcenum << tceshift, tce);if (unlikely (rc ==H_NOT_ENOUGH_RESOURCES )) { ret = (int )rc; -tce_free_pSeriesLP (tbl, tcenum_start, +tce_free_pSeriesLP (liobn, tcenum_start, (npages_start - (npages +1 )));break ; }if (rc &&printk_ratelimit ()) {printk ("tce_build_pSeriesLP: plpar_tce_put failed. rc=%lld\n" , rc); -printk ("\tindex = 0x%llx\n" , (u64 )tbl->it_index); +printk ("\tindex = 0x%llx\n" , (u64 )liobn);printk ("\ttcenum = 0x%llx\n" , (u64 )tcenum);printk ("\ttce val = 0x%llx\n" , tce );dump_stack ();
@@ -228,7 +228,8 @@ static int tce_buildmulti_pSeriesLP(struunsigned long flags;if ((npages ==1 ) || !firmware_has_feature (FW_FEATURE_MULTITCE )) { -return tce_build_pSeriesLP (tbl, tcenum, npages, uaddr, +return tce_build_pSeriesLP (tbl->it_index, tcenum, + tbl->it_page_shift, npages, uaddr, direction, attrs); }
@@ -244,8 +245,9 @@ static int tce_buildmulti_pSeriesLP(stru/* If allocation fails, fall back to the loop implementation */ if (!tcep) {local_irq_restore (flags); -return tce_build_pSeriesLP (tbl, tcenum, npages, uaddr, - direction, attrs); +return tce_build_pSeriesLP (tbl->it_index, tcenum, + tbl->it_page_shift, + npages, uaddr, direction, attrs); }__this_cpu_write (tce_page, tcep); }
@@ -296,16 +298,16 @@ static int tce_buildmulti_pSeriesLP(strureturn ret; } -static void tce_free_pSeriesLP (struct iommu_table *tbl,long tcenum,long npages) +static void tce_free_pSeriesLP (unsigned long liobn,long tcenum,long npages) {u64 rc;while (npages--) { - rc =plpar_tce_put ((u64 )tbl->it_index, (u64 )tcenum <<12 ,0 ); + rc =plpar_tce_put ((u64 )liobn, (u64 )tcenum <<12 ,0 );if (rc &&printk_ratelimit ()) {printk ("tce_free_pSeriesLP: plpar_tce_put failed. rc=%lld\n" , rc); -printk ("\tindex = 0x%llx\n" , (u64 )tbl->it_index); +printk ("\tindex = 0x%llx\n" , (u64 )liobn);printk ("\ttcenum = 0x%llx\n" , (u64 )tcenum);dump_stack (); }
@@ -320,7 +322,7 @@ static void tce_freemulti_pSeriesLP(struu64 rc;if (!firmware_has_feature (FW_FEATURE_MULTITCE )) -return tce_free_pSeriesLP (tbl, tcenum, npages); +return tce_free_pSeriesLP (tbl->it_index, tcenum, npages); rc =plpar_tce_stuff ((u64 )tbl->it_index, (u64 )tcenum <<12 ,0 , npages);
@@ -435,6 +437,19 @@ static int tce_setrange_multi_pSeriesLP(u64 rc =0 ;long l, limit; +if (!firmware_has_feature (FW_FEATURE_MULTITCE )) { +unsigned long tceshift =be32_to_cpu (maprange->tce_shift); +unsigned long dmastart = (start_pfn <<PAGE_SHIFT ) + +be64_to_cpu (maprange->dma_base); +unsigned long tcenum = dmastart >> tceshift; +unsigned long npages = num_pfn <<PAGE_SHIFT >> tceshift; +void *uaddr =__va (start_pfn <<PAGE_SHIFT ); + +return tce_build_pSeriesLP (be32_to_cpu (maprange->liobn), + tcenum, tceshift, npages, (unsigned long ) uaddr, +DMA_BIDIRECTIONAL ,0 ); + } +local_irq_disable ();/* to protect tcep and the page behind it */ tcep =__this_cpu_read (tce_page);
Greg Kroah-Hartman
maintainerPATCH 31/52 iommu/arm-smmu-v3: Populate VMID field for CMDQ_OP_TLBI_NH_VA
In reply to Greg Kroah-HartmanFrom: Shameer Kolothum <[email protected]>
commit 935d43ba272e0001f8ef446a3eff15d8175cb11b upstream.
CMDQ_OP_TLBI_NH_VA requires VMID and this was missing since commit 1c27df1c0a82 ("iommu/arm-smmu: Use correct address mask for CMD_TLBI_S2_IPA"). Add it back.
--- drivers/iommu/arm-smmu-v3.c | 1 + 1 file changed, 1 insertion(+)
drivers/iommu/arm-smmu-v3.c +1 -0
@@ -810,6 +810,7 @@ static int arm_smmu_cmdq_build_cmd(u64 * cmd[1 ] |=FIELD_PREP (CMDQ_CFGI_1_RANGE ,31 );break ;case CMDQ_OP_TLBI_NH_VA : + cmd[0 ] |=FIELD_PREP (CMDQ_TLBI_0_VMID , ent->tlbi.vmid); cmd[0 ] |=FIELD_PREP (CMDQ_TLBI_0_ASID , ent->tlbi.asid); cmd[1 ] |=FIELD_PREP (CMDQ_TLBI_1_LEAF , ent->tlbi.leaf); cmd[1 ] |= ent->tlbi.addr &CMDQ_TLBI_1_VA_MASK ;
Greg Kroah-Hartman
maintainerPATCH 32/52 KVM: arm/arm64: vgic-its: Fix restoration of unmapped collections
In reply to Greg Kroah-HartmanFrom: Eric Auger <[email protected]>
commit 8c58be34494b7f1b2adb446e2d8beeb90e5de65b upstream.
Saving/restoring an unmapped collection is a valid scenario. For example this happens if a MAPTI command was sent, featuring an unmapped collection. At the moment the CTE fails to be restored. Only compare against the number of online vcpus if the rdist base is set.
--- virt/kvm/arm/vgic/vgic-its.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
virt/kvm/arm/vgic/vgic-its.c +2 -1
@@ -2292,7 +2292,8 @@ static int vgic_its_restore_cte(struct v target_addr = (u32)(val >>KVM_ITS_CTE_RDBASE_SHIFT ); coll_id = val &KVM_ITS_CTE_ICID_MASK ; -if (target_addr >=atomic_read (&kvm->online_vcpus)) +if (target_addr !=COLLECTION_NOT_MAPPED && + target_addr >=atomic_read (&kvm->online_vcpus))return -EINVAL ; collection =find_collection (its, coll_id);
Greg Kroah-Hartman
maintainerPATCH 33/52 ARM: 8949/1: mm: mark free_memmap as __init
In reply to Greg Kroah-HartmanFrom: Olof Johansson <[email protected]>
commit 31f3010e60522ede237fb145a63b4af5a41718c2 upstream.
As of commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING forcibly"), free_memmap() might not always be inlined, and thus is triggering a section warning:
WARNING: vmlinux.o(.text.unlikely+0x904): Section mismatch in reference from the function free_memmap() to the function .meminit.text:memblock_free()
Mark it as __init, since the faller (free_unused_memmap) already is.
--- arch/arm/mm/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mm/init.c +1 -1
@@ -357,7 +357,7 @@ static inline void poison_init_mem(void *p++ =0xe7fddef0 ; } -static inline void +static inline void __init free_memmap (unsigned long start_pfn,unsigned long end_pfn) {struct page *start_pg, *end_pg;
Greg Kroah-Hartman
maintainerPATCH 34/52 arm64: cpufeature: Fix the type of no FP/SIMD capability
In reply to Greg Kroah-HartmanFrom: Suzuki K Poulose <[email protected]>
commit 449443c03d8cfdacf7313e17779a2594ebf87e6d upstream.
The NO_FPSIMD capability is defined with scope SYSTEM, which implies that the "absence" of FP/SIMD on at least one CPU is detected only after all the SMP CPUs are brought up. However, we use the status of this capability for every context switch. So, let us change the scope to LOCAL_CPU to allow the detection of this capability as and when the first CPU without FP is brought up.
Also, the current type allows hotplugged CPU to be brought up without FP/SIMD when all the current CPUs have FP/SIMD and we have the userspace up. Fix both of these issues by changing the capability to BOOT_RESTRICTED_LOCAL_CPU_FEATURE.
--- arch/arm64/kernel/cpufeature.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/kernel/cpufeature.c +1 -1
@@ -1241,7 +1241,7 @@ static const struct arm64_cpu_capabiliti {/* FP/SIMD is not implemented */ .capability = ARM64_HAS_NO_FPSIMD, - .type = ARM64_CPUCAP_SYSTEM_FEATURE, + .type = ARM64_CPUCAP_BOOT_RESTRICTED_CPU_LOCAL_FEATURE, .min_field_value = 0, .matches = has_no_fpsimd, },
Greg Kroah-Hartman
maintainerPATCH 35/52 arm64: ptrace: nofpsimd: Fail FP/SIMD regset operations
In reply to Greg Kroah-HartmanFrom: Suzuki K Poulose <[email protected]>
commit c9d66999f064947e6b577ceacc1eb2fbca6a8d3c upstream.
When fp/simd is not supported on the system, fail the operations of FP/SIMD regsets.
--- arch/arm64/kernel/ptrace.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
arch/arm64/kernel/ptrace.c +21 -0
@@ -627,6 +627,13 @@ static int gpr_set(struct task_struct *treturn 0 ; } +static int fpr_active (struct task_struct *target,const struct user_regset *regset) +{ +if (!system_supports_fpsimd ()) +return -ENODEV ; +return regset->n; +} +/* * TODO: update fp accessors for lazy context switching (sync/flush hwstate) */
@@ -649,6 +656,9 @@ static int fpr_get(struct task_struct *t unsigned int pos, unsigned int count, void *kbuf, void __user *ubuf) { + if (!system_supports_fpsimd()) + return -EINVAL; +if (target == current)fpsimd_preserve_current_state ();
@@ -688,6 +698,9 @@ static int fpr_set(struct task_struct *t {int ret; +if (!system_supports_fpsimd ()) +return -EINVAL ; + ret =__fpr_set (target, regset, pos, count, kbuf, ubuf,0 );if (ret)return ret;
@@ -990,6 +1003,7 @@ static const struct user_regset aarch64_*/ .size = sizeof(u32), .align = sizeof(u32), + .active = fpr_active, .get = fpr_get, .set = fpr_set },
@@ -1176,6 +1190,9 @@ static int compat_vfp_get(struct task_stcompat_ulong_t fpscr;int ret, vregs_end_pos; +if (!system_supports_fpsimd ()) +return -EINVAL ; + uregs = &target->thread.uw.fpsimd_state;if (target == current)
@@ -1209,6 +1226,9 @@ static int compat_vfp_set(struct task_stcompat_ulong_t fpscr;int ret, vregs_end_pos; +if (!system_supports_fpsimd ()) +return -EINVAL ; + uregs = &target->thread.uw.fpsimd_state; vregs_end_pos =VFP_STATE_SIZE -sizeof (compat_ulong_t);
@@ -1266,6 +1286,7 @@ static const struct user_regset aarch32_ .n = VFP_STATE_SIZE / sizeof(compat_ulong_t), .size = sizeof(compat_ulong_t), .align = sizeof(compat_ulong_t), + .active = fpr_active, .get = compat_vfp_get, .set = compat_vfp_set },
Greg Kroah-Hartman
maintainerPATCH 36/52 KVM: arm/arm64: Fix young bit from mmu notifier
In reply to Greg Kroah-HartmanFrom: Gavin Shan <[email protected]>
commit cf2d23e0bac9f6b5cd1cba8898f5f05ead40e530 upstream.
kvm_test_age_hva() is called upon mmu_notifier_test_young(), but wrong address range has been passed to handle_hva_to_gpa(). With the wrong address range, no young bits will be checked in handle_hva_to_gpa(). It means zero is always returned from mmu_notifier_test_young().
This fixes the issue by passing correct address range to the underly function handle_hva_to_gpa(), so that the hardware young (access) bit will be visited.
--- virt/kvm/arm/mmu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
virt/kvm/arm/mmu.c +2 -1
@@ -1925,7 +1925,8 @@ int kvm_test_age_hva(struct kvm *kvm, unif (!kvm->arch.pgd)return 0 ;trace_kvm_test_age_hva (hva); -return handle_hva_to_gpa (kvm, hva, hva, kvm_test_age_hva_handler,NULL ); +return handle_hva_to_gpa (kvm, hva, hva +PAGE_SIZE , + kvm_test_age_hva_handler,NULL ); }void kvm_mmu_free_memory_caches (struct kvm_vcpu *vcpu)
Greg Kroah-Hartman
maintainerPATCH 37/52 KVM: arm: Fix DFSR setting for non-LPAE aarch32 guests
In reply to Greg Kroah-HartmanFrom: James Morse <[email protected]>
commit 018f22f95e8a6c3e27188b7317ef2c70a34cb2cd upstream.
Beata reports that KVM_SET_VCPU_EVENTS doesn't inject the expected exception to a non-LPAE aarch32 guest.
The host intends to inject DFSR.FS=0x14 "IMPLEMENTATION DEFINED fault (Lockdown fault)", but the guest receives DFSR.FS=0x04 "Fault on instruction cache maintenance". This fault is hooked by do_translation_fault() since ARMv6, which goes on to silently 'handle' the exception, and restart the faulting instruction.
It turns out, when TTBCR.EAE is clear DFSR is split, and FS[4] has to shuffle up to DFSR[10].
As KVM only does this in one place, fix up the static values. We now get the expected:
| Unhandled fault: lock abort (0x404) at 0x9c800f00
--- virt/kvm/arm/aarch32.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
virt/kvm/arm/aarch32.c +5 -3
@@ -192,10 +192,12 @@ static void inject_abt32(struct kvm_vcpu/* Give the guest an IMPLEMENTATION DEFINED exception */ is_lpae = (vcpu_cp15 (vcpu, c2_TTBCR) >>31 ); -if (is_lpae) +if (is_lpae) { *fsr =1 <<9 |0x34 ; -else - *fsr =0x14 ; + }else { +/* Surprise! DFSR's FS[4] lives in bit 10 */ + *fsr =BIT (10 ) |0x4 ;/* 0x14 */ + } }void kvm_inject_dabt32 (struct kvm_vcpu *vcpu,unsigned long addr)
Greg Kroah-Hartman
maintainerPATCH 38/52 KVM: arm: Make inject_abt32() inject an external abort instead
In reply to Greg Kroah-HartmanFrom: James Morse <[email protected]>
commit 21aecdbd7f3ab02c9b82597dc733ee759fb8b274 upstream.
KVM's inject_abt64() injects an external-abort into an aarch64 guest. The KVM_CAP_ARM_INJECT_EXT_DABT is intended to do exactly this, but for an aarch32 guest inject_abt32() injects an implementation-defined exception, 'Lockdown fault'.
Change this to external abort. For non-LPAE we now get the documented:
| Unhandled fault: external abort on non-linefetch (0x008) at 0x9c800f00 and for LPAE:
| Unhandled fault: synchronous external abort (0x210) at 0x9c800f00
--- virt/kvm/arm/aarch32.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
virt/kvm/arm/aarch32.c +7 -3
@@ -26,6 +26,10 @@#include <asm/kvm_emulate.h> #include <asm/kvm_hyp.h> +#define DFSR_FSC_EXTABT_LPAE 0x10 +#define DFSR_FSC_EXTABT_nLPAE 0x08 +#define DFSR_LPAE BIT(9) +/* * Table taken from ARMv8 ARM DDI0487B-B, table G1-10. */
@@ -193,10 +197,10 @@ static void inject_abt32(struct kvm_vcpu/* Give the guest an IMPLEMENTATION DEFINED exception */ is_lpae = (vcpu_cp15 (vcpu, c2_TTBCR) >>31 );if (is_lpae) { - *fsr =1 <<9 |0x34 ; + *fsr =DFSR_LPAE |DFSR_FSC_EXTABT_LPAE ; }else { -/* Surprise! DFSR's FS[4] lives in bit 10 */ - *fsr =BIT (10 ) |0x4 ;/* 0x14 */ +/* no need to shuffle FS[4] into DFSR[10] as its 0 */ + *fsr = DFSR_FSC_EXTABT_nLPAE; } }
Greg Kroah-Hartman
maintainerPATCH 39/52 KVM: arm64: pmu: Dont increment SW_INCR if PMCR.E is unset
In reply to Greg Kroah-HartmanFrom: Eric Auger <[email protected]>
commit 3837407c1aa1101ed5e214c7d6041e7a23335c6e upstream.
The specification says PMSWINC increments PMEVCNTR<n>_EL1 by 1 if PMEVCNTR<n>_EL0 is enabled and configured to count SW_INCR.
For PMEVCNTR<n>_EL0 to be enabled, we need both PMCNTENSET to be set for the corresponding event counter but we also need the PMCR.E bit to be set.
--- virt/kvm/arm/pmu.c | 3 +++ 1 file changed, 3 insertions(+)
virt/kvm/arm/pmu.c +3 -0
@@ -316,6 +316,9 @@ void kvm_pmu_software_increment(struct kif (val ==0 )return ; +if (!(__vcpu_sys_reg (vcpu,PMCR_EL0 ) &ARMV8_PMU_PMCR_E )) +return ; + enable =__vcpu_sys_reg (vcpu,PMCNTENSET_EL0 );for (i =0 ; i <ARMV8_PMU_CYCLE_IDX ; i++) {if (!(val &BIT (i)))
Greg Kroah-Hartman
maintainerPATCH 40/52 mtd: onenand_base: Adjust indentation in onenand_read_ops_nolock
In reply to Greg Kroah-HartmanFrom: Nathan Chancellor <[email protected]>
commit 0e7ca83e82d021c928dadf4c13c137d57337540d upstream.
Clang warns:
../drivers/mtd/nand/onenand/onenand_base.c:1269:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
while (!ret) {
^../drivers/mtd/nand/onenand/onenand_base.c:1266:2: note: previous statement is here
if (column + thislen > writesize)
^
1 warning generated.
This warning occurs because there is a space before the tab of the while loop. There are spaces at the beginning of a lot of the lines in this block, remove them so that the indentation is consistent with the Linux kernel coding style and clang no longer warns.
--- drivers/mtd/nand/onenand/onenand_base.c | 82 ++++++++++++++++---------------- 1 file changed, 41 insertions(+), 41 deletions(-)
drivers/mtd/nand/onenand/onenand_base.c +41 -41
@@ -1251,44 +1251,44 @@ static int onenand_read_ops_nolock(struc stats = mtd->ecc_stats; -/* Read-while-load method */ +/* Read-while-load method */ -/* Do first load to bufferRAM */ -if (read < len) { -if (!onenand_check_bufferram (mtd, from)) { +/* Do first load to bufferRAM */ +if (read < len) { +if (!onenand_check_bufferram (mtd, from)) { this->command (mtd,ONENAND_CMD_READ , from, writesize); - ret = this->wait (mtd,FL_READING ); -onenand_update_bufferram (mtd, from, !ret); + ret = this->wait (mtd,FL_READING ); +onenand_update_bufferram (mtd, from, !ret);if (mtd_is_eccerr (ret)) ret =0 ; - } - } + } + } thislen =min_t (int, writesize, len - read); column = from & (writesize -1 );if (column + thislen > writesize) thislen = writesize - column; -while (!ret) { -/* If there is more to load then start next load */ - from += thislen; -if (read + thislen < len) { +while (!ret) { +/* If there is more to load then start next load */ + from += thislen; +if (read + thislen < len) { this->command (mtd,ONENAND_CMD_READ , from, writesize); -/* -* Chip boundary handling in DDP -* Now we issued chip 1 read and pointed chip 1 +/* +* Chip boundary handling in DDP +* Now we issued chip 1 read and pointed chip 1 * bufferram so we have to point chip 0 bufferram. -*/ -if (ONENAND_IS_DDP (this) && -unlikely (from == (this->chipsize >>1 ))) { - this->write_word (ONENAND_DDP_CHIP0 , this->base +ONENAND_REG_START_ADDRESS2 ); - boundary =1 ; - }else - boundary =0 ; -ONENAND_SET_PREV_BUFFERRAM (this); - } -/* While load is going, read from last bufferRAM */ - this->read_bufferram (mtd,ONENAND_DATARAM , buf, column, thislen); +*/ +if (ONENAND_IS_DDP (this) && +unlikely (from == (this->chipsize >>1 ))) { + this->write_word (ONENAND_DDP_CHIP0 , this->base +ONENAND_REG_START_ADDRESS2 ); + boundary =1 ; + }else + boundary =0 ; +ONENAND_SET_PREV_BUFFERRAM (this); + } +/* While load is going, read from last bufferRAM */ + this->read_bufferram (mtd,ONENAND_DATARAM , buf, column, thislen);/* Read oob area if needed */ if (oobbuf) {
@@ -1304,24 +1304,24 @@ static int onenand_read_ops_nolock(struc oobcolumn =0 ; } -/* See if we are done */ - read += thislen; -if (read == len) -break ; -/* Set up for next read from bufferRAM */ -if (unlikely (boundary)) - this->write_word (ONENAND_DDP_CHIP1 , this->base +ONENAND_REG_START_ADDRESS2 ); -ONENAND_SET_NEXT_BUFFERRAM (this); - buf += thislen; +/* See if we are done */ + read += thislen; +if (read == len) +break ; +/* Set up for next read from bufferRAM */ +if (unlikely (boundary)) + this->write_word (ONENAND_DDP_CHIP1 , this->base +ONENAND_REG_START_ADDRESS2 ); +ONENAND_SET_NEXT_BUFFERRAM (this); + buf += thislen; thislen =min_t (int, writesize, len - read); - column =0 ; -cond_resched (); -/* Now wait for load */ - ret = this->wait (mtd,FL_READING ); -onenand_update_bufferram (mtd, from, !ret); + column =0 ; +cond_resched (); +/* Now wait for load */ + ret = this->wait (mtd,FL_READING ); +onenand_update_bufferram (mtd, from, !ret);if (mtd_is_eccerr (ret)) ret =0 ; - } + }/* * Return success, if no ECC failures, else -EBADMSG
Greg Kroah-Hartman
maintainerPATCH 41/52 mtd: sharpslpart: Fix unsigned comparison to zero
In reply to Greg Kroah-HartmanFrom: YueHaibing <[email protected]>
commit f33113b542219448fa02d77ca1c6f4265bd7f130 upstream.
The unsigned variable log_num is being assigned a return value from the call to sharpsl_nand_get_logical_num that can return -EINVAL.
Detected using Coccinelle:
./drivers/mtd/parsers/sharpslpart.c:207:6-13: WARNING: Unsigned expression compared with zero: log_num > 0
--- drivers/mtd/parsers/sharpslpart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mtd/parsers/sharpslpart.c +2 -2
@@ -165,10 +165,10 @@ static int sharpsl_nand_get_logical_num(static int sharpsl_nand_init_ftl (struct mtd_info *mtd,struct sharpsl_ftl *ftl) { -unsigned int block_num, log_num, phymax; +unsigned int block_num, phymax; +int i, ret, log_num;loff_t block_adr;u8 *oob; -int i, ret; oob =kzalloc (mtd->oobsize,GFP_KERNEL );if (!oob)
Greg Kroah-Hartman
maintainerPATCH 42/52 crypto: artpec6 - return correct error code for failed setkey()
In reply to Greg Kroah-HartmanFrom: Eric Biggers <[email protected]>
commit b828f905904cd76424230c69741a4cabb0174168 upstream.
->setkey() is supposed to retun -EINVAL for invalid key lengths, not -1.
--- drivers/crypto/axis/artpec6_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/axis/artpec6_crypto.c +1 -1
@@ -1256,7 +1256,7 @@ static int artpec6_crypto_aead_set_key(sif (len !=16 && len !=24 && len !=32 ) {crypto_aead_set_flags (tfm,CRYPTO_TFM_RES_BAD_KEY_LEN ); -return -1 ; +return -EINVAL ; } ctx->key_length = len;
Greg Kroah-Hartman
maintainerPATCH 43/52 crypto: atmel-sha - fix error handling when setting hmac key
In reply to Greg Kroah-HartmanFrom: Eric Biggers <[email protected]>
commit b529f1983b2dcc46354f311feda92e07b6e9e2da upstream.
HMAC keys can be of any length, and atmel_sha_hmac_key_set() can only fail due to -ENOMEM. But atmel_sha_hmac_setkey() incorrectly treated any error as a "bad key length" error. Fix it to correctly propagate the -ENOMEM error code and not set any tfm result flags.
--- drivers/crypto/atmel-sha.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/crypto/atmel-sha.c +1 -6
@@ -1921,12 +1921,7 @@ static int atmel_sha_hmac_setkey(struct {struct atmel_sha_hmac_ctx *hmac =crypto_ahash_ctx (tfm); -if (atmel_sha_hmac_key_set (&hmac->hkey, key, keylen)) { -crypto_ahash_set_flags (tfm,CRYPTO_TFM_RES_BAD_KEY_LEN ); -return -EINVAL ; - } - -return 0 ; +return atmel_sha_hmac_key_set (&hmac->hkey, key, keylen); }static int atmel_sha_hmac_init (struct ahash_request *req)
Greg Kroah-Hartman
maintainerPATCH 44/52 media: i2c: adv748x: Fix unsafe macros
In reply to Greg Kroah-HartmanFrom: Gustavo A. R. Silva <[email protected]>
commit 0d962e061abcf1b9105f88fb850158b5887fbca3 upstream.
Enclose multiple macro parameters in parentheses in order to make such macros safer and fix the Clang warning below:
drivers/media/i2c/adv748x/adv748x-afe.c:452:12: warning: operator '?:' has lower precedence than '|'; '|' will be evaluated first [-Wbitwise-conditional-parentheses]
ret = sdp_clrset(state, ADV748X_SDP_FRP, ADV748X_SDP_FRP_MASK, enable ? ctrl->val - 1 : 0);
--- drivers/media/i2c/adv748x/adv748x.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/media/i2c/adv748x/adv748x.h +4 -4
@@ -361,10 +361,10 @@ int adv748x_write_block(struct adv748x_s#define io_read (s, r) adv748x_read(s, ADV748X_PAGE_IO, r)#define io_write (s, r, v) adv748x_write(s, ADV748X_PAGE_IO, r, v) -#define io_clrset (s, r, m, v) io_write(s, r, (io_read(s, r) & ~m) | v) +#define io_clrset (s, r, m, v) io_write(s, r, (io_read(s, r) & ~(m)) | (v))#define hdmi_read (s, r) adv748x_read(s, ADV748X_PAGE_HDMI, r) -#define hdmi_read16 (s, r, m) (((hdmi_read(s, r) << 8) | hdmi_read(s, r+1)) & m) +#define hdmi_read16 (s, r, m) (((hdmi_read(s, r) << 8) | hdmi_read(s, (r)+1)) & (m))#define hdmi_write (s, r, v) adv748x_write(s, ADV748X_PAGE_HDMI, r, v)#define repeater_read (s, r) adv748x_read(s, ADV748X_PAGE_REPEATER, r)
@@ -372,11 +372,11 @@ int adv748x_write_block(struct adv748x_s#define sdp_read (s, r) adv748x_read(s, ADV748X_PAGE_SDP, r)#define sdp_write (s, r, v) adv748x_write(s, ADV748X_PAGE_SDP, r, v) -#define sdp_clrset (s, r, m, v) sdp_write(s, r, (sdp_read(s, r) & ~m) | v) +#define sdp_clrset (s, r, m, v) sdp_write(s, r, (sdp_read(s, r) & ~(m)) | (v))#define cp_read (s, r) adv748x_read(s, ADV748X_PAGE_CP, r)#define cp_write (s, r, v) adv748x_write(s, ADV748X_PAGE_CP, r, v) -#define cp_clrset (s, r, m, v) cp_write(s, r, (cp_read(s, r) & ~m) | v) +#define cp_clrset (s, r, m, v) cp_write(s, r, (cp_read(s, r) & ~(m)) | (v))#define txa_read (s, r) adv748x_read(s, ADV748X_PAGE_TXA, r)#define txb_read (s, r) adv748x_read(s, ADV748X_PAGE_TXB, r)
Greg Kroah-Hartman
maintainerPATCH 45/52 pinctrl: sh-pfc: r8a7778: Fix duplicate SDSELF_B and SD1_CLK_B
In reply to Greg Kroah-HartmanFrom: Geert Uytterhoeven <[email protected]>
commit 805f635703b2562b5ddd822c62fc9124087e5dd5 upstream.
The FN_SDSELF_B and FN_SD1_CLK_B enum IDs are used twice, which means one set of users must be wrong. Replace them by the correct enum IDs.
--- drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/sh-pfc/pfc-r8a7778.c +2 -2
@@ -2325,7 +2325,7 @@ static const struct pinmux_cfg_reg pinmuFN_ATAG0_A ,0 ,FN_REMOCON_B ,0 ,/* IP0_11_8 [4] */ FN_SD1_DAT2_A ,FN_MMC_D2 ,0 ,FN_BS , -FN_ATADIR0_A ,0 ,FN_SDSELF_B ,0 , +FN_ATADIR0_A ,0 ,FN_SDSELF_A ,0 ,FN_PWM4_B ,0 ,0 ,0 ,0 ,0 ,0 ,0 , /* IP0_7_5 [3] */
@@ -2367,7 +2367,7 @@ static const struct pinmux_cfg_reg pinmuFN_TS_SDAT0_A ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,/* IP1_10_8 [3] */ -FN_SD1_CLK_B ,FN_MMC_D6 ,0 ,FN_A24 , +FN_SD1_CD_A ,FN_MMC_D6 ,0 ,FN_A24 ,FN_DREQ1_A ,0 ,FN_HRX0_B ,FN_TS_SPSYNC0_A ,/* IP1_7_5 [3] */ FN_A23, FN_HTX0_B, FN_TX2_B, FN_DACK2_A,
Greg Kroah-Hartman
maintainerPATCH 46/52 mwifiex: Fix possible buffer overflows in mwifiex_ret_wmm_get_status()
In reply to Greg Kroah-HartmanFrom: Qing Xu <[email protected]>
[ Upstream commit 3a9b153c5591548612c3955c9600a98150c81875 ]
mwifiex_ret_wmm_get_status() calls memcpy() without checking the destination size.Since the source is given from remote AP which contains illegal wmm elements , this may trigger a heap buffer overflow.
Fix it by putting the length check before calling memcpy().
--- drivers/net/wireless/marvell/mwifiex/wmm.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/wireless/marvell/mwifiex/wmm.c +4 -0
@@ -977,6 +977,10 @@ int mwifiex_ret_wmm_get_status(struct mwifiex_private *priv,"WMM Parameter Set Count: %d\n" , wmm_param_ie->qos_info_bitmap & mask); +if (wmm_param_ie->vend_hdr.len +2 > +sizeof (struct ieee_types_wmm_parameter )) +break ; +memcpy ((u8 *) &priv->curr_bss_params.bss_descriptor. wmm_ie, wmm_param_ie, wmm_param_ie->vend_hdr.len +2 );
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 47/52 mwifiex: Fix possible buffer overflows in mwifiex_cmd_append_vsie_tlv()
In reply to Greg Kroah-HartmanFrom: Qing Xu <[email protected]>
[ Upstream commit b70261a288ea4d2f4ac7cd04be08a9f0f2de4f4d ]
mwifiex_cmd_append_vsie_tlv() calls memcpy() without checking the destination size may trigger a buffer overflower, which a local user could use to cause denial of service or the execution of arbitrary code.
Fix it by putting the length check before calling memcpy().
--- drivers/net/wireless/marvell/mwifiex/scan.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/net/wireless/marvell/mwifiex/scan.c +7 -0
@@ -2894,6 +2894,13 @@ mwifiex_cmd_append_vsie_tlv(struct mwifiex_private *priv, vs_param_set->header.len =cpu_to_le16 ((((u16 ) priv->vs_ie[id].ie[1 ]) &0x00FF ) +2 ); +if (le16_to_cpu (vs_param_set->header.len) > +MWIFIEX_MAX_VSIE_LEN ) { +mwifiex_dbg (priv->adapter,ERROR , +"Invalid param length!\n" ); +break ; + } +memcpy (vs_param_set->ie, priv->vs_ie[id].ie,le16_to_cpu (vs_param_set->header.len)); *buffer += le16_to_cpu(vs_param_set->header.len) +
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 48/52 libertas: dont exit from lbs_ibss_join_existing() with RCU read lock held
In reply to Greg Kroah-HartmanFrom: Nicolai Stange <[email protected]>
[ Upstream commit c7bf1fb7ddca331780b9a733ae308737b39f1ad4 ]
Commit e5e884b42639 ("libertas: Fix two buffer overflows at parsing bss descriptor") introduced a bounds check on the number of supplied rates to lbs_ibss_join_existing().
Unfortunately, it introduced a return path from within a RCU read side critical section without a corresponding rcu_read_unlock(). Fix this.
--- drivers/net/wireless/marvell/libertas/cfg.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/wireless/marvell/libertas/cfg.c +1 -0
@@ -1785,6 +1785,7 @@ static int lbs_ibss_join_existing(struct lbs_private *priv, rates_max = rates_eid[1 ];if (rates_max >MAX_RATES ) {lbs_deb_join ("invalid rates" ); +rcu_read_unlock (); goto out; } rates = cmd.bss.rates;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 49/52 libertas: make lbs_ibss_join_existing() return error code on rates overflow
In reply to Greg Kroah-HartmanFrom: Nicolai Stange <[email protected]>
[ Upstream commit 1754c4f60aaf1e17d886afefee97e94d7f27b4cb ]
Commit e5e884b42639 ("libertas: Fix two buffer overflows at parsing bss descriptor") introduced a bounds check on the number of supplied rates to lbs_ibss_join_existing() and made it to return on overflow.
However, the aforementioned commit doesn't set the return value accordingly and thus, lbs_ibss_join_existing() would return with zero even though it failed.
Make lbs_ibss_join_existing return -EINVAL in case the bounds check on the number of supplied rates fails.
--- drivers/net/wireless/marvell/libertas/cfg.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/wireless/marvell/libertas/cfg.c +1 -0
@@ -1786,6 +1786,7 @@ static int lbs_ibss_join_existing(struct lbs_private *priv,if (rates_max >MAX_RATES ) {lbs_deb_join ("invalid rates" );rcu_read_unlock (); + ret = -EINVAL ; goto out; } rates = cmd.bss.rates;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 50/52 scsi: megaraid_sas: Do not initiate OCR if controller is not in ready state
In reply to Greg Kroah-HartmanFrom: Anand Lodnoor <[email protected]>
commit 6d7537270e3283b92f9b327da9d58a4de40fe8d0 upstream.
Driver initiates OCR if a DCMD command times out. But there is a deadlock if the driver attempts to invoke another OCR before the mutex lock (reset_mutex) is released from the previous session of OCR.
This patch takes care of the above scenario using new flag MEGASAS_FUSION_OCR_NOT_POSSIBLE to indicate if OCR is possible.
--- drivers/scsi/megaraid/megaraid_sas_base.c | 3 ++- drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 ++- drivers/scsi/megaraid/megaraid_sas_fusion.h | 1 + 3 files changed, 5 insertions(+), 2 deletions(-)
drivers/scsi/megaraid/megaraid_sas_base.c +2 -1
@@ -4177,7 +4177,8 @@ dcmd_timeout_ocr_possible(struct megasasif (instance->adapter_type ==MFI_SERIES )return KILL_ADAPTER ;else if (instance->unload || -test_bit (MEGASAS_FUSION_IN_RESET , &instance->reset_flags)) +test_bit (MEGASAS_FUSION_OCR_NOT_POSSIBLE , + &instance->reset_flags))return IGNORE_TIMEOUT ;else return INITIATE_OCR ;
drivers/scsi/megaraid/megaraid_sas_fusion.c +2 -1
@@ -4558,6 +4558,7 @@ int megasas_reset_fusion(struct Scsi_Hosif (instance->requestorId && !instance->skip_heartbeat_timer_del)del_timer_sync (&instance->sriov_heartbeat_timer);set_bit (MEGASAS_FUSION_IN_RESET , &instance->reset_flags); +set_bit (MEGASAS_FUSION_OCR_NOT_POSSIBLE , &instance->reset_flags);atomic_set (&instance->adprecovery,MEGASAS_ADPRESET_SM_POLLING ); instance->instancet->disable_intr (instance);megasas_sync_irqs ((unsigned long )instance);
@@ -4747,7 +4748,7 @@ fail_kill_adapter:atomic_set (&instance->adprecovery,MEGASAS_HBA_OPERATIONAL ); } out: -clear_bit (MEGASAS_FUSION_IN_RESET , &instance->reset_flags); +clear_bit (MEGASAS_FUSION_OCR_NOT_POSSIBLE , &instance->reset_flags);mutex_unlock (&instance->reset_mutex);return retval; }
drivers/scsi/megaraid/megaraid_sas_fusion.h +1 -0
@@ -102,6 +102,7 @@ enum MR_RAID_FLAGS_IO_SUB_TYPE {#define MEGASAS_FP_CMD_LEN 16#define MEGASAS_FUSION_IN_RESET 0 +#define MEGASAS_FUSION_OCR_NOT_POSSIBLE 1#define THRESHOLD_REPLY_COUNT 50#define RAID_1_PEER_CMDS 2#define JBOD_MAPS_COUNT 2
Greg Kroah-Hartman
maintainerPATCH 51/52 x86/stackframe: Move ENCODE_FRAME_POINTER to asm/frame.h
In reply to Greg Kroah-HartmanFrom: Peter Zijlstra <[email protected]>
commit a9b3c6998d4a7d53a787cf4d0fd4a4c11239e517 upstream.
In preparation for wider use, move the ENCODE_FRAME_POINTER macros to a common header and provide inline asm versions.
These macros are used to encode a pt_regs frame for the unwinder; see unwind_frame.c:decode_frame_pointer().
--- arch/x86/entry/calling.h | 15 ------------- arch/x86/entry/entry_32.S | 16 -------------- arch/x86/include/asm/frame.h | 49 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 49 insertions(+), 31 deletions(-)
arch/x86/entry/calling.h +0 -15
@@ -172,21 +172,6 @@ For 32-bit we have the following convent .endif .endm -/* -* This is a sneaky trick to help the unwinder find pt_regs on the stack. The -* frame pointer is replaced with an encoded pointer to pt_regs. The encoding -* is just setting the LSB, which makes it an invalid stack address and is also -* a signal to the unwinder that it's a pt_regs pointer in disguise. -* -* NOTE: This macro must be used *after* PUSH_AND_CLEAR_REGS because it corrupts -* the original rbp. -*/ -.macro ENCODE_FRAME_POINTER ptregs_offset=0 -#ifdef CONFIG_FRAME_POINTER - leaq 1+\ptregs_offset(%rsp), %rbp -#endif -.endm -#ifdef CONFIG_PAGE_TABLE_ISOLATION /*
arch/x86/entry/entry_32.S +0 -16
@@ -245,22 +245,6 @@ .Lend_\@: .endm -/* - * This is a sneaky trick to help the unwinder find pt_regs on the stack. The - * frame pointer is replaced with an encoded pointer to pt_regs. The encoding - * is just clearing the MSB, which makes it an invalid stack address and is also - * a signal to the unwinder that it's a pt_regs pointer in disguise. - * - * NOTE: This macro must be used *after* SAVE_ALL because it corrupts the - * original rbp. - */ -.macro ENCODE_FRAME_POINTER -#ifdef CONFIG_FRAME_POINTER - mov %esp, %ebp - andl $0x7fffffff, %ebp -#endif -.endm - .macro RESTORE_INT_REGS popl %ebx popl %ecx
arch/x86/include/asm/frame.h +49 -0
67 lines not on this page · raw message
Greg Kroah-Hartman
maintainerPATCH 52/52 x86/stackframe, x86/ftrace: Add pt_regs frame annotations
In reply to Greg Kroah-HartmanFrom: Peter Zijlstra <[email protected]>
commit ea1ed38dba64b64a245ab8ca1406269d17b99485 upstream.
When CONFIG_FRAME_POINTER, we should mark pt_regs frames.
--- arch/x86/kernel/ftrace_32.S | 3 +++ arch/x86/kernel/ftrace_64.S | 3 +++ 2 files changed, 6 insertions(+)
arch/x86/kernel/ftrace_32.S +3 -0
@@ -9,6 +9,7 @@ #include <asm/export.h> #include <asm/ftrace.h> #include <asm/nospec-branch.h> +#include <asm/frame.h> #ifdef CC_USING_FENTRY # define function_hook __fentry__
@@ -131,6 +132,8 @@ ENTRY(ftrace_regs_caller) pushl %ecx pushl %ebx + ENCODE_FRAME_POINTER + movl 12*4(%esp), %eax /* Load ip (1st parameter) */ subl $MCOUNT_INSN_SIZE, %eax /* Adjust ip */ #ifdef CC_USING_FENTRY
arch/x86/kernel/ftrace_64.S +3 -0
@@ -9,6 +9,7 @@ #include <asm/export.h> #include <asm/nospec-branch.h> #include <asm/unwind_hints.h> +#include <asm/frame.h> .code64 .section .entry.text, "ax"
@@ -222,6 +223,8 @@ GLOBAL(ftrace_regs_caller_op_ptr) leaq MCOUNT_REG_SIZE+8*2(%rsp), %rcx movq %rcx, RSP(%rsp) + ENCODE_FRAME_POINTER + /* regs go into 4th parameter */ leaq (%rsp), %rcx
Hello Greg,
Quoted 8 lines
From: [email protected] <[email protected]> On Behalf Of Greg Kroah-Hartman
Sent: 13 February 2020 15:21This is the start of the stable review cycle for the 4.19.104 release. There are 52 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
No issues seen for CIP configs.
Build/test logs: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/pipelines/117657647
Pipeline: https://gitlab.com/cip-project/cip-testing/linux-cip-pipelines/-/blob/ba32334b/trees/linux-4.19.y.yml
Kind regards, Chris
Quoted 253 lines
Responses should be made by Sat, 15 Feb 2020 15:16:41 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-
review/patch-4.19.104-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-
rc.git linux-4.19.y
and the diffstat can be found below.thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:Greg Kroah-Hartman <[email protected]>
Linux 4.19.104-rc1Peter Zijlstra <[email protected]>
x86/stackframe, x86/ftrace: Addpt_regsframe annotationsPeter Zijlstra <[email protected]>
x86/stackframe: MoveENCODE_FRAME_POINTERtoasm/frame.hAnand Lodnoor <[email protected]>
scsi:megaraid_sas: Do not initiate OCR if controller is not in ready stateNicolai Stange <[email protected]>
libertas: makelbs_ibss_join_existing()return error code on rates overflowNicolai Stange <[email protected]>
libertas: don't exit fromlbs_ibss_join_existing()with RCU read lock heldQing Xu <[email protected]>
mwifiex: Fix possible buffer overflows inmwifiex_cmd_append_vsie_tlv()Qing Xu <[email protected]>
mwifiex: Fix possible buffer overflows inmwifiex_ret_wmm_get_status()Geert Uytterhoeven <[email protected]>
pinctrl: sh-pfc: r8a7778: Fix duplicateSDSELF_BandSD1_CLK_BGustavo A. R. Silva <[email protected]>
media: i2c: adv748x: Fix unsafe macrosEric Biggers <[email protected]>
crypto: atmel-sha - fix error handling when setting hmac keyEric Biggers <[email protected]>
crypto: artpec6 - return correct error code for failedsetkey()YueHaibing <[email protected]>
mtd: sharpslpart: Fix unsigned comparison to zeroNathan Chancellor <[email protected]>
mtd:onenand_base: Adjust indentation inonenand_read_ops_nolockEric Auger <[email protected]>
KVM: arm64: pmu: Don't incrementSW_INCRif PMCR.E is unsetJames Morse <[email protected]>
KVM: arm: Makeinject_abt32()inject an external abort insteadJames Morse <[email protected]>
KVM: arm: Fix DFSR setting for non-LPAE aarch32 guestsGavin Shan <[email protected]>
KVM: arm/arm64: Fix young bit from mmu notifierSuzuki K Poulose <[email protected]>
arm64: ptrace: nofpsimd: Fail FP/SIMD regset operationsSuzuki K Poulose <[email protected]>
arm64: cpufeature: Fix the type of no FP/SIMD capabilityOlof Johansson <[email protected]>
ARM: 8949/1: mm: mark free_memmap as __initEric Auger <[email protected]>
KVM: arm/arm64: vgic-its: Fix restoration of unmapped collectionsShameer Kolothum <[email protected]>
iommu/arm-smmu-v3: Populate VMID field forCMDQ_OP_TLBI_NH_VAAlexey Kardashevskiy <[email protected]>
powerpc/pseries: Allow not having ibm, hypertas-functions::hcall-multi-tce
for DDWTyrel Datwyler <[email protected]>
powerpc/pseries/vio: Fixiommu_tableuse-after-free refcount warningZhengyuan Liu <[email protected]>
tools/power/acpi: fix compilation errorAlexandre Belloni <[email protected]>
ARM: dts: at91: sama5d3: define clock rate range for tcb1Alexandre Belloni <[email protected]>
ARM: dts: at91: sama5d3: fix maximum peripheral clock ratesTero Kristo <[email protected]>
ARM: dts: am43xx: add support for clkout1 clockIngo van Lil <[email protected]>
ARM: dts: at91: Reenable UART TX pull-upsMika Westerberg <[email protected]>
platform/x86:intel_mid_powerbtn: Take a copy of ddataJose Abreu <[email protected]>
ARC: [plat-axs10x]: Add missing multicast filter number to GMAC nodeAndy Shevchenko <[email protected]>
rtc: cmos: Stop using shared IRQPaul Kocialkowski <[email protected]>
rtc: hym8563: Return-EINVALif the time is known to be invalidGeert Uytterhoeven <[email protected]>
spi: spi-mem: Fix inverted logic in op sanity checkBoris Brezillon <[email protected]>
spi: spi-mem: Add extra sanity checks on the op paramBrandon Maier <[email protected]>
gpio: zynq: Report gpio direction at bootShubhrajyoti Datta <[email protected]>
serial: uartps: Add a timeout to the tx empty waitRobert Milkowski <[email protected]>
NFSv4: try lease recovery onNFS4ERR_EXPIREDTrond Myklebust <[email protected]>
NFS/pnfs: Fixpnfs_generic_prepare_to_resend_writes()Trond Myklebust <[email protected]>
NFS: Revalidate the file size on a fatal write errorGeert Uytterhoeven <[email protected]>
nfs:NFS_SWAPshould depend on SWAPLogan Gunthorpe <[email protected]>
PCI: Don't disable bridge BARs when assigning bus resourcesLogan Gunthorpe <[email protected]>
PCI/switchtec: Fixvep_vector_numberioread widthBryan O'Donoghue <[email protected]>
ath10k: pci: Only dumpATH10K_MEM_REGION_TYPE_IOREGwhen safeNavid Emamdoost <[email protected]>
PCI/IOV: Fix memory leak inpci_iov_add_virtfn()Bean Huo <[email protected]>
scsi: ufs: Fixufshcd_probe_hba()reture value in caseufshcd_scsi_add_wlus()failsMichael Guralnik <[email protected]>
RDMA/uverbs: Verify MR access flagsJason Gunthorpe <[email protected]>
RDMA/core: Fix locking inib_uverbs_event_readHåkon Bugge <[email protected]>
RDMA/netlink: Do not always generate an ACK for some netlink operationsJack Morgenstein <[email protected]>
IB/mlx4: Fix memory leak inadd_giderror flowSunil Muthuswamy <[email protected]>
hv_sock: Remove the accept port restrictionRanjani Sridharan <[email protected]>
ASoC: pcm: update FE/BE trigger order based on the command-------------
Diffstat:
Makefile | 4 +- arch/arc/boot/dts/axs10x_mb.dtsi | 1 + arch/arm/boot/dts/am43xx-clocks.dtsi | 54 ++++++++++++++++ arch/arm/boot/dts/at91sam9260.dtsi | 12 ++-- arch/arm/boot/dts/at91sam9261.dtsi | 6 +- arch/arm/boot/dts/at91sam9263.dtsi | 6 +- arch/arm/boot/dts/at91sam9g45.dtsi | 8 +-- arch/arm/boot/dts/at91sam9rl.dtsi | 8 +-- arch/arm/boot/dts/sama5d3.dtsi | 28 ++++----- arch/arm/boot/dts/sama5d3_can.dtsi | 4 +- arch/arm/boot/dts/sama5d3_tcb1.dtsi | 1 + arch/arm/boot/dts/sama5d3_uart.dtsi | 4 +- arch/arm/mm/init.c | 2 +- arch/arm64/kernel/cpufeature.c | 2 +- arch/arm64/kernel/ptrace.c | 21 +++++++ arch/powerpc/platforms/pseries/iommu.c | 43 ++++++++----- arch/powerpc/platforms/pseries/vio.c | 2 + arch/x86/entry/calling.h | 15 ----- arch/x86/entry/entry_32.S | 16 ----- arch/x86/include/asm/frame.h | 49 +++++++++++++++ arch/x86/kernel/ftrace_32.S | 3 + arch/x86/kernel/ftrace_64.S | 3 + drivers/crypto/atmel-sha.c | 7 +-- drivers/crypto/axis/artpec6_crypto.c | 2 +- drivers/gpio/gpio-zynq.c | 23 +++++++ drivers/infiniband/core/addr.c | 2 +- drivers/infiniband/core/sa_query.c | 4 +- drivers/infiniband/core/uverbs_main.c | 32 +++++----- drivers/infiniband/hw/mlx4/main.c | 20 ++++-- drivers/iommu/arm-smmu-v3.c | 1 + drivers/media/i2c/adv748x/adv748x.h | 8 +-- drivers/mtd/nand/onenand/onenand_base.c | 82 ++++++++++++---------- --- drivers/mtd/parsers/sharpslpart.c | 4 +- drivers/net/wireless/ath/ath10k/pci.c | 19 +++++- drivers/net/wireless/marvell/libertas/cfg.c | 2 + drivers/net/wireless/marvell/mwifiex/scan.c | 7 +++ drivers/net/wireless/marvell/mwifiex/wmm.c | 4 ++ drivers/pci/iov.c | 9 ++- drivers/pci/setup-bus.c | 20 ++++-- drivers/pci/switch/switchtec.c | 2 +- drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 4 +- drivers/platform/x86/intel_mid_powerbtn.c | 5 +- drivers/rtc/rtc-cmos.c | 2 +- drivers/rtc/rtc-hym8563.c | 2 +- drivers/scsi/megaraid/megaraid_sas_base.c | 3 +- drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 +- drivers/scsi/megaraid/megaraid_sas_fusion.h | 1 + drivers/scsi/ufs/ufshcd.c | 3 +- drivers/spi/spi-mem.c | 54 ++++++++++++++-- drivers/tty/serial/xilinx_uartps.c | 14 +++-- fs/nfs/Kconfig | 2 +- fs/nfs/direct.c | 4 +- fs/nfs/nfs3xdr.c | 5 +- fs/nfs/nfs4proc.c | 5 ++ fs/nfs/nfs4xdr.c | 5 +- fs/nfs/pnfs_nfs.c | 7 +-- fs/nfs/write.c | 12 +++- include/rdma/ib_verbs.h | 3 + net/vmw_vsock/hyperv_transport.c | 68 +++------------------ sound/soc/soc-pcm.c | 95 +++++++++++++++++++++-------- tools/power/acpi/Makefile.config | 2 +- virt/kvm/arm/aarch32.c | 14 +++-- virt/kvm/arm/mmu.c | 3 +- virt/kvm/arm/pmu.c | 3 + virt/kvm/arm/vgic/vgic-its.c | 3 +- 65 files changed, 562 insertions(+), 300 deletions(-)
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.104 release. There are 52 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 15 Feb 2020 15:16:41 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.104-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.19.y
and the diffstat can be found below.thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.104 release. There are 52 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 15 Feb 2020 15:16:41 +0000. Anything received after that time might be too late.
Build results:
total: 156 pass: 156 fail: 0 Qemu test results: total: 390 pass: 386 fail: 4 Failed tests: arm:xilinx-zynq-a9:multi_v7_defconfig:mem128:zynq-zc702:initrd arm:xilinx-zynq-a9:multi_v7_defconfig:sd:mem128:zynq-zc702:rootfs arm:xilinx-zynq-a9:multi_v7_defconfig:sd:mem128:zynq-zc706:rootfs arm:xilinx-zynq-a9:multi_v7_defconfig:sd:mem128:zynq-zed:rootfs
Failures as reported separately.
Guenter
Greg Kroah-Hartman
maintainerQuoted 20 lines · Guenter Roeck
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.104 release. There are 52 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 15 Feb 2020 15:16:41 +0000. Anything received after that time might be too late.
Build results:
total: 156 pass: 156 fail: 0 Qemu test results: total: 390 pass: 386 fail: 4 Failed tests: arm:xilinx-zynq-a9:multi_v7_defconfig:mem128:zynq-zc702:initrd arm:xilinx-zynq-a9:multi_v7_defconfig:sd:mem128:zynq-zc702:rootfs arm:xilinx-zynq-a9:multi_v7_defconfig:sd:mem128:zynq-zc706:rootfs arm:xilinx-zynq-a9:multi_v7_defconfig:sd:mem128:zynq-zed:rootfs
Quoted 1 line
Failures as reported separately.
-rc2 pushed out with the same serial fix as 4.14.y had, thanks.
greg k-h
Jon Hunter
maintainerQuoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.104 release. There are 52 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 15 Feb 2020 15:16:41 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.104-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.19.y
and the diffstat can be found below.thanks,
greg k-h
All tests are passing for Tegra ...
Test results for stable-v4.19:
11 builds: 11 pass, 0 fail
22 boots: 22 pass, 0 fail
32 tests: 32 pass, 0 failLinux version: 4.19.104-rc1-gf1f9ded7a002
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04Cheers
Jon
Signature · 1 line
nvpublic
Quoted 10 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.104 release. There are 52 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 15 Feb 2020 15:16:41 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.104-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.19.y
and the diffstat can be found below.thanks,
greg k-h
Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.
Summary
------------------------------------------------------------------------
kernel: 4.19.104-rc2
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-4.19.y
git commit: 504347304f1afcbdf2e57fe310584284576989ac
git describe: v4.19.103-54-g504347304f1a
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.19-oe/build/v4.19.103-54-g504347304f1a
No regressions (compared to build v4.19.103)
No fixes (compared to build v4.19.103)
Ran 17237 total tests in the following environments and test suites.
Environments
--------------
- dragonboard-410c - arm64
- hi6220-hikey - arm64
- i386
- juno-r2 - arm64
- nxp-ls2088
- qemu_arm
- qemu_arm64
- qemu_i386
- qemu_x86_64
- x15 - arm
- x86_64
Test Suites
-----------
* build
* install-android-platform-tools-r2600
* kselftest
* libhugetlbfs
* linux-log-parser
* ltp-containers-tests
* ltp-dio-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-cpuhotplug-tests
* ltp-cve-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* network-basic-tests
* perf
* spectre-meltdown-checker-test
* v4l2-compliance
* ltp-open-posix-tests
* kvm-unit-tests
* kselftest-vsyscall-mode-native
* kselftest-vsyscall-mode-none
Signature · 2 lines
Linaro LKFT https://lkft.linaro.org
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.104 release. There are 52 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 15 Feb 2020 15:16:41 +0000. Anything received after that time might be too late.
For v4.19.103-54-g504347304f1a:
Build results:
total: 156 pass: 156 fail: 0 Qemu test results: total: 391 pass: 391 fail: 0
Guenter