Skip to contentSkip to conversation

Add support for Color encoding YCBCR_BT2020

PATCH Superseded Kishore Kadiyala 5 participants 9 messages Feb 14, 2020 – Feb 17, 2020

Subsystems (3)

v1 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add support for Color encoding YCBCR_BT2020

Currently the plane property doesn't have support for YCBCR_BT2020, which enables the corresponding color conversion mode on plane CSC.

---
 drivers/gpu/drm/i915/display/intel_sprite.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_sprite.c +7 -2
index 7abeefe8dce5..5169a7260d7c 100644
@@ -3011,6 +3011,7 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
 	struct intel_plane *plane;
 	enum drm_plane_type plane_type;
 	unsigned int supported_rotations;
+	unsigned int supported_csc;
 	unsigned int possible_crtcs;
 	const u64 *modifiers;
 	const u32 *formats;
@@ -3088,9 +3089,13 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
 					   DRM_MODE_ROTATE_0,
 					   supported_rotations);
 
+	supported_csc = BIT(DRM_COLOR_YCBCR_BT601) | BIT(DRM_COLOR_YCBCR_BT709);
+
+	if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
+		supported_csc |= BIT(DRM_COLOR_YCBCR_BT2020);
+
 	drm_plane_create_color_properties(&plane->base,
-					  BIT(DRM_COLOR_YCBCR_BT601) |
-					  BIT(DRM_COLOR_YCBCR_BT709),
+					  supported_csc,
 					  BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) |
 					  BIT(DRM_COLOR_YCBCR_FULL_RANGE),
 					  DRM_COLOR_YCBCR_BT709,
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer
#1 lore raw
Quoted 2 lines · Kishore Kadiyala

Currently the plane property doesn't have support for YCBCR_BT2020, which enables the corresponding color conversion mode on plane CSC.

Please prefix your patch subjects properly. "drm/i915: " at a minimum for stuff touching i915.

No need to resend for this, but for future reference.

BR,
Jani.

Quoted 35 lines
---
 drivers/gpu/drm/i915/display/intel_sprite.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_sprite.c +7 -2
index 7abeefe8dce5..5169a7260d7c 100644
@@ -3011,6 +3011,7 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
 	struct intel_plane *plane;
 	enum drm_plane_type plane_type;
 	unsigned int supported_rotations;
+	unsigned int supported_csc;
 	unsigned int possible_crtcs;
 	const u64 *modifiers;
 	const u32 *formats;
@@ -3088,9 +3089,13 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
 					   DRM_MODE_ROTATE_0,
 					   supported_rotations);
 
+	supported_csc = BIT(DRM_COLOR_YCBCR_BT601) | BIT(DRM_COLOR_YCBCR_BT709);
+
+	if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
+		supported_csc |= BIT(DRM_COLOR_YCBCR_BT2020);
+
 	drm_plane_create_color_properties(&plane->base,
-					  BIT(DRM_COLOR_YCBCR_BT601) |
-					  BIT(DRM_COLOR_YCBCR_BT709),
+					  supported_csc,
 					  BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) |
 					  BIT(DRM_COLOR_YCBCR_FULL_RANGE),
 					  DRM_COLOR_YCBCR_BT709,
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 10 lines

-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Friday, February 14, 2020 4:56 PM
To: Kadiyala, Kishore <[email protected]>; intel- [email protected]
Cc: Kadiyala, Kishore <[email protected]>
Subject: Re: [Intel-gfx] [PATCH] Add support for Color encoding YCBCR_BT2020

Quoted 6 lines
Quoted 2 lines · Kishore Kadiyala

Currently the plane property doesn't have support for YCBCR_BT2020, which enables the corresponding color conversion mode on plane CSC.

Please prefix your patch subjects properly. "drm/i915: " at a minimum for stuff touching i915.

Sure Jani, I'll include prefix from next time.

Quoted 2 lines

No need to resend for this, but for future reference.

Ok

Regards,
Kishore

Quoted 44 lines

BR,
Jani.

drivers/gpu/drm/i915/display/intel_sprite.c skl_universal_plane_create(struct drm_i915_private

Quoted 13 lines
---
 drivers/gpu/drm/i915/display/intel_sprite.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_sprite.c +0 -0
index 7abeefe8dce5..5169a7260d7c 100644
@@ -3011,6 +3011,7 @@ skl_universal_plane_create(struct drm_i915_private

*dev_priv,

drivers/gpu/drm/i915/display/intel_sprite.c skl_universal_plane_create(struct

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_sprite.c +1 -0
 	struct intel_plane *plane;
 	enum drm_plane_type plane_type;
 	unsigned int supported_rotations;
+	unsigned int supported_csc;
 	unsigned int possible_crtcs;
 	const u64 *modifiers;
 	const u32 *formats;
@@ -3088,9 +3089,13 @@ skl_universal_plane_create(struct

drm_i915_private *dev_priv,

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_sprite.c +1 -0
 					   DRM_MODE_ROTATE_0,
 					   supported_rotations);
 
+	supported_csc = BIT(DRM_COLOR_YCBCR_BT601) |

drivers/gpu/drm/i915/display/intel_sprite.c skl_universal_plane_create(struct drm_i915_private *dev_priv,

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_sprite.c +6 -2
+BIT(DRM_COLOR_YCBCR_BT709);
+
+	if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
+		supported_csc |= BIT(DRM_COLOR_YCBCR_BT2020);
+
 	drm_plane_create_color_properties(&plane->base,
-					  BIT(DRM_COLOR_YCBCR_BT601) |
-					  BIT(DRM_COLOR_YCBCR_BT709),
+					  supported_csc,
 

BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) |

Quoted 1 line
Quoted 5 lines

BIT(DRM_COLOR_YCBCR_FULL_RANGE),

Quoted 1 line

DRM_COLOR_YCBCR_BT709,

--
Jani Nikula, Intel Open Source Graphics Center

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for Color encoding YCBCR_BT2020

In reply to Kishore Kadiyala
== Series Details ==

== Series Details ==

Series: Add support for Color encoding YCBCR_BT2020
URL : https://patchwork.freedesktop.org/series/73457/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7938 -> Patchwork_16568
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/index.html

Known issues
------------

Here are the changes found in Patchwork_16568 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live_gtt:
- fi-skl-6600u: [PASS][1] -> [TIMEOUT][2] ([fdo#111732] / [fdo#112271])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/fi-skl-6600u/igt@i915_selftest@live_gtt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/fi-skl-6600u/igt@i915_selftest@live_gtt.html

#### Possible fixes ####

* igt@gem_close_race@basic-threads:
- fi-byt-n2820: [INCOMPLETE][3] ([i915#45]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/fi-byt-n2820/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/fi-byt-n2820/igt@[email protected]

* igt@gem_exec_parallel@contexts:
- {fi-ehl-1}: [INCOMPLETE][5] ([i915#937]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/fi-ehl-1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/fi-ehl-1/igt@[email protected]

* igt@i915_selftest@live_execlists:
- fi-icl-y: [DMESG-FAIL][7] ([fdo#108569]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/fi-icl-y/igt@i915_selftest@live_execlists.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/fi-icl-y/igt@i915_selftest@live_execlists.html

* igt@i915_selftest@live_gtt:
- fi-bxt-dsi: [TIMEOUT][9] ([fdo#112271]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/fi-bxt-dsi/igt@i915_selftest@live_gtt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/fi-bxt-dsi/igt@i915_selftest@live_gtt.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#111732]: https://bugs.freedesktop.org/show_bug.cgi?id=111732
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#937]: https://gitlab.freedesktop.org/drm/intel/issues/937

Participating hosts (52 -> 44)
------------------------------

Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-cfl-guc fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7938 -> Patchwork_16568

CI-20190529: 20190529
CI_DRM_7938: 9fda6807b50ceb40ef01b055f6428db8965e3d06 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5441: 534ca091fe4ffed916752165bc5becd7ff56cd84 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16568: b4fc9ab087da4ae3bcedf2a5beab580e74273b64 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

b4fc9ab087da Add support for Color encoding YCBCR_BT2020

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
In reply to Kishore Kadiyala
Quoted 22 lines · Kishore Kadiyala

Currently the plane property doesn't have support for YCBCR_BT2020, which enables the corresponding color conversion mode on plane CSC.

---
 drivers/gpu/drm/i915/display/intel_sprite.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_sprite.c +1 -0
index 7abeefe8dce5..5169a7260d7c 100644
@@ -3011,6 +3011,7 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
 	struct intel_plane *plane;
 	enum drm_plane_type plane_type;
 	unsigned int supported_rotations;
+	unsigned int supported_csc;
 	unsigned int possible_crtcs;
 	const u64 *modifiers;
 	const u32 *formats;

drivers/gpu/drm/i915/display/intel_sprite.c skl_universal_plane_create(struct drm_i915_private *dev_priv, · line 3095

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_sprite.c +4 -0
@@ -3088,9 +3089,13 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
 					   DRM_MODE_ROTATE_0,
 					   supported_rotations);
 
+	supported_csc = BIT(DRM_COLOR_YCBCR_BT601) | BIT(DRM_COLOR_YCBCR_BT709);
+
+	if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
+		supported_csc |= BIT(DRM_COLOR_YCBCR_BT2020);

Missing the actual code to enable it on glk and icl+ sdr planes, so this will not work.

IIRC there was also some kind of hw fail related to some BT.something conversions. But I can't remember if that was in the RGB->RGB or YUV->RGB logic.

Also clearly commit 27ee72477c9b ("drm/i915/icl: Handle YCbCr to RGB conversion for BT2020 case") was never actually tested :(

Quoted 15 lines
drivers/gpu/drm/i915/display/intel_sprite.c +2 -2
+
 	drm_plane_create_color_properties(&plane->base,
-					  BIT(DRM_COLOR_YCBCR_BT601) |
-					  BIT(DRM_COLOR_YCBCR_BT709),
+					  supported_csc,
 					  BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) |
 					  BIT(DRM_COLOR_YCBCR_FULL_RANGE),
 					  DRM_COLOR_YCBCR_BT709,
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw
Quoted 38 lines

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Friday, February 14, 2020 6:40 PM
To: Kadiyala, Kishore <[email protected]>
Cc: [email protected]; Shankar, Uma <[email protected]>
Subject: Re: [Intel-gfx] [PATCH] Add support for Color encoding YCBCR_BT2020

drivers/gpu/drm/i915/display/intel_sprite.c skl_universal_plane_create(struct drm_i915_private

Quoted 15 lines · Kishore Kadiyala

Currently the plane property doesn't have support for YCBCR_BT2020, which enables the corresponding color conversion mode on plane CSC.

---
 drivers/gpu/drm/i915/display/intel_sprite.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_sprite.c +0 -0
index 7abeefe8dce5..5169a7260d7c 100644
@@ -3011,6 +3011,7 @@ skl_universal_plane_create(struct drm_i915_private

*dev_priv,

drivers/gpu/drm/i915/display/intel_sprite.c skl_universal_plane_create(struct drm_i915_private

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_sprite.c +1 -0
 	struct intel_plane *plane;
 	enum drm_plane_type plane_type;
 	unsigned int supported_rotations;
+	unsigned int supported_csc;
 	unsigned int possible_crtcs;
 	const u64 *modifiers;
 	const u32 *formats;
@@ -3088,9 +3089,13 @@ skl_universal_plane_create(struct drm_i915_private

*dev_priv,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_sprite.c +0 -0
 					   DRM_MODE_ROTATE_0,
 					   supported_rotations);
 
Quoted 7 lines

drivers/gpu/drm/i915/display/intel_sprite.c skl_universal_plane_create(struct drm_i915_private *dev_priv, · line 3095

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_sprite.c +5 -0
+	supported_csc = BIT(DRM_COLOR_YCBCR_BT601) |
+BIT(DRM_COLOR_YCBCR_BT709);
+
+	if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
+		supported_csc |= BIT(DRM_COLOR_YCBCR_BT2020);

Missing the actual code to enable it on glk and icl+ sdr planes, so this will not work.

Yeah this need to be handled for Non HDR planes.

Quoted 3 lines

IIRC there was also some kind of hw fail related to some BT.something conversions. But I can't remember if that was in the RGB->RGB or
YUV->RGB logic.

Will try to check this out. What kind of fails Ville, was it not all working or artifacts ?

Quoted 2 lines

Also clearly commit 27ee72477c9b ("drm/i915/icl: Handle YCbCr to RGB conversion for BT2020 case") was never actually tested :(

Yeah, this seem to miss the BT2020 export from driver. IGT has the stuff to test this. Will work with Kishore to fix this.

Regards,
Uma Shankar

Quoted 13 lines

drivers/gpu/drm/i915/display/intel_sprite.c skl_universal_plane_create(struct drm_i915_private *dev_priv,

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_sprite.c +2 -2
+
 	drm_plane_create_color_properties(&plane->base,
-					  BIT(DRM_COLOR_YCBCR_BT601) |
-					  BIT(DRM_COLOR_YCBCR_BT709),
+					  supported_csc,
 

BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) |

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_sprite.c +0 -1
 					  BIT(DRM_COLOR_YCBCR_FULL_RANGE),
 					  DRM_COLOR_YCBCR_BT709,
--

2.17.1

Quoted 8 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Ville Syrjälä
Intel

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw
Quoted 46 lines · Uma
Quoted 38 lines

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Friday, February 14, 2020 6:40 PM
To: Kadiyala, Kishore <[email protected]>
Cc: [email protected]; Shankar, Uma <[email protected]>
Subject: Re: [Intel-gfx] [PATCH] Add support for Color encoding YCBCR_BT2020

drivers/gpu/drm/i915/display/intel_sprite.c skl_universal_plane_create(struct drm_i915_private

Quoted 15 lines · Kishore Kadiyala

Currently the plane property doesn't have support for YCBCR_BT2020, which enables the corresponding color conversion mode on plane CSC.

---
 drivers/gpu/drm/i915/display/intel_sprite.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_sprite.c +0 -0
index 7abeefe8dce5..5169a7260d7c 100644
@@ -3011,6 +3011,7 @@ skl_universal_plane_create(struct drm_i915_private

*dev_priv,

drivers/gpu/drm/i915/display/intel_sprite.c skl_universal_plane_create(struct drm_i915_private

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_sprite.c +1 -0
 	struct intel_plane *plane;
 	enum drm_plane_type plane_type;
 	unsigned int supported_rotations;
+	unsigned int supported_csc;
 	unsigned int possible_crtcs;
 	const u64 *modifiers;
 	const u32 *formats;
@@ -3088,9 +3089,13 @@ skl_universal_plane_create(struct drm_i915_private

*dev_priv,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_sprite.c +0 -0
 					   DRM_MODE_ROTATE_0,
 					   supported_rotations);
 
Quoted 7 lines

drivers/gpu/drm/i915/display/intel_sprite.c skl_universal_plane_create(struct drm_i915_private *dev_priv, · line 3095

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_sprite.c +5 -0
+	supported_csc = BIT(DRM_COLOR_YCBCR_BT601) |
+BIT(DRM_COLOR_YCBCR_BT709);
+
+	if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
+		supported_csc |= BIT(DRM_COLOR_YCBCR_BT2020);

Missing the actual code to enable it on glk and icl+ sdr planes, so this will not work.

Quoted 7 lines

Yeah this need to be handled for Non HDR planes.

Quoted 3 lines

IIRC there was also some kind of hw fail related to some BT.something conversions. But I can't remember if that was in the RGB->RGB or
YUV->RGB logic.

Will try to check this out. What kind of fails Ville, was it not all working or artifacts ?

IIRC a wrong coefficient was used in one of the hardcoded hw matrices. Should be listed on the bspec w/a page.

Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw
Quoted 66 lines

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Friday, February 14, 2020 8:03 PM
To: Shankar, Uma <[email protected]>
Cc: Kadiyala, Kishore <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH] Add support for Color encoding YCBCR_BT2020

Quoted 11 lines · Uma
Quoted 11 lines

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Friday, February 14, 2020 6:40 PM
To: Kadiyala, Kishore <[email protected]>
Cc: [email protected]; Shankar, Uma <[email protected]>
Subject: Re: [Intel-gfx] [PATCH] Add support for Color encoding YCBCR_BT2020

Quoted 3 lines
Quoted 3 lines · Kishore Kadiyala
Quoted 2 lines

Currently the plane property doesn't have support for YCBCR_BT2020, which enables the corresponding color conversion mode on

plane CSC.

Quoted 28 lines
Quoted 28 lines
Quoted 13 lines
---
 drivers/gpu/drm/i915/display/intel_sprite.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_sprite.c +0 -0
index 7abeefe8dce5..5169a7260d7c 100644
@@ -3011,6 +3011,7 @@ skl_universal_plane_create(struct
Quoted 1 line

drm_i915_private

*dev_priv,

Quoted 9 lines
drivers/gpu/drm/i915/display/intel_sprite.c +1 -0
 	struct intel_plane *plane;
 	enum drm_plane_type plane_type;
 	unsigned int supported_rotations;
+	unsigned int supported_csc;
 	unsigned int possible_crtcs;
 	const u64 *modifiers;
 	const u32 *formats;
@@ -3088,9 +3089,13 @@ skl_universal_plane_create(struct

drm_i915_private

*dev_priv,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_sprite.c +0 -0
 					   DRM_MODE_ROTATE_0,
 					   supported_rotations);
Quoted 7 lines
Quoted 7 lines

drivers/gpu/drm/i915/display/intel_sprite.c skl_universal_plane_create(struct drm_i915_private *dev_priv, · line 3095

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_sprite.c +5 -0
+	supported_csc = BIT(DRM_COLOR_YCBCR_BT601) |
+BIT(DRM_COLOR_YCBCR_BT709);
+
+	if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
+		supported_csc |= BIT(DRM_COLOR_YCBCR_BT2020);

Missing the actual code to enable it on glk and icl+ sdr planes, so this will not

work.

Quoted 4 lines

Yeah this need to be handled for Non HDR planes.

Quoted 1 line

IIRC there was also some kind of hw fail related to some BT.something

conversions.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

But I can't remember if that was in the RGB->RGB or YUV->RGB logic.

Will try to check this out. What kind of fails Ville, was it not all working or artifacts

?

IIRC a wrong coefficient was used in one of the hardcoded hw matrices. Should be listed on the bspec w/a page.

Able to retrieve that, looks like it's for RGB709 to RGB2020 conversion on SDR planes. So recommendation is not to enable this conversion for SDR planes.

Thanks Ville.

Regards,
Uma Shankar

Quoted 3 lines

--
Ville Syrjälä
Intel

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add support for Color encoding YCBCR_BT2020

In reply to Kishore Kadiyala
== Series Details ==

== Series Details ==

Series: Add support for Color encoding YCBCR_BT2020
URL : https://patchwork.freedesktop.org/series/73457/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7938_full -> Patchwork_16568_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_16568_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_16568_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_16568_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_plane@pixel-format-pipe-a-planes:
- shard-iclb: [PASS][1] -> [FAIL][2] +5 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-iclb3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-iclb2/igt@[email protected]

* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-glk: [PASS][3] -> [FAIL][4] +5 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-glk6/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-glk5/igt@[email protected]
- shard-tglb: [PASS][5] -> [FAIL][6] +6 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-tglb7/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-tglb1/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* {igt@gem_ctx_persistence@close-replace-race}:
- shard-iclb: [PASS][7] -> [FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-iclb8/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-iclb6/igt@[email protected]
- shard-apl: [PASS][9] -> [FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-apl2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-apl8/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_16568_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_busy@close-race:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([i915#977])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-tglb6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-tglb5/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-glk: [PASS][13] -> [FAIL][14] ([i915#232])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-glk3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-glk4/igt@[email protected]

* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#112080]) +10 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-iclb4/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-iclb5/igt@[email protected]

* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#112146]) +5 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-iclb6/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-iclb1/igt@[email protected]

* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [PASS][19] -> [SKIP][20] ([i915#677]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-iclb3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-iclb2/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][21] -> [DMESG-WARN][22] ([i915#716])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-glk8/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-glk5/igt@[email protected]

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([i915#180]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-apl8/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-apl6/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][25] -> [DMESG-WARN][26] ([i915#180]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-kbl3/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-kbl7/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][27] -> [FAIL][28] ([i915#79]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-skl1/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-skl4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#108145]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-skl8/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-skl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][31] -> [FAIL][32] ([fdo#108145] / [i915#265])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-skl10/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-skl5/igt@[email protected]

* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][33] -> [FAIL][34] ([i915#173])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-iclb7/igt@kms_psr@no_drrs.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-iclb1/igt@kms_psr@no_drrs.html

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-iclb4/igt@kms_psr@psr2_sprite_blt.html

* igt@kms_vblank@pipe-c-accuracy-idle:
- shard-apl: [PASS][37] -> [FAIL][38] ([i915#43])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-apl1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-apl1/igt@[email protected]

* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109276]) +10 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-iclb1/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-iclb3/igt@[email protected]

#### Possible fixes ####

* igt@drm_read@fault-buffer:
- shard-snb: [SKIP][41] ([fdo#109271]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-snb4/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-snb2/igt@[email protected]

* igt@gem_exec_schedule@out-order-bsd2:
- shard-iclb: [SKIP][43] ([fdo#109276]) -> [PASS][44] +18 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-iclb3/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][45] ([fdo#112146]) -> [PASS][46] +7 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-iclb1/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-iclb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][47] ([i915#180]) -> [PASS][48] +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-kbl4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-kbl2/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
- shard-skl: [FAIL][49] ([i915#54]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-skl9/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-skl10/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][51] ([i915#79]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-glk2/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-glk9/igt@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-skl: [FAIL][53] ([i915#34]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-skl5/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-skl4/igt@[email protected]

* {igt@kms_hdr@bpc-switch-suspend}:
- shard-apl: [DMESG-WARN][55] ([i915#180]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-apl1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-apl1/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-iclb: [INCOMPLETE][57] ([i915#250]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-iclb3/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-iclb7/igt@[email protected]

* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][59] ([fdo#109441]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-iclb3/igt@kms_psr@psr2_suspend.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-iclb2/igt@kms_psr@psr2_suspend.html

* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-skl: [INCOMPLETE][61] ([i915#69]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-skl10/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-skl3/igt@[email protected]

* igt@perf_pmu@busy-vcs1:
- shard-iclb: [SKIP][63] ([fdo#112080]) -> [PASS][64] +12 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-iclb3/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-iclb4/igt@[email protected]

#### Warnings ####

* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][65] ([fdo#112080]) -> [FAIL][66] ([IGT#28]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-iclb8/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-iclb1/igt@[email protected]

* igt@i915_pm_rpm@gem-execbuf:
- shard-snb: [INCOMPLETE][67] ([i915#82]) -> [SKIP][68] ([fdo#109271])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7938/shard-snb4/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/shard-snb5/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#232]: https://gitlab.freedesktop.org/drm/intel/issues/232
[i915#250]: https://gitlab.freedesktop.org/drm/intel/issues/250
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#977]: https://gitlab.freedesktop.org/drm/intel/issues/977

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7938 -> Patchwork_16568

CI-20190529: 20190529
CI_DRM_7938: 9fda6807b50ceb40ef01b055f6428db8965e3d06 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5441: 534ca091fe4ffed916752165bc5becd7ff56cd84 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16568: b4fc9ab087da4ae3bcedf2a5beab580e74273b64 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16568/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx