Skip to contentSkip to conversation

lib/i915/gem_ring : set the engine to default context

PATCH Superseded Bommu Krishnaiah 3 participants 4 messages Feb 17, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover lib/i915/gem_ring : set the engine to default context

Copy the existing engine map from default context to newly created default context

Bommu Krishnaiah (1):
lib/i915/gem_ring : set the engine to default context

 lib/i915/gem_ring.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Signature · 6 lines
2.25.0.4.g0ad7144999

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

PATCH 1/1 lib/i915/gem_ring : set the engine to default context

Copy the existing engine map from default context to newly created default context

---
 lib/i915/gem_ring.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
lib/i915/gem_ring.c +4 -2
index 99f4741c..c2eae836 100644
@@ -143,11 +143,13 @@ __gem_measure_ring_inflight(int fd, unsigned int engine, enum measure_ring_flags
  * Number of batches that fit in the ring
  */
 unsigned int
-gem_measure_ring_inflight(int fd, unsigned int engine, enum measure_ring_flags flags)
+gem_measure_ring_inflight(int sfd, unsigned int engine, enum measure_ring_flags flags)
 {
 	unsigned int min = ~0u;
+	uint32_t fd;
 
-	fd = gem_reopen_driver(fd);
+	fd = gem_reopen_driver(sfd);
+	gem_context_copy_engines(sfd, 0, fd, 0);
 
 	/* When available, disable execbuf throttling */
 	fcntl(fd, F_SETFD, fcntl(fd, F_GETFD) | O_NONBLOCK);
Signature · 6 lines
2.25.0.4.g0ad7144999

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#2 lore raw

Quoting Bommu Krishnaiah (2020-02-17 05:50:19)

Quoted 16 lines

Copy the existing engine map from default context to newly created default context

---
 lib/i915/gem_ring.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
lib/i915/gem_ring.c +0 -0
index 99f4741c..c2eae836 100644
@@ -143,11 +143,13 @@ __gem_measure_ring_inflight(int fd, unsigned int engine, enum measure_ring_flags
  * Number of batches that fit in the ring
  */

lib/i915/gem_ring.c __gem_measure_ring_inflight(int fd, unsigned int engine, enum measure_ring_flags · line 152

Quoted 10 lines
lib/i915/gem_ring.c +4 -2
 unsigned int
-gem_measure_ring_inflight(int fd, unsigned int engine, enum measure_ring_flags flags)
+gem_measure_ring_inflight(int sfd, unsigned int engine, enum measure_ring_flags flags)
 {
        unsigned int min = ~0u;
+       uint32_t fd;
 
-       fd = gem_reopen_driver(fd);
+       fd = gem_reopen_driver(sfd);
+       gem_context_copy_engines(sfd, 0, fd, 0);

Hah, what happens if engine was ring as intended?
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for lib/i915/gem_ring : set the engine to default context

In reply to Bommu Krishnaiah
== Series Details ==

== Series Details ==

Series: lib/i915/gem_ring : set the engine to default context
URL : https://patchwork.freedesktop.org/series/73514/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7954 -> IGTPW_4162
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4162/index.html

Known issues
------------

Here are the changes found in IGTPW_4162 that come from known issues:

### IGT changes ###

#### Possible fixes ####

* igt@gem_close_race@basic-threads:
- fi-hsw-peppy: [TIMEOUT][1] ([fdo#112271] / [i915#1084]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7954/fi-hsw-peppy/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4162/fi-hsw-peppy/igt@[email protected]
- fi-byt-n2820: [INCOMPLETE][3] ([i915#45]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7954/fi-byt-n2820/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4162/fi-byt-n2820/igt@[email protected]

[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45

Participating hosts (50 -> 46)
------------------------------

Additional (1): fi-ehl-1
Missing (5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5444 -> IGTPW_4162

CI-20190529: 20190529
CI_DRM_7954: d7c1791394faaa869d3442705413dac8c0ecd677 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4162: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4162/index.html
IGT_5444: c46bae259d427f53fcfcd5f05de0181a9e82d6fe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4162/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev