IB/mlx5: Optimize u64 division on 32-bit arches
Subsystems (2)
PATCH 1/1 IB/mlx5: Optimize u64 division on 32-bit arches
Commit f164be8c0366 ("IB/mlx5: Extend caps stage to handle VAR capabilities") introduced a straight "/" division of the u64 variable "bar_size".
This was fixed with commit 685eff513183 ("IB/mlx5: Use div64_u64 for num_var_hw_entries calculation"). However, div64_u64() is redundant here as mlx5_var_table::stride_size is of type u32. Make the actual code way more optimized on 32-bit kernels using div_u64() and fix 80 chars break-through by the way.
calculation")
--- drivers/infiniband/hw/mlx5/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/infiniband/hw/mlx5/main.c +2 -1
@@ -6545,7 +6545,8 @@ static int mlx5_ib_init_var_table(struct mlx5_ib_dev *dev) doorbell_bar_offset); bar_size = (1ULL << log_doorbell_bar_size) *4096 ; var_table->stride_size =1ULL << log_doorbell_stride; - var_table->num_var_hw_entries =div64_u64 (bar_size, var_table->stride_size); + var_table->num_var_hw_entries =div_u64 (bar_size, + var_table->stride_size);mutex_init (&var_table->bitmap_lock); var_table->bitmap =bitmap_zalloc (var_table->num_var_hw_entries,GFP_KERNEL );
Signature · 1 line
2.25.0
Jason Gunthorpe
AppliedQuoted 9 lines · Alexander Lobakin
Commit
f164be8c0366("IB/mlx5: Extend caps stage to handle VAR capabilities") introduced a straight "/" division of the u64 variable "bar_size".
This was fixed with commit685eff513183("IB/mlx5: Usediv64_u64fornum_var_hw_entriescalculation"). However,div64_u64()is redundant here asmlx5_var_table::stride_sizeis of type u32. Make the actual code way more optimized on 32-bit kernels usingdiv_u64()and fix 80 chars break-through by the way.
Quoted 6 lines
Fixes 685eff513183 ("IB/mlx5: Use div64_u64 for num_var_hw_entriescalculation")
Signed-off-by Alexander Lobakin <[email protected]>--- drivers/infiniband/hw/mlx5/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to for-next, thanks
Jason