Skip to contentSkip to conversation

EDAC/mce_amd: Output Scalable MCA processor warning once

PATCH Applied Prarit Bhargava 2 participants 2 messages Feb 17, 2020 – Feb 18, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EDAC/mce_amd: Output Scalable MCA processor warning once

This warning is output for every virtual cpu in a guest on an EPYC 2 system. The warning only needs to be logged one time.

Output the warning only once.

Cc Borislav Petkov <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc Tony Luck <[email protected]>
Cc James Morse <[email protected]>
Cc Robert Richter <[email protected]>
---
 drivers/edac/mce_amd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/edac/mce_amd.c +1 -1
index ea980c556f2e..8874b7722b2f 100644
@@ -1239,7 +1239,7 @@ static int __init mce_amd_init(void)
 
 	case 0x17:
 	case 0x18:
-		pr_warn("Decoding supported only on Scalable MCA processors.\n");
+		pr_warn_once("Decoding supported only on Scalable MCA processors.\n");
 		return -EINVAL;
 
 	default:
Signature · 1 line
2.21.1
maintainer Applied
#1 lore raw
Quoted 22 lines · Prarit Bhargava

This warning is output for every virtual cpu in a guest on an EPYC 2 system. The warning only needs to be logged one time.

Output the warning only once.

Cc Borislav Petkov <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc Tony Luck <[email protected]>
Cc James Morse <[email protected]>
Cc Robert Richter <[email protected]>
---
 drivers/edac/mce_amd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/edac/mce_amd.c +0 -0
index ea980c556f2e..8874b7722b2f 100644

drivers/edac/mce_amd.c static int __init mce_amd_init(void) · line 1245

Quoted 8 lines
drivers/edac/mce_amd.c +1 -1
@@ -1239,7 +1239,7 @@ static int __init mce_amd_init(void)
 
 	case 0x17:
 	case 0x18:
-		pr_warn("Decoding supported only on Scalable MCA processors.\n");
+		pr_warn_once("Decoding supported only on Scalable MCA processors.\n");
 		return -EINVAL;
 
 	default:

Applied, thanks.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette