arm64: dts: imx8qxp-mek: Remove unexisting Ethernet PHY
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 arm64: dts: imx8qxp-mek: Remove unexisting Ethernet PHY
There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek.
Remove the unexisting ethphy1 port.
This fixes a run-time warning:
mdio_bus 5b040000.ethernet-1: MDIO device at address 1 is missing.
--- arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 5 ----- 1 file changed, 5 deletions(-)
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +0 -5
@@ -52,11 +52,6 @@ compatible = "ethernet-phy-ieee802.3-c22"; reg = <0>; }; - - ethphy1: ethernet-phy@1 { - compatible = "ethernet-phy-ieee802.3-c22"; - reg = <1>; - }; }; };
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 10 lines · Fabio Estevam
There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek.
Remove the unexisting ethphy1 port.
This fixes a run-time warning:
mdio_bus5b040000.ethernet-1: MDIO device at address 1 is missing.Fixes fdea904e85e1 ("arm64: dts: imx: add imx8qxp mek support")Signed-off-by Fabio Estevam <[email protected]>
+Andy
I remember that it's possible to get a second ethernet port through a baseboard on imx8qxp. It's not a default option but it's real.
Unless I'm missing something?
Quoted 11 lines
--- arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 5 ----- 1 file changed, 5 deletions(-)arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +0
-0@@ -52,11 +52,6 @@ compatible = "ethernet-phy-ieee802.3-c22";
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts line 57
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +0
-5reg = <0>; }; - - ethphy1: ethernet-phy@1 { - compatible = "ethernet-phy-ieee802.3-c22"; - reg = <1>; - }; }; };
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Leonard Crestez <[email protected]> Sent: Tuesday, February 18, 2020 4:10 AM
Quoted 12 lines · Fabio Estevam
Quoted 10 lines
There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek.
Remove the unexisting ethphy1 port.
This fixes a run-time warning:
mdio_bus5b040000.ethernet-1: MDIO device at address 1 is missing.Fixes fdea904e85e1 ("arm64: dts: imx: add imx8qxp mek support")Signed-off-by Fabio Estevam <[email protected]>
Quoted 6 lines
+Andy
I remember that it's possible to get a second ethernet port through a baseboard on imx8qxp. It's not a default option but it's real.
Unless I'm missing something?
Yes, the phy is attached to second net device that is on baseboard. Because there have pin conflict with esai0, there have another extra dts file for it.
Andy
Quoted 15 lines
Quoted 15 lines
--- arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 5 ----- 1 file changed, 5 deletions(-)arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +0
-1@@ -52,11 +52,6 @@ compatible = "ethernet-phy-ieee802.3-c22"; reg = <0>; }; -
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts line 57
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +0
-4- ethphy1: ethernet-phy@1 { - compatible = "ethernet-phy-ieee802.3-c22"; - reg = <1>; - }; }; };
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Leonard Crestez
Reviewed-byQuoted 15 lines · Andy Duan
From: Leonard Crestez <[email protected]> Sent: Tuesday, February 18, 2020 4:10 AM
Quoted 14 lines · Fabio Estevam
Quoted 10 lines
There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek.
Remove the unexisting ethphy1 port.
This fixes a run-time warning:
mdio_bus5b040000.ethernet-1: MDIO device at address 1 is missing.Fixes fdea904e85e1 ("arm64: dts: imx: add imx8qxp mek support")Signed-off-by Fabio Estevam <[email protected]>+Andy
Quoted 8 lines
Quoted 4 lines
I remember that it's possible to get a second ethernet port through a baseboard on imx8qxp. It's not a default option but it's real.
Unless I'm missing something?
Yes, the phy is attached to second net device that is on baseboard. Because there have pin conflict with esai0, there have another extra dts file for it.
Then it would be reasonable to remove ethphy1 from main dts and add it back in -enet2.dts (which is not yet in upstream)
So Fabio's patch is correct.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
--- arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 5 ----- 1 file changed, 5 deletions(-)
Quoted 16 lines
Quoted 8 lines
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +0
-0@@ -52,11 +52,6 @@ compatible = "ethernet-phy-ieee802.3-c22"; reg = <0>;Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts line 56
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +0
-5}; - - ethphy1: ethernet-phy@1 { - compatible = "ethernet-phy-ieee802.3-c22"; - reg = <1>; - }; }; };
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Shawn Guo
AppliedQuoted 10 lines · Fabio Estevam
There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek.
Remove the unexisting ethphy1 port.
This fixes a run-time warning:
mdio_bus5b040000.ethernet-1: MDIO device at address 1 is missing.Fixes fdea904e85e1 ("arm64: dts: imx: add imx8qxp mek support")Signed-off-by Fabio Estevam <[email protected]>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel