package/libxml2: add upstream security fix for CVE-2019-20388
PATCH v2 1/1 package/libxml2: add upstream security fix for CVE-2019-20388
From: Thomas De Schampheleire <[email protected]>
Fixes CVE-2019-20388: xmlSchemaPreRun in xmlschemas.c in libxml2 2.9.10 allows an xmlSchemaValidateStream memory leak.
---
v2: add sob line inside patch (ThomasP)
...mory-leak-in-xmlSchemaValidateStream.patch | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 package/libxml2/0002-Fix-memory-leak-in-xmlSchemaValidateStream.patch
package/libxml2/0002-Fix-memory-leak-in-xmlSchemaValidateStream.patch new file +35 -0
@@ -0,0 +1,35 @@ +From 7ffcd44d7e6c46704f8af0321d9314cd26e0e18a Mon Sep 17 00:00:00 2001 +From: Zhipeng Xie <[email protected]> +Date: Tue, 20 Aug 2019 16:33:06 +0800 +Subject: [PATCH] Fix memory leak in xmlSchemaValidateStream + +When ctxt->schema is NULL, xmlSchemaSAXPlug->xmlSchemaPreRun +alloc a new schema for ctxt->schema and set vctxt->xsiAssemble +to 1. Then xmlSchemaVStart->xmlSchemaPreRun initialize +vctxt->xsiAssemble to 0 again which cause the alloced schema +can not be freed anymore. + +Found with libFuzzer. + +Signed-off-by: Zhipeng Xie <[email protected]> +[import into Buildroot] +Signed-off-by: Thomas De Schampheleire <[email protected]> +--- + xmlschemas.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/xmlschemas.c b/xmlschemas.c +index 301c8449..39d92182 100644 +--- a/xmlschemas.c ++++ b/xmlschemas.c +@@ -28090,7 +28090,6 @@ xmlSchemaPreRun(xmlSchemaValidCtxtPtr vctxt) { + vctxt->nberrors = 0; + vctxt->depth = -1; + vctxt->skipDepth = -1; +- vctxt->xsiAssemble = 0; + vctxt->hasKeyrefs = 0; + #ifdef ENABLE_IDC_NODE_TABLES_TEST + vctxt->createIDCNodeTables = 1; +-- +2.24.1 +
Signature · 1 line
2.24.1
Thomas Petazzoni
AppliedPATCH v2 1/1 package/libxml2: add upstream security fix for CVE-2019-20388
Quoted 8 lines · On Tue, 18 Feb 2020 10:31:34 +0100 Thomas De Schampheleire…
From: Thomas De Schampheleire <[email protected]>
Fixes CVE-2019-20388: xmlSchemaPreRun in
xmlschemas.cin libxml2 2.9.10 allows an xmlSchemaValidateStream memory leak.Signed-off-by Thomas De Schampheleire <[email protected]>---
v2: add sob line inside patch (ThomasP)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/1 package/libxml2: add upstream security fix for CVE-2019-20388
In reply to Thomas De SchampheleireQuoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas De Schampheleire <[email protected]> writes:
From: Thomas De Schampheleire <[email protected]> Fixes CVE-2019-20388: xmlSchemaPreRun in
xmlschemas.cin libxml2 2.9.10 allows an xmlSchemaValidateStream memory leak.Signed-off-by Thomas De Schampheleire <[email protected]>---
v2: add sob line inside patch (ThomasP)
It would be great if we could start updating <pkg>_IGNORE_CVES for such patches as well, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH v2 1/1 package/libxml2: add upstream security fix for CVE-2019-20388
In reply to Thomas De SchampheleireQuoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas De Schampheleire <[email protected]> writes:
From: Thomas De Schampheleire <[email protected]> Fixes CVE-2019-20388: xmlSchemaPreRun in
xmlschemas.cin libxml2 2.9.10 allows an xmlSchemaValidateStream memory leak.Signed-off-by Thomas De Schampheleire <[email protected]>---
v2: add sob line inside patch (ThomasP)
Committed to 2019.02.x and 2019.11.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard