RDMA/ucma: Use refcount_t for the ctx->ref
PATCH 1/1 RDMA/ucma: Use refcount_t for the ctx->ref
Don't use an atomic as a refcount.
Signed-off-by Jason Gunthorpe <[email protected]>
--- drivers/infiniband/core/ucma.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/infiniband/core/ucma.c +5 -5
@@ -85,7 +85,7 @@ struct ucma_file {struct ucma_context {u32 id;struct completion comp; -atomic_t ref; +refcount_t ref;int events_reported;int backlog;
@@ -152,7 +152,7 @@ static struct ucma_context *ucma_get_ctx(struct ucma_file *file, int id)if (ctx->closing) ctx =ERR_PTR (-EIO );else -atomic_inc (&ctx->ref); +refcount_inc (&ctx->ref); }xa_unlock (&ctx_table);return ctx;
@@ -160,7 +160,7 @@ static struct ucma_context *ucma_get_ctx(struct ucma_file *file, int id)static void ucma_put_ctx (struct ucma_context *ctx) { -if (atomic_dec_and_test (&ctx->ref)) +if (refcount_dec_and_test (&ctx->ref))complete (&ctx->comp); }
@@ -212,7 +212,7 @@ static struct ucma_context *ucma_alloc_ctx(struct ucma_file *file)return NULL ;INIT_WORK (&ctx->close_work, ucma_close_id); -atomic_set (&ctx->ref,1 ); +refcount_set (&ctx->ref,1 );init_completion (&ctx->comp);INIT_LIST_HEAD (&ctx->mc_list); ctx->file = file;
@@ -1502,7 +1502,7 @@ static ssize_t ucma_leave_multicast(struct ucma_file *file, mc =ERR_PTR (-ENOENT ); else if (mc->ctx->file != file) mc =ERR_PTR (-EINVAL ); - else if (!atomic_inc_not_zero(&mc->ctx->ref)) + else if (!refcount_inc_not_zero(&mc->ctx->ref)) mc =ERR_PTR (-ENXIO ); else __xa_erase(&multicast_table, mc->id);
Signature · 1 line
2.25.0
Quoted 7 lines · Jason Gunthorpe
Don't use an atomic as a refcount.
Signed-off-by Jason Gunthorpe <[email protected]>--- drivers/infiniband/core/ucma.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Thanks,
Reviewed-by Leon Romanovsky <[email protected]>
Jason Gunthorpe
AppliedQuoted 7 lines · Jason Gunthorpe
Don't use an atomic as a refcount.
Signed-off-by Jason Gunthorpe <[email protected]>Reviewed-by Leon Romanovsky <[email protected]>--- drivers/infiniband/core/ucma.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Applied
Jason