mmc: sdhci-pci-gli: Enable MSI interrupt for GL975x
PATCH 1/1 mmc: sdhci-pci-gli: Enable MSI interrupt for GL975x
From: Ben Chuang <[email protected]>
Enable MSI interrupt for GL9750/GL9755. Some platforms do not support PCI INTx and devices can not work without interrupt. Like messages below:
[ 4.487132] sdhci-pci 0000:01:00.0: SDHCI controller found [17a0:9755] (rev 0) [ 4.487198] ACPI BIOS Error (bug): Could not resolve symbol [\_SB.PCI0.PBR2._PRT.APS2], AE_NOT_FOUND (20190816/psargs-330) [ 4.487397] ACPI Error: Aborting method \_SB.PCI0.PBR2._PRT due to previous error (AE_NOT_FOUND) (20190816/psparse-529) [ 4.487707] pcieport 0000:00:01.3: can't derive routing for PCI INT A [ 4.487709] sdhci-pci 0000:01:00.0: PCI INT A: no GSI
--- drivers/mmc/host/sdhci-pci-gli.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
drivers/mmc/host/sdhci-pci-gli.c +17 -0
@@ -262,10 +262,26 @@ static int gl9750_execute_tuning(struct sdhci_host *host, u32 opcode)return 0 ; } +static void gli_pcie_enable_msi (struct sdhci_pci_slot *slot) +{ +int ret; + + ret =pci_alloc_irq_vectors (slot->chip->pdev,1 ,1 , +PCI_IRQ_MSI |PCI_IRQ_MSIX ); +if (ret <0 ) { +pr_warn ("%s: enable PCI MSI failed, error=%d\n" , +mmc_hostname (slot->host->mmc), ret); +return ; + } + + slot->host->irq =pci_irq_vector (slot->chip->pdev,0 ); +} +static int gli_probe_slot_gl9750 (struct sdhci_pci_slot *slot) {struct sdhci_host *host = slot->host; +gli_pcie_enable_msi (slot); slot->host->mmc->caps2 |=MMC_CAP2_NO_SDIO ;sdhci_enable_v4_mode (host);
@@ -276,6 +292,7 @@ static int gli_probe_slot_gl9755(struct sdhci_pci_slot *slot) {struct sdhci_host *host = slot->host; +gli_pcie_enable_msi (slot); slot->host->mmc->caps2 |=MMC_CAP2_NO_SDIO ;sdhci_enable_v4_mode (host);
Signature · 1 line
2.25.0
Quoted 49 lines · Ben Chuang
From: Ben Chuang <[email protected]>
Enable MSI interrupt for GL9750/GL9755. Some platforms do not support PCI INTx and devices can not work without interrupt. Like messages below:
[ 4.487132] sdhci-pci 0000:01:00.0: SDHCI controller found [17a0:9755] (rev 0) [ 4.487198] ACPI BIOS Error (bug): Could not resolve symbol [\_SB.PCI0.PBR2._PRT.APS2], AE_NOT_FOUND (20190816/psargs-330) [ 4.487397] ACPI Error: Aborting method \_SB.PCI0.PBR2._PRT due to previous error (AE_NOT_FOUND) (20190816/psparse-529) [ 4.487707] pcieport 0000:00:01.3: can't derive routing for PCI INT A [ 4.487709] sdhci-pci 0000:01:00.0: PCI INT A: no GSISigned-off-by Ben Chuang <[email protected]>--- drivers/mmc/host/sdhci-pci-gli.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)drivers/mmc/host/sdhci-pci-gli.c +16
-0@@ -262,10 +262,26 @@ static int gl9750_execute_tuning(struct sdhci_host *host, u32 opcode)return 0 ; } +static void gli_pcie_enable_msi (struct sdhci_pci_slot *slot) +{ +int ret; + + ret =pci_alloc_irq_vectors (slot->chip->pdev,1 ,1 , +PCI_IRQ_MSI |PCI_IRQ_MSIX ); +if (ret <0 ) { +pr_warn ("%s: enable PCI MSI failed, error=%d\n" , +mmc_hostname (slot->host->mmc), ret); +return ; + } + + slot->host->irq =pci_irq_vector (slot->chip->pdev,0 ); +} +static int gli_probe_slot_gl9750 (struct sdhci_pci_slot *slot) {struct sdhci_host *host = slot->host; +gli_pcie_enable_msi (slot); slot->host->mmc->caps2 |=MMC_CAP2_NO_SDIO ;sdhci_enable_v4_mode (host);
drivers/mmc/host/sdhci-pci-gli.c static int gli_probe_slot_gl9755(struct sdhci_pci_slot *slot) · line 298
Quoted 7 lines
drivers/mmc/host/sdhci-pci-gli.c +1
-0@@ -276,6 +292,7 @@ static int gli_probe_slot_gl9755(struct sdhci_pci_slot *slot) {struct sdhci_host *host = slot->host; +gli_pcie_enable_msi (slot); slot->host->mmc->caps2 |=MMC_CAP2_NO_SDIO ;sdhci_enable_v4_mode (host);
Quoted 7 lines · Ben Chuang
From: Ben Chuang <[email protected]>
Enable MSI interrupt for GL9750/GL9755. Some platforms do not support PCI INTx and devices can not work without interrupt. Like messages below:
Quoted 7 lines
[ 4.487132] sdhci-pci 0000:01:00.0: SDHCI controller found [17a0:9755] (rev 0) [ 4.487198] ACPI BIOS Error (bug): Could not resolve symbol [\_SB.PCI0.PBR2._PRT.APS2], AE_NOT_FOUND (20190816/psargs-330) [ 4.487397] ACPI Error: Aborting method \_SB.PCI0.PBR2._PRT due to previous error (AE_NOT_FOUND) (20190816/psparse-529) [ 4.487707] pcieport 0000:00:01.3: can't derive routing for PCI INT A [ 4.487709] sdhci-pci 0000:01:00.0: PCI INT A: no GSISigned-off-by Ben Chuang <[email protected]>
Applied for fixes and by adding a stable tag, thanks!
Kind regards
Uffe
Quoted 46 lines
--- drivers/mmc/host/sdhci-pci-gli.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)drivers/mmc/host/sdhci-pci-gli.c +17
-1@@ -262,10 +262,26 @@ static int gl9750_execute_tuning(struct sdhci_host *host, u32 opcode)return 0 ; } +static void gli_pcie_enable_msi (struct sdhci_pci_slot *slot) +{ +int ret; + + ret =pci_alloc_irq_vectors (slot->chip->pdev,1 ,1 , +PCI_IRQ_MSI |PCI_IRQ_MSIX ); +if (ret <0 ) { +pr_warn ("%s: enable PCI MSI failed, error=%d\n" , +mmc_hostname (slot->host->mmc), ret); +return ; + } + + slot->host->irq =pci_irq_vector (slot->chip->pdev,0 ); +} +static int gli_probe_slot_gl9750 (struct sdhci_pci_slot *slot) {struct sdhci_host *host = slot->host; +gli_pcie_enable_msi (slot); slot->host->mmc->caps2 |=MMC_CAP2_NO_SDIO ;sdhci_enable_v4_mode (host);@@ -276,6 +292,7 @@ static int gli_probe_slot_gl9755(struct sdhci_pci_slot *slot) {struct sdhci_host *host = slot->host; +gli_pcie_enable_msi (slot); slot->host->mmc->caps2 |=MMC_CAP2_NO_SDIO ;sdhci_enable_v4_mode (host); --2.25.0