Skip to contentSkip to conversation

ARM: dts: imx8qm-apalis: replace dm-spl with dm-pre-proper

PATCH Superseded Igor Opaniuk 2 participants 9 messages Feb 19, 2020 – Mar 11, 2020

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 ARM: dts: imx8qm-apalis: replace dm-spl with dm-pre-proper

From: Igor Opaniuk <[email protected]>

For non-SPL/TPL setups dm-spl, dm-tpl, dm-pre-proper, dm-pre-reloc are handled equally, forcing the nodes with these properties
to be accessible and device being probed
before pre-relocation of U-Boot proper (drivers/core/util.c):

bool ofnode_pre_reloc(ofnode node)

{
    /* for SPL and TPL the remaining nodes after the fdtgrep 1st pass
     * had property dm-pre-reloc or u-boot,dm-spl/tpl.
     * They are removed in final dtb (fdtgrep 2nd pass)
     */
    return true;
    if (ofnode_read_bool(node, "u-boot,dm-pre-reloc"))
        return true;
    if (ofnode_read_bool(node, "u-boot,dm-pre-proper"))
        return true;

    /*
     * In regular builds individual spl and tpl handling both
     * count as handled pre-relocation for later second init.
     */
    if (ofnode_read_bool(node, "u-boot,dm-spl") ||
        ofnode_read_bool(node, "u-boot,dm-tpl"))
        return true;

    return false;
}

Howewer, to avoid confusion in future, replace dm-spl %s/dm-spl/dm-pre-proper/g properties to dm-pre-proper to explicitly state that they are handled during pre-relocation stage of U-Boot proper.

---

 arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi | 62 +++++++++++-----------
 1 file changed, 31 insertions(+), 31 deletions(-)
arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi +31 -31
index 7b1a9550e4..6cdf58c8ad 100644
@@ -4,125 +4,125 @@
  */
 
 &mu {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &clk {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &iomuxc {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio0 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio1 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio2 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio3 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio4 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio5 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio6 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio7 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_conn {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_conn_sdch0 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_conn_sdch1 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_conn_sdch2 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio0 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio1 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio2 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio3 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio4 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio5 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio6 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio7 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &lpuart0 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &lpuart1 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &lpuart2 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &lpuart3 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &usdhc1 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &usdhc2 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &usdhc3 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/4 ARM: dts: imx8qxp-colibri: replace dm-spl with dm-pre-proper

From: Igor Opaniuk <[email protected]>

For non-SPL/TPL setups dm-spl, dm-tpl, dm-pre-proper, dm-pre-reloc are handled equally, forcing the nodes with these properties
to be accessible and device being probed
before pre-relocation of U-Boot proper (drivers/core/util.c):

bool ofnode_pre_reloc(ofnode node)

{
    /* for SPL and TPL the remaining nodes after the fdtgrep 1st pass
     * had property dm-pre-reloc or u-boot,dm-spl/tpl.
     * They are removed in final dtb (fdtgrep 2nd pass)
     */
    return true;
    if (ofnode_read_bool(node, "u-boot,dm-pre-reloc"))
        return true;
    if (ofnode_read_bool(node, "u-boot,dm-pre-proper"))
        return true;

    /*
     * In regular builds individual spl and tpl handling both
     * count as handled pre-relocation for later second init.
     */
    if (ofnode_read_bool(node, "u-boot,dm-spl") ||
        ofnode_read_bool(node, "u-boot,dm-tpl"))
        return true;

    return false;
}

Howewer, to avoid confusion in future, replace dm-spl %s/dm-spl/dm-pre-proper/g properties to dm-pre-proper to explicitly state that they are handled during pre-relocation stage of U-Boot proper.

---

 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi | 56 ++++++++++----------
 1 file changed, 28 insertions(+), 28 deletions(-)
arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi +28 -28
index 5b061f94ba..87de9b5653 100644
@@ -5,113 +5,113 @@
 
 &{/imx8qx-pm} {
 
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &mu {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &clk {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &iomuxc {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio0 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio1 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio2 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio3 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio4 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio5 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio6 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio7 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_conn {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_conn_sdch0 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_conn_sdch1 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &pd_conn_sdch2 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio0 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio1 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio2 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio3 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio4 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio5 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio6 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &gpio7 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &lpuart3 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &usdhc1 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
 
 &usdhc2 {
-	u-boot,dm-spl;
+	u-boot,dm-pre-proper;
 };
Signature · 1 line
2.17.1
#3 lore raw

PATCH 3/4 ARM: dts: imx8qm-apalis: dm-pre-proper for pd_dma nodes

In reply to Igor Opaniuk

From: Igor Opaniuk <[email protected]>

pd_dma_* nodes should be accessible during pre-relocation stage of U-Boot proper for properly handling power domains.

This fixes the issue with permanent failing of invocation of power_domain_get_by_index() in the common code of DM power domain uclass (drivers/power/domain/power-domain-uclass.c).

Fixes f0cc4eae9a ("core: device: use dev_power_domain_on")

---

 arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi +8 -0
index 6cdf58c8ad..956d724979 100644
@@ -51,6 +51,14 @@
 	u-boot,dm-pre-proper;
 };
 
+&pd_dma {
+	u-boot,dm-pre-proper;
+};
+
+&pd_dma_lpuart1 {
+	u-boot,dm-pre-proper;
+};
+
 &pd_conn {
 	u-boot,dm-pre-proper;
 };
Signature · 1 line
2.17.1
#5 lore raw

PATCH 4/4 ARM: dts: imx8qxp-colibri: dm-pre-proper for pd_dma nodes

In reply to Igor Opaniuk

From: Igor Opaniuk <[email protected]>

pd_dma_* nodes should be accessible during pre-relocation stage of U-Boot proper for properly handling power domains.

This fixes the issue with permanent failing of invocation of power_domain_get_by_index() in the common code of DM power domain uclass (drivers/power/domain/power-domain-uclass.c).

Fixes f0cc4eae9a ("core: device: use dev_power_domain_on")

---

 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi +12 -0
index 87de9b5653..322429a98a 100644
@@ -56,6 +56,18 @@
 	u-boot,dm-pre-proper;
 };
 
+&pd_dma {
+	u-boot,dm-pre-proper;
+};
+
+&pd_dma_lpuart0 {
+	u-boot,dm-pre-proper;
+};
+
+&pd_dma_lpuart3 {
+	u-boot,dm-pre-proper;
+};
+
 &pd_conn {
 	u-boot,dm-pre-proper;
 };
Signature · 1 line
2.17.1
#8 lore raw

PATCH 1/4 ARM: dts: imx8qm-apalis: replace dm-spl with dm-pre-proper

In reply to Igor Opaniuk
Quoted 31 lines · Igor Opaniuk

From: Igor Opaniuk <[email protected]>

For non-SPL/TPL setups dm-spl, dm-tpl, dm-pre-proper, dm-pre-reloc are handled equally, forcing the nodes with these properties
to be accessible and device being probed
before pre-relocation of U-Boot proper (drivers/core/util.c):

bool ofnode_pre_reloc(ofnode node)

{
    /* for SPL and TPL the remaining nodes after the fdtgrep 1st pass
     * had property dm-pre-reloc or u-boot,dm-spl/tpl.
     * They are removed in final dtb (fdtgrep 2nd pass)
     */
    return true;
    if (ofnode_read_bool(node, "u-boot,dm-pre-reloc"))
        return true;
    if (ofnode_read_bool(node, "u-boot,dm-pre-proper"))
        return true;

    /*
     * In regular builds individual spl and tpl handling both
     * count as handled pre-relocation for later second init.
     */
    if (ofnode_read_bool(node, "u-boot,dm-spl") ||
        ofnode_read_bool(node, "u-boot,dm-tpl"))
        return true;

    return false;
}
Quoted 6 lines

Howewer, to avoid confusion in future, replace dm-spl %s/dm-spl/dm-pre-proper/g properties to dm-pre-proper to explicitly state that they are handled during pre-relocation stage of U-Boot proper.

Quoted 169 lines

---

 arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi | 62 +++++++++++-----------
 1 file changed, 31 insertions(+), 31 deletions(-)
arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi +31 -32
index 7b1a9550e4..6cdf58c8ad 100644
@@ -4,125 +4,125 @@
  */
 
 &mu {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &clk {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &iomuxc {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio0 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio1 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio2 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio3 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio4 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio5 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio6 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio7 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_conn {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_conn_sdch0 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_conn_sdch1 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_conn_sdch2 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio0 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio1 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio2 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio3 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio4 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio5 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio6 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio7 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &lpuart0 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &lpuart1 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &lpuart2 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &lpuart3 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &usdhc1 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &usdhc2 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &usdhc3 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
--

2.17.1

Signature · 6 lines
Best regards
Oleksandr Suvorov

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
4800 (main line)
#2 lore raw

PATCH 2/4 ARM: dts: imx8qxp-colibri: replace dm-spl with dm-pre-proper

In reply to Igor Opaniuk
Quoted 31 lines · Igor Opaniuk

From: Igor Opaniuk <[email protected]>

For non-SPL/TPL setups dm-spl, dm-tpl, dm-pre-proper, dm-pre-reloc are handled equally, forcing the nodes with these properties
to be accessible and device being probed
before pre-relocation of U-Boot proper (drivers/core/util.c):

bool ofnode_pre_reloc(ofnode node)

{
    /* for SPL and TPL the remaining nodes after the fdtgrep 1st pass
     * had property dm-pre-reloc or u-boot,dm-spl/tpl.
     * They are removed in final dtb (fdtgrep 2nd pass)
     */
    return true;
    if (ofnode_read_bool(node, "u-boot,dm-pre-reloc"))
        return true;
    if (ofnode_read_bool(node, "u-boot,dm-pre-proper"))
        return true;

    /*
     * In regular builds individual spl and tpl handling both
     * count as handled pre-relocation for later second init.
     */
    if (ofnode_read_bool(node, "u-boot,dm-spl") ||
        ofnode_read_bool(node, "u-boot,dm-tpl"))
        return true;

    return false;
}
Quoted 6 lines

Howewer, to avoid confusion in future, replace dm-spl %s/dm-spl/dm-pre-proper/g properties to dm-pre-proper to explicitly state that they are handled during pre-relocation stage of U-Boot proper.

Quoted 154 lines

---

 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi | 56 ++++++++++----------
 1 file changed, 28 insertions(+), 28 deletions(-)
arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi +28 -29
index 5b061f94ba..87de9b5653 100644
@@ -5,113 +5,113 @@
 
 &{/imx8qx-pm} {
 
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &mu {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &clk {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &iomuxc {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio0 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio1 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio2 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio3 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio4 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio5 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio6 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_lsio_gpio7 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_conn {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_conn_sdch0 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_conn_sdch1 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &pd_conn_sdch2 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio0 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio1 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio2 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio3 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio4 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio5 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio6 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &gpio7 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &lpuart3 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &usdhc1 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
 
 &usdhc2 {
-       u-boot,dm-spl;
+       u-boot,dm-pre-proper;
 };
--

2.17.1

Signature · 6 lines
Best regards
Oleksandr Suvorov

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
4800 (main line)
#4 lore raw

PATCH 3/4 ARM: dts: imx8qm-apalis: dm-pre-proper for pd_dma nodes

In reply to Igor Opaniuk
Quoted 6 lines · Igor Opaniuk

From: Igor Opaniuk <[email protected]>

pd_dma_* nodes should be accessible during pre-relocation stage of U-Boot proper for properly handling power domains.

Quoted 6 lines

This fixes the issue with permanent failing of invocation of power_domain_get_by_index() in the common code of DM power domain uclass (drivers/power/domain/power-domain-uclass.c).

Fixes f0cc4eae9a ("core: device: use dev_power_domain_on")
Quoted 27 lines

---

 arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi +8 -1
index 6cdf58c8ad..956d724979 100644
@@ -51,6 +51,14 @@
        u-boot,dm-pre-proper;
 };
 
+&pd_dma {
+       u-boot,dm-pre-proper;
+};
+
+&pd_dma_lpuart1 {
+       u-boot,dm-pre-proper;
+};
+
 &pd_conn {
        u-boot,dm-pre-proper;
 };
--

2.17.1

Signature · 6 lines
Best regards
Oleksandr Suvorov

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
4800 (main line)
#6 lore raw

PATCH 4/4 ARM: dts: imx8qxp-colibri: dm-pre-proper for pd_dma nodes

In reply to Igor Opaniuk
Quoted 6 lines · Igor Opaniuk

From: Igor Opaniuk <[email protected]>

pd_dma_* nodes should be accessible during pre-relocation stage of U-Boot proper for properly handling power domains.

Quoted 6 lines

This fixes the issue with permanent failing of invocation of power_domain_get_by_index() in the common code of DM power domain uclass (drivers/power/domain/power-domain-uclass.c).

Fixes f0cc4eae9a ("core: device: use dev_power_domain_on")
Quoted 31 lines

---

 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi +12 -1
index 87de9b5653..322429a98a 100644
@@ -56,6 +56,18 @@
        u-boot,dm-pre-proper;
 };
 
+&pd_dma {
+       u-boot,dm-pre-proper;
+};
+
+&pd_dma_lpuart0 {
+       u-boot,dm-pre-proper;
+};
+
+&pd_dma_lpuart3 {
+       u-boot,dm-pre-proper;
+};
+
 &pd_conn {
        u-boot,dm-pre-proper;
 };
--

2.17.1

Signature · 6 lines
Best regards
Oleksandr Suvorov

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
4800 (main line)
#7 lore raw

PATCH 4/4 ARM: dts: imx8qxp-colibri: dm-pre-proper for pd_dma nodes

Hi Stefano,

Quoted 54 lines · Oleksandr Suvorov
Quoted 6 lines · Igor Opaniuk

From: Igor Opaniuk <[email protected]>

pd_dma_* nodes should be accessible during pre-relocation stage of U-Boot proper for properly handling power domains.

Quoted 6 lines

This fixes the issue with permanent failing of invocation of power_domain_get_by_index() in the common code of DM power domain uclass (drivers/power/domain/power-domain-uclass.c).

Fixes f0cc4eae9a ("core: device: use dev_power_domain_on")
Quoted 29 lines

---

 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi +12 -1
index 87de9b5653..322429a98a 100644
@@ -56,6 +56,18 @@
        u-boot,dm-pre-proper;
 };
 
+&pd_dma {
+       u-boot,dm-pre-proper;
+};
+
+&pd_dma_lpuart0 {
+       u-boot,dm-pre-proper;
+};
+
+&pd_dma_lpuart3 {
+       u-boot,dm-pre-proper;
+};
+
 &pd_conn {
        u-boot,dm-pre-proper;
 };
--
Quoted 2 lines

2.17.1

--
Best regards
Oleksandr Suvorov

Quoted 3 lines

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500 4800 (main line)

Could you please pull this patch-series for v2020.04, as it fixes broken U-Boot on both Colibri iMX8QXP/Apalis iMX8QM?

Thanks!

Signature · 8 lines
Best regards - Freundliche Gr?sse - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk