Skip to contentSkip to conversation

Btrfs: move all reflink implementation code into its own file

PATCH Superseded [email protected] 2 participants 2 messages Feb 19, 2020 – Feb 20, 2020 Btrfs file system

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 Btrfs: move all reflink implementation code into its own file

From: Filipe Manana <[email protected]>

The reflink code is quite large and has been living in ioctl.c since ever. It has grown over the years after many bug fixes and improvements, and since I'm planning on making some further improvements on it, it's time to get it better organized by moving into its own file, reflink.c (similar to what xfs does for example).

This change only moves the code out of ioctl.c into the new file, it doesn't do any other change.

---
 fs/btrfs/Makefile  |   2 +-
 fs/btrfs/ctree.h   |   2 +
 fs/btrfs/ioctl.c   | 733 --------------------------------------------
 fs/btrfs/reflink.c | 736 +++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 739 insertions(+), 734 deletions(-)
 create mode 100644 fs/btrfs/reflink.c
fs/btrfs/Makefile +1 -1
index 9a0ff3384381..e738f6206ea5 100644
@@ -11,7 +11,7 @@ btrfs-y += super.o ctree.o extent-tree.o print-tree.o root-tree.o dir-item.o \
 	   compression.o delayed-ref.o relocation.o delayed-inode.o scrub.o \
 	   reada.o backref.o ulist.o qgroup.o send.o dev-replace.o raid56.o \
 	   uuid-tree.o props.o free-space-tree.o tree-checker.o space-info.o \
-	   block-rsv.o delalloc-space.o block-group.o discard.o
+	   block-rsv.o delalloc-space.o block-group.o discard.o reflink.o
 
 btrfs-$(CONFIG_BTRFS_FS_POSIX_ACL) += acl.o
 btrfs-$(CONFIG_BTRFS_FS_CHECK_INTEGRITY) += check-integrity.o
fs/btrfs/ctree.h +2 -0
index ffd99c3f64db..7583f2d093e7 100644
@@ -2989,6 +2989,8 @@ int btrfs_dirty_pages(struct inode *inode, struct page **pages,
 		      size_t num_pages, loff_t pos, size_t write_bytes,
 		      struct extent_state **cached);
 int btrfs_fdatawrite_range(struct inode *inode, loff_t start, loff_t end);
+
+/* reflink.c */
 loff_t btrfs_remap_file_range(struct file *file_in, loff_t pos_in,
 			      struct file *file_out, loff_t pos_out,
 			      loff_t len, unsigned int remap_flags);
fs/btrfs/ioctl.c +0 -733

745 lines not on this page · raw message

fs/btrfs/reflink.c new file +736 -0

736 lines not on this page · raw message

Signature · 1 line
2.25.0
Reviewed-by on v1 1/4
#1 lore raw
Quoted 8 lines · On 2/19/20 9:05 AM, [email protected] wrote:

From: Filipe Manana <[email protected]>

The reflink code is quite large and has been living in ioctl.c since ever. It has grown over the years after many bug fixes and improvements, and since I'm planning on making some further improvements on it, it's time to get it better organized by moving into its own file, reflink.c (similar to what xfs does for example).

Quoted 4 lines

This change only moves the code out of ioctl.c into the new file, it doesn't do any other change.

Thanks,

Josef