Skip to contentSkip to conversation

of: property: Add device link support for power-domains and hwlocks

PATCH Applied Saravana Kannan 4 participants 6 messages Feb 20, 2020 – Feb 26, 2020 Device tree

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 of: property: Add device link support for power-domains and hwlocks

Add support for creating device links out of more DT properties.

To: lkml <[email protected]>
To: John Stultz <[email protected]>
To: Rob Herring <[email protected]>

Cc "Rafael J. Wysocki" <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Ulf Hansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Len Brown <[email protected]>
Cc Todd Kjos <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
 drivers/of/property.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/of/property.c +4 -0
index e851c57a15b0..d977c11decda 100644
@@ -1204,6 +1204,8 @@ DEFINE_SIMPLE_PROP(mboxes, "mboxes", "#mbox-cells")
 DEFINE_SIMPLE_PROP(io_channels, "io-channel", "#io-channel-cells")
 DEFINE_SIMPLE_PROP(interrupt_parent, "interrupt-parent", NULL)
 DEFINE_SIMPLE_PROP(dmas, "dmas", "#dma-cells")
+DEFINE_SIMPLE_PROP(power_domains, "power-domains", "#power-domain-cells")
+DEFINE_SIMPLE_PROP(hwlocks, "hwlocks", "#hwlock-cells")
 DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
 DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
 DEFINE_SUFFIX_PROP(gpios, "-gpios", "#gpio-cells")
@@ -1226,6 +1228,8 @@ static const struct supplier_bindings of_supplier_bindings[] = {
 	{ .parse_prop = parse_io_channels, },
 	{ .parse_prop = parse_interrupt_parent, },
 	{ .parse_prop = parse_dmas, },
+	{ .parse_prop = parse_power_domains, },
+	{ .parse_prop = parse_hwlocks, },
 	{ .parse_prop = parse_regulators, },
 	{ .parse_prop = parse_gpio, },
 	{ .parse_prop = parse_gpios, },
Signature · 1 line
2.25.0.265.gbab2e86ba0-goog
Tested-by on v1 1/1
#1 lore raw
Quoted 6 lines · Saravana Kannan

Add support for creating device links out of more DT properties.

To: lkml <[email protected]>
To: John Stultz <[email protected]>
To: Rob Herring <[email protected]>

Just as a heads up, git-send-email doesn't seem to pick up these To:
lines, so I had to dig this out of an archive.

Quoted 12 lines
Cc "Rafael J. Wysocki" <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Ulf Hansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Len Brown <[email protected]>
Cc Todd Kjos <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Quoted 3 lines
---
 drivers/of/property.c | 4 ++++
 1 file changed, 4 insertions(+)

This does seem to work for me, allowing various clk drivers to be used as modules! This removes the functional need for my recent driver core patch series around the deferred_probe_timeout (though the cleanup bits in there may still be worth while).

Thanks for sending it out!
-john

#2 lore raw
Quoted 11 lines · John Stultz
Quoted 6 lines · Saravana Kannan

Add support for creating device links out of more DT properties.

To: lkml <[email protected]>
To: John Stultz <[email protected]>
To: Rob Herring <[email protected]>

Just as a heads up, git-send-email doesn't seem to pick up these To:
lines, so I had to dig this out of an archive.

Weird! Left out the main person who'd care about this patch.

Quoted 17 lines
Quoted 13 lines
Cc "Rafael J. Wysocki" <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Ulf Hansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Len Brown <[email protected]>
Cc Todd Kjos <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Quoted 3 lines
---
 drivers/of/property.c | 4 ++++
 1 file changed, 4 insertions(+)
Quoted 8 lines

This does seem to work for me, allowing various clk drivers to be used as modules! This removes the functional need for my recent driver core patch series around the deferred_probe_timeout (though the cleanup bits in there may still be worth while).

Thanks for sending it out!

Thanks for the Tested-by!

Rob,

Can you pick this up for the next rc?

-Saravana

#3 lore raw
Quoted 40 lines · Saravana Kannan
Quoted 11 lines · John Stultz
Quoted 6 lines · Saravana Kannan

Add support for creating device links out of more DT properties.

To: lkml <[email protected]>
To: John Stultz <[email protected]>
To: Rob Herring <[email protected]>

Just as a heads up, git-send-email doesn't seem to pick up these To:
lines, so I had to dig this out of an archive.

Weird! Left out the main person who'd care about this patch.

Quoted 24 lines
Quoted 13 lines
Cc "Rafael J. Wysocki" <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Ulf Hansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Len Brown <[email protected]>
Cc Todd Kjos <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Quoted 3 lines
---
 drivers/of/property.c | 4 ++++
 1 file changed, 4 insertions(+)

This does seem to work for me, allowing various clk drivers to be used as modules! This removes the functional need for my recent driver core patch series around the deferred_probe_timeout (though the cleanup bits in there may still be worth while).

Quoted 7 lines
Quoted 1 line

Thanks for sending it out!

Thanks for the Tested-by!

Rob,

Can you pick this up for the next rc?

Friendly reminder.

-Saravana

#4 lore raw
Quoted 42 lines · Saravana Kannan
Quoted 40 lines · Saravana Kannan
Quoted 11 lines · John Stultz
Quoted 6 lines · Saravana Kannan

Add support for creating device links out of more DT properties.

To: lkml <[email protected]>
To: John Stultz <[email protected]>
To: Rob Herring <[email protected]>

Just as a heads up, git-send-email doesn't seem to pick up these To:
lines, so I had to dig this out of an archive.

Weird! Left out the main person who'd care about this patch.

Quoted 24 lines
Quoted 13 lines
Cc "Rafael J. Wysocki" <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Ulf Hansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Len Brown <[email protected]>
Cc Todd Kjos <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Quoted 3 lines
---
 drivers/of/property.c | 4 ++++
 1 file changed, 4 insertions(+)

This does seem to work for me, allowing various clk drivers to be used as modules! This removes the functional need for my recent driver core patch series around the deferred_probe_timeout (though the cleanup bits in there may still be worth while).

Quoted 7 lines
Quoted 7 lines
Quoted 1 line

Thanks for sending it out!

Thanks for the Tested-by!

Rob,

Can you pick this up for the next rc?

You mean 5.7-rc1, right?

Quoted 1 line

Friendly reminder.

No need to ping. You can check patchwork[1] to see where you are in the queue.

Rob

[1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/

maintainer Applied
#5 lore raw
In reply to Saravana Kannan
Quoted 17 lines · Saravana Kannan

Add support for creating device links out of more DT properties.

To: lkml <[email protected]>
To: John Stultz <[email protected]>
To: Rob Herring <[email protected]>

Cc "Rafael J. Wysocki" <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Ulf Hansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Len Brown <[email protected]>
Cc Todd Kjos <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Quoted 4 lines
---
 drivers/of/property.c | 4 ++++
 1 file changed, 4 insertions(+)

Applied, thanks.

Rob