Skip to contentSkip to conversation

ARM64: Tegra: Enable I2C controller for EEPROM

PATCH New Jon Hunter 1 participant 4 messages Feb 24, 2020

Subsystems (3)
lore
Share & tools
lore

Jon Hunter

author maintainer
#0 lore raw

PATCH 1/4 ARM64: Tegra: Enable I2C controller for EEPROM

Commit a5b6b67364cb ("arm64: tegra: Add ID EEPROM for Jetson TX1 module") populated the EEPROM on the Jetson TX1 module, but did not enable the corresponding I2C controller. Enable the I2C controller so that this EEPROM can be accessed.

Fixes a5b6b67364cb ("arm64: tegra: Add ID EEPROM for Jetson TX1 module")
---
 arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi +2 -0
index cb58f79deb48..95b1a6e76e6e 100644
@@ -265,6 +265,8 @@
 	};
 
 	i2c@7000c500 {
+		status = "okay";
+
 		/* module ID EEPROM */
 		eeprom@50 {
 			compatible = "atmel,24c02";
Signature · 1 line
2.17.1
author maintainer
#1 lore raw

PATCH 2/4 ARM64: tegra: Add EEPROM supplies

The following warning is observed on Jetson TX1, Jetson Nano and Jetson TX2 platforms because the supply regulators are not specified for the EEPROMs.

WARNING KERN at24 0-0050: 0-0050 supply vcc not found, using dummy regulator WARNING KERN at24 0-0057: 0-0057 supply vcc not found, using dummy regulator

For both of these platforms the EEPROM is powered by the main 1.8V supply rail and so populate the supply for these devices to fix these warnings.

---
 arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts | 1 +
 arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi     | 1 +
 arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi     | 1 +
 arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 1 +
 arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts | 2 ++
 5 files changed, 6 insertions(+)
arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts +1 -0
index d7628f5afb85..961b1be0c56b 100644
@@ -226,6 +226,7 @@
 			compatible = "atmel,24c02";
 			reg = <0x57>;
 
+			vcc-supply = <&vdd_1v8>;
 			address-bits = <8>;
 			page-size = <8>;
 			size = <256>;
arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi +1 -0
index 947744d0f04c..da96de04d003 100644
@@ -171,6 +171,7 @@
 			compatible = "atmel,24c02";
 			reg = <0x50>;
 
+			vcc-supply = <&vdd_1v8>;
 			address-bits = <8>;
 			page-size = <8>;
 			size = <256>;
arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi +1 -0
index 95b1a6e76e6e..f87d2437d11c 100644
@@ -272,6 +272,7 @@
 			compatible = "atmel,24c02";
 			reg = <0x50>;
 
+			vcc-supply = <&vdd_1v8>;
 			address-bits = <8>;
 			page-size = <8>;
 			size = <256>;
arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts +1 -0
index a3cafe39ba4c..c70a610f8e3a 100644
@@ -85,6 +85,7 @@
 			compatible = "atmel,24c02";
 			reg = <0x57>;
 
+			vcc-supply = <&vdd_1v8>;
 			address-bits = <8>;
 			page-size = <8>;
 			size = <256>;
arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts +2 -0
index 848afd855da6..21ed1756b889 100644
@@ -114,6 +114,7 @@
 			compatible = "atmel,24c02";
 			reg = <0x50>;
 
+			vcc-supply = <&vdd_1v8>;
 			address-bits = <8>;
 			page-size = <8>;
 			size = <256>;
@@ -124,6 +125,7 @@
 			compatible = "atmel,24c02";
 			reg = <0x57>;
 
+			vcc-supply = <&vdd_1v8>;
 			address-bits = <8>;
 			page-size = <8>;
 			size = <256>;
Signature · 1 line
2.17.1
author maintainer
#2 lore raw

PATCH 3/4 ARM64: tegra: Fix Tegra186 SOR supply

In reply to Jon Hunter

The following warning is observed on the Jetson TX2 platform ...

WARNING KERN tegra-sor 15540000.sor: 15540000.sor supply \
vdd-hdmi-dp-pll not found, using dummy regulator

The problem is caused because the regulator for the SOR device is missing the '-supply' suffix in Device-Tree. Therefore, add the '-supply' suffix to fix this warning.

Fixes 3fdfaf8718fa arm64: tegra: Enable DP support on Jetson TX2
---
 arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts +1 -1
index 961b1be0c56b..1af7f9ffb7b6 100644
@@ -278,7 +278,7 @@
 			status = "okay";
 
 			avdd-io-hdmi-dp-supply = <&vdd_hdmi_1v05>;
-			vdd-hdmi-dp-pll = <&vdd_1v8_ap>;
+			vdd-hdmi-dp-pll-supply = <&vdd_1v8_ap>;
 
 			nvidia,dpaux = <&dpaux>;
 		};
Signature · 1 line
2.17.1
author maintainer
#3 lore raw

PATCH 4/4 ARM64: tegra: Populate LP8557 backlight regulator

In reply to Jon Hunter

The following warning is observed on Jetson TX1 platform because the supply regulator is not specified for the backlight.

WARNING KERN lp855x 0-002c: 0-002c supply power not found, using dummy regulator

The backlight supply is provided by the 3.3V SYS rail and so add this as the supply for the backlight.

---
 arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts +1 -0
index c70a610f8e3a..ea0e1efa6973 100644
@@ -56,6 +56,7 @@
 		backlight: backlight@2c {
 			compatible = "ti,lp8557";
 			reg = <0x2c>;
+			power-supply = <&vdd_3v3_sys>;
 
 			dev-ctrl = /bits/ 8 <0x80>;
 			init-brt = /bits/ 8 <0xff>;
Signature · 1 line
2.17.1