Skip to contentSkip to conversation

memory: tegra: Correct debugfs clk rate-range on Tegra20

PATCH New Dmitry Osipenko 1 participant 3 messages Feb 24, 2020 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 memory: tegra: Correct debugfs clk rate-range on Tegra20

Correctly set clk rate-range if number of available timings is zero. This fixes noisy "invalid range [4294967295, 0]" error messages during boot.

Fixes 8209eefa3d37 ("memory: tegra: Implement EMC debugfs interface on Tegra20")
---
 drivers/memory/tegra/tegra20-emc.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/memory/tegra/tegra20-emc.c +5 -0
index 313a95fa23d4..eb30484656bc 100644
@@ -637,6 +637,11 @@ static void tegra_emc_debugfs_init(struct tegra_emc *emc)
 			emc->debugfs.max_rate = emc->timings[i].rate;
 	}
 
+	if (!emc->num_timings) {
+		emc->debugfs.min_rate = clk_get_rate(emc->clk);
+		emc->debugfs.max_rate = emc->debugfs.min_rate;
+	}
+
 	err = clk_set_rate_range(emc->clk, emc->debugfs.min_rate,
 				 emc->debugfs.max_rate);
 	if (err < 0) {
Signature · 1 line
2.24.0
#2 lore raw

PATCH 2/3 memory: tegra: Correct debugfs clk rate-range on Tegra30

In reply to a message not in the archive

Correctly set clk rate-range if number of available timings is zero. This fixes noisy "invalid range [4294967295, 0]" error messages during boot.

Fixes 8cee32b40040 ("memory: tegra: Implement EMC debugfs interface on Tegra30")
---
 drivers/memory/tegra/tegra30-emc.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/memory/tegra/tegra30-emc.c +5 -0
index d8372051963f..681fe2dde05d 100644
@@ -1264,6 +1264,11 @@ static void tegra_emc_debugfs_init(struct tegra_emc *emc)
 			emc->debugfs.max_rate = emc->timings[i].rate;
 	}
 
+	if (!emc->num_timings) {
+		emc->debugfs.min_rate = clk_get_rate(emc->clk);
+		emc->debugfs.max_rate = emc->debugfs.min_rate;
+	}
+
 	err = clk_set_rate_range(emc->clk, emc->debugfs.min_rate,
 				 emc->debugfs.max_rate);
 	if (err < 0) {
Signature · 1 line
2.24.0
#3 lore raw

PATCH 3/3 memory: tegra: Correct debugfs clk rate-range on Tegra124

In reply to a message not in the archive

Correctly set clk rate-range if number of available timings is zero. This fixes noisy "invalid range [4294967295, 0]" error messages during boot.

Fixes 6b9acd935546 ("memory: tegra: Refashion EMC debugfs interface on Tegra124")
---
 drivers/memory/tegra/tegra124-emc.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/memory/tegra/tegra124-emc.c +5 -0
index 284b8aa8418c..ac9ca09c7b0d 100644
@@ -1158,6 +1158,11 @@ static void emc_debugfs_init(struct device *dev, struct tegra_emc *emc)
 			emc->debugfs.max_rate = emc->timings[i].rate;
 	}
 
+	if (!emc->num_timings) {
+		emc->debugfs.min_rate = clk_get_rate(emc->clk);
+		emc->debugfs.max_rate = emc->debugfs.min_rate;
+	}
+
 	err = clk_set_rate_range(emc->clk, emc->debugfs.min_rate,
 				 emc->debugfs.max_rate);
 	if (err < 0) {
Signature · 1 line
2.24.0