Skip to contentSkip to conversation

Revert "KVM: x86: enable -Werror"

PATCH In review Christoph Hellwig 3 participants 3 messages Feb 26, 2020 – Feb 27, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "KVM: x86: enable -Werror"

This reverts commit ead68df94d248c80fdbae220ae5425eb5af2e753.

Using the brain dead Werror flag fixes the build for me due to mostly harmless KASAN or similar warnings:

arch/x86/kvm/x86.c: In function ‘kvm_timer_init’:
arch/x86/kvm/x86.c:7209:1: error: the frame size of 1112 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
7209 | }

Feel free to add a CONFIG_WERROR if you care strong enough, but don't break peoples builds for absolutely no good reason.

---
 arch/x86/kvm/Makefile | 1 -
 1 file changed, 1 deletion(-)
arch/x86/kvm/Makefile +0 -1
index 4654e97a05cc..b19ef421084d 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 
 ccflags-y += -Iarch/x86/kvm
-ccflags-y += -Werror
 
 KVM := ../../../virt/kvm
 
Signature · 1 line
2.24.1
#1 lore raw
Quoted 22 lines · Christoph Hellwig

This reverts commit ead68df94d248c80fdbae220ae5425eb5af2e753.

Using the brain dead Werror flag fixes the build for me due to mostly harmless KASAN or similar warnings:

arch/x86/kvm/x86.c: In function ‘kvm_timer_init’:
arch/x86/kvm/x86.c:7209:1: error: the frame size of 1112 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
7209 | }

Feel free to add a CONFIG_WERROR if you care strong enough, but don't break peoples builds for absolutely no good reason.

---
 arch/x86/kvm/Makefile | 1 -
 1 file changed, 1 deletion(-)
arch/x86/kvm/Makefile +0 -0
index 4654e97a05cc..b19ef421084d 100644

arch/x86/kvm/Makefile line 5

Quoted 6 lines
arch/x86/kvm/Makefile +0 -1
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 
 ccflags-y += -Iarch/x86/kvm
-ccflags-y += -Werror
 
 KVM := ../../../virt/kvm

We've had -Werror enabled by default on powerpc for over 10 years, and haven't had many complaints. Possibly that's just because no one builds powerpc kernels ...

The key thing is that it's configurable, so if it does break the build for someone they can just turn it off. It's also off by default for allyes/allmod builds because the user-selectable option disables -Werror, eg:

config PPC_DISABLE_WERROR
bool "Don't build arch/powerpc code with -Werror" help
This option tells the compiler NOT to build the code under arch/powerpc with the -Werror flag (which means warnings are treated as errors).

Only enable this if you are hitting a build failure in the arch/powerpc code caused by a warning, and you don't feel inclined to fix it.

config PPC_WERROR
bool
depends on !PPC_DISABLE_WERROR
default y

In fact these days with shell support in Kconfig we could make it even smarter, eg:

arch/powerpc/Kconfig.debug +1 -0
index 0b063830eea8..e7564f7cabc6 100644
@@ -2,6 +2,7 @@
 
 config PPC_DISABLE_WERROR
        bool "Don't build arch/powerpc code with -Werror"
+       default $(success,whoami | grep hch)
        help
          This option tells the compiler NOT to build the code under
          arch/powerpc with the -Werror flag (which means warnings

cheers

maintainer
#2 lore raw
Quoted 3 lines · Michael Ellerman

We've had -Werror enabled by default on powerpc for over 10 years, and haven't had many complaints. Possibly that's just because no one builds powerpc kernels ...

I looked for other cases of -Werror being always on in Linux before writing this patch. There are both unconditional cases and others like PPC where it's governed by Kconfig.

I will add a Kconfig for now. It probably should be made global instead of having a dozen different Kconfig symbols.

kvm_timer_init should be fixed, though.

Paolo

Quoted 4 lines

The key thing is that it's configurable, so if it does break the build for someone they can just turn it off. It's also off by default for allyes/allmod builds because the user-selectable option disables -Werror, eg: