Skip to contentSkip to conversation

l18n: change EnumerationSeparator for Japanese.

PATCH In review Eiji Tanioka 2 participants 2 messages Feb 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 l18n: change EnumerationSeparator for Japanese.

I grepped source tree and found that 'EnumerationSeparator' is used for multiple IP addresses separation. In these situation, comma is better than "、" in Japanese.
("、" is used for Japanese sentence separator, but separation by comma is more preferable to enumerate ASCII values.)

---
 locales/ja/messages.gotext.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
locales/ja/messages.gotext.json +2 -2
index 3501458..723cb6c 100644
@@ -455,7 +455,7 @@
         {
             "id": "[EnumerationSeparator]",
             "message": "[EnumerationSeparator]",
-            "translation": "、",
+            "translation": ", ",
             "comment": "Inserted between items when listing (e.g. ‘, ’ or ‘、’)"
         },
         {
@@ -1494,4 +1494,4 @@
             ]
         }
     ]
-}
\ No newline at end of file
+}
Signature · 6 lines
2.25.0

_______________________________________________
WireGuard mailing list
[email protected]
https://lists.zx2c4.com/mailman/listinfo/wireguard
#1 lore raw

Arigato!

Rebuilt the zgotext.go file, amended to your commit, and applied to sr/l18n patch.

Regards, Simon

-----Original Message-----
From: WireGuard <[email protected]> on behalf of Eiji Tanioka <[email protected]>
Date: Thursday, 27 February 2020 at 10:43
To: "[email protected]" <[email protected]>
Subject: [PATCH wireguard-windows] l18n: change EnumerationSeparator for Japanese.

    I grepped source tree and found that 'EnumerationSeparator' is used
    for multiple IP addresses separation. In these situation, comma is
    better than "、" in Japanese.
    ("、" is used for Japanese sentence separator, but separation by comma
    is more preferable to enumerate ASCII values.)
    
    Signed-off-by: Eiji Tanioka <[email protected]>
    ---
     locales/ja/messages.gotext.json | 4 ++--
     1 file changed, 2 insertions(+), 2 deletions(-)
    
    diff --git a/locales/ja/messages.gotext.json b/locales/ja/messages.gotext.json
    index 3501458..723cb6c 100644
    --- a/locales/ja/messages.gotext.json
    +++ b/locales/ja/messages.gotext.json
    @@ -455,7 +455,7 @@
             {
                 "id": "[EnumerationSeparator]",
                 "message": "[EnumerationSeparator]",
    -            "translation": "、",
    +            "translation": ", ",
                 "comment": "Inserted between items when listing (e.g. ‘, ’ or ‘、’)"
             },
             {
    @@ -1494,4 +1494,4 @@
                 ]
             }
         ]
    -}
    \ No newline at end of file
    +}
    -- 
    2.25.0
    
    _______________________________________________
    WireGuard mailing list
    [email protected]
    https://lists.zx2c4.com/mailman/listinfo/wireguard

_______________________________________________
WireGuard mailing list
[email protected]
https://lists.zx2c4.com/mailman/listinfo/wireguard