Skip to contentSkip to conversation

RDMA/mlx5: Prevent UMR usage with RO only when we have RO caps

PATCH In review Leon Romanovsky 2 participants 2 messages Feb 27, 2020 – Feb 28, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/mlx5: Prevent UMR usage with RO only when we have RO caps

From: Michael Guralnik <[email protected]>

Relaxed ordering is not supported in UMR so we are disabling UMR usage when user passes relaxed ordering access flag.

Enable using UMR when user requested relaxed ordering but there are no relaxed ordering capabilities.
This will prevent user from unnecessarily registering a new mkey.

Fixes d6de0bb1850f ("RDMA/mlx5: Set relaxed ordering when requested")
---
 drivers/infiniband/hw/mlx5/mlx5_ib.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/infiniband/hw/mlx5/mlx5_ib.h +3 -1
index d9bffcc93587..f21d446249b8 100644
@@ -1532,7 +1532,9 @@ static inline bool mlx5_ib_can_use_umr(struct mlx5_ib_dev *dev,
 	    MLX5_CAP_GEN(dev->mdev, umr_modify_atomic_disabled))
 		return false;
 
-	if (access_flags & IB_ACCESS_RELAXED_ORDERING)
+	if (access_flags & IB_ACCESS_RELAXED_ORDERING &&
+	    (MLX5_CAP_GEN(dev->mdev, relaxed_ordering_write) ||
+	     MLX5_CAP_GEN(dev->mdev, relaxed_ordering_read)))
 		return false;
 
 	return true;
Signature · 1 line
2.24.1
#1 lore raw
Quoted 9 lines · Leon Romanovsky

From: Michael Guralnik <[email protected]>

Relaxed ordering is not supported in UMR so we are disabling UMR usage when user passes relaxed ordering access flag.

Enable using UMR when user requested relaxed ordering but there are no relaxed ordering capabilities.
This will prevent user from unnecessarily registering a new mkey.

Quoted 7 lines
Fixes d6de0bb1850f ("RDMA/mlx5: Set relaxed ordering when requested")
---
 drivers/infiniband/hw/mlx5/mlx5_ib.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

This doesn't seem very rc-ish, applied to for-next

Thanks,
Jason