i3c: master: Replace zero-length array with flexible-array member
PATCH 1/1 i3c: master: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo {
int stuff;
struct boo array[];
};By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
--- drivers/i3c/master/dw-i3c-master.c | 2 +- drivers/i3c/master/i3c-master-cdns.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/i3c/master/dw-i3c-master.c +1 -1
@@ -221,7 +221,7 @@ struct dw_i3c_xfer {struct completion comp;int ret;unsigned int ncmds; -struct dw_i3c_cmd cmds[0 ]; +struct dw_i3c_cmd cmds[]; };struct dw_i3c_master {
drivers/i3c/master/i3c-master-cdns.c +1 -1
@@ -388,7 +388,7 @@ struct cdns_i3c_xfer {struct completion comp;int ret;unsigned int ncmds; -struct cdns_i3c_cmd cmds[0 ]; +struct cdns_i3c_cmd cmds[]; };struct cdns_i3c_data {
Signature · 1 line
2.25.0