pinctrl: core: Remove extra kref_get which blocks hogs being freed
Subsystems (2)
PATCH 1/1 pinctrl: core: Remove extra kref_get which blocks hogs being freed
kref_init starts with the reference count at 1, which will be balanced by the pinctrl_put in pinctrl_unregister. The additional kref_get in pinctrl_claim_hogs will increase this count to 2 and cause the hogs to not get freed when pinctrl_unregister is called.
Fixes 6118714275f0 ("pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable()")
Signed-off-by Charles Keepax <[email protected]>
--- drivers/pinctrl/core.c | 1 - 1 file changed, 1 deletion(-)
drivers/pinctrl/core.c +0 -1
@@ -2021,7 +2021,6 @@ static int pinctrl_claim_hogs(struct pinctrl_dev *pctldev)return PTR_ERR (pctldev->p); } -kref_get (&pctldev->p->users); pctldev->hog_default =pinctrl_lookup_state (pctldev->p,PINCTRL_STATE_DEFAULT );if (IS_ERR (pctldev->hog_default)) {
Signature · 1 line
2.11.0
Quoted 7 lines · Charles Keepax
kref_initstarts with the reference count at 1, which will be balanced by thepinctrl_putinpinctrl_unregister. The additionalkref_getinpinctrl_claim_hogswill increase this count to 2 and cause the hogs to not get freed whenpinctrl_unregisteris called.Fixes 6118714275f0 ("pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable()")Signed-off-by Charles Keepax <[email protected]>
Patch applied for fixes.
Yours,
Linus Walleij