media: imx: Propagate quantization and encoding in CSI
Steve Longerbeam
maintainerPATCH 1/1 media: imx: Propagate quantization and encoding in CSI
Unlike the PRPENC and PRPVF subdevices, the CSI's cannot convert quantization from sink to source, or do any kind of Y'CbCr <-> RGB encoding. So the CSI's cannot allow quantization and ycbcr_enc to be selectable by the user and must be propagated from sink to source.
--- drivers/staging/media/imx/imx-media-csi.c | 2 ++ drivers/staging/media/imx/imx7-media-csi.c | 2 ++ 2 files changed, 4 insertions(+)
drivers/staging/media/imx/imx-media-csi.c +2 -0
@@ -1459,6 +1459,8 @@ static void csi_try_fmt(struct csi_priv *priv,/* propagate colorimetry from sink */ sdformat->format.colorspace = infmt->colorspace; sdformat->format.xfer_func = infmt->xfer_func; + sdformat->format.quantization = infmt->quantization; + sdformat->format.ycbcr_enc = infmt->ycbcr_enc;break ;case CSI_SINK_PAD :
drivers/staging/media/imx/imx7-media-csi.c +2 -0
@@ -1013,6 +1013,8 @@ static int imx7_csi_try_fmt(struct imx7_csi *csi, sdformat->format.colorspace = in_fmt->colorspace; sdformat->format.xfer_func = in_fmt->xfer_func; + sdformat->format.quantization = in_fmt->quantization; + sdformat->format.ycbcr_enc = in_fmt->ycbcr_enc;break ;case IMX7_CSI_PAD_SINK : *cc = imx_media_find_mbus_format(sdformat->format.code,
Signature · 1 line
2.17.1
Quoted 41 lines · Steve Longerbeam
Unlike the PRPENC and PRPVF subdevices, the CSI's cannot convert quantization from sink to source, or do any kind of Y'CbCr <-> RGB encoding. So the CSI's cannot allow quantization and
ycbcr_encto be selectable by the user and must be propagated from sink to source.Fixes 4791bd7d6adc4 ("media: imx: Try colorimetry at both sink and source pads")Reported-by Tim Harvey <[email protected]>Signed-off-by Steve Longerbeam <[email protected]>--- drivers/staging/media/imx/imx-media-csi.c | 2 ++ drivers/staging/media/imx/imx7-media-csi.c | 2 ++ 2 files changed, 4 insertions(+)drivers/staging/media/imx/imx-media-csi.c +2
-0@@ -1459,6 +1459,8 @@ static void csi_try_fmt(struct csi_priv *priv,/* propagate colorimetry from sink */ sdformat->format.colorspace = infmt->colorspace; sdformat->format.xfer_func = infmt->xfer_func; + sdformat->format.quantization = infmt->quantization; + sdformat->format.ycbcr_enc = infmt->ycbcr_enc;break ;case CSI_SINK_PAD :drivers/staging/media/imx/imx7-media-csi.c +2
-1@@ -1013,6 +1013,8 @@ static int imx7_csi_try_fmt(struct imx7_csi *csi, sdformat->format.colorspace = in_fmt->colorspace; sdformat->format.xfer_func = in_fmt->xfer_func; + sdformat->format.quantization = in_fmt->quantization; + sdformat->format.ycbcr_enc = in_fmt->ycbcr_enc;break ;case IMX7_CSI_PAD_SINK : *cc = imx_media_find_mbus_format(sdformat->format.code, --
Quoted 2 lines
2.17.1
Tim
Hi Steve,
Quoted 8 lines · Steve Longerbeam
Unlike the PRPENC and PRPVF subdevices, the CSI's cannot convert quantization from sink to source, or do any kind of Y'CbCr <-> RGB encoding. So the CSI's cannot allow quantization and
ycbcr_encto be selectable by the user and must be propagated from sink to source.Fixes 4791bd7d6adc4 ("media: imx: Try colorimetry at both sink and source pads")Reported-by Tim Harvey <[email protected]>Signed-off-by Steve Longerbeam <[email protected]>
Thanks, for imx7:
------
Cheers,
Rui
Quoted 34 lines
--- drivers/staging/media/imx/imx-media-csi.c | 2 ++ drivers/staging/media/imx/imx7-media-csi.c | 2 ++ 2 files changed, 4 insertions(+)drivers/staging/media/imx/imx-media-csi.c +2
-0@@ -1459,6 +1459,8 @@ static void csi_try_fmt(struct csi_priv *priv,/* propagate colorimetry from sink */ sdformat->format.colorspace = infmt->colorspace; sdformat->format.xfer_func = infmt->xfer_func; + sdformat->format.quantization = infmt->quantization; + sdformat->format.ycbcr_enc = infmt->ycbcr_enc;break ;case CSI_SINK_PAD :drivers/staging/media/imx/imx7-media-csi.c +2
-0@@ -1013,6 +1013,8 @@ static int imx7_csi_try_fmt(struct imx7_csi *csi, sdformat->format.colorspace = in_fmt->colorspace; sdformat->format.xfer_func = in_fmt->xfer_func; + sdformat->format.quantization = in_fmt->quantization; + sdformat->format.ycbcr_enc = in_fmt->ycbcr_enc;break ;case IMX7_CSI_PAD_SINK : *cc = imx_media_find_mbus_format(sdformat->format.code,Signature · 1 line
2.17.1