netfilter: add missing attribute validation
Subsystems (3)
Jakub Kicinski
maintainercover netfilter: add missing attribute validation
Hi!
Netfilter and nf_tables is missing a handful of netlink policy entries.
Compilation tested only.
Jakub Kicinski (3):
netfilter: add missing attribute validation for cthelper
netfilter: add missing attribute validation for payload csum flags
netfilter: nf_tables: add missing attribute validation for tunnels
net/netfilter/nfnetlink_cthelper.c | 2 ++ net/netfilter/nft_payload.c | 1 + net/netfilter/nft_tunnel.c | 2 ++ 3 files changed, 5 insertions(+)
Signature · 1 line
2.24.1
Jakub Kicinski
maintainerPATCH 2/3 netfilter: add missing attribute validation for payload csum flags
Add missing attribute validation for NFTA_PAYLOAD_CSUM_FLAGS to the netlink policy.
--- net/netfilter/nft_payload.c | 1 + 1 file changed, 1 insertion(+)
net/netfilter/nft_payload.c +1 -0
@@ -129,6 +129,7 @@ static const struct nla_policy nft_payload_policy[NFTA_PAYLOAD_MAX + 1] = { [NFTA_PAYLOAD_LEN] = { .type = NLA_U32 }, [NFTA_PAYLOAD_CSUM_TYPE] = { .type = NLA_U32 }, [NFTA_PAYLOAD_CSUM_OFFSET] = { .type = NLA_U32 }, + [NFTA_PAYLOAD_CSUM_FLAGS] = { .type = NLA_U32 }, }; static int nft_payload_init(const struct nft_ctx *ctx,
Signature · 1 line
2.24.1
Jakub Kicinski
maintainerPATCH 3/3 netfilter: nf_tables: add missing attribute validation for tunnels
In reply to Jakub KicinskiAdd missing attribute validation for tunnel source and destination ports to the netlink policy.
--- net/netfilter/nft_tunnel.c | 2 ++ 1 file changed, 2 insertions(+)
net/netfilter/nft_tunnel.c +2 -0
@@ -339,6 +339,8 @@ static const struct nla_policy nft_tunnel_key_policy[NFTA_TUNNEL_KEY_MAX + 1] = [NFTA_TUNNEL_KEY_FLAGS] = { .type = NLA_U32, }, [NFTA_TUNNEL_KEY_TOS] = { .type = NLA_U8, }, [NFTA_TUNNEL_KEY_TTL] = { .type = NLA_U8, }, + [NFTA_TUNNEL_KEY_SPORT] = { .type = NLA_U16, }, + [NFTA_TUNNEL_KEY_DPORT] = { .type = NLA_U16, }, [NFTA_TUNNEL_KEY_OPTS] = { .type = NLA_NESTED, }, };
Signature · 1 line
2.24.1
Jakub Kicinski
maintainerPATCH 1/3 netfilter: add missing attribute validation for cthelper
In reply to Jakub KicinskiAdd missing attribute validation for cthelper
to the netlink policy.
--- net/netfilter/nfnetlink_cthelper.c | 2 ++ 1 file changed, 2 insertions(+)
net/netfilter/nfnetlink_cthelper.c +2 -0
@@ -742,6 +742,8 @@ static const struct nla_policy nfnl_cthelper_policy[NFCTH_MAX+1] = { [NFCTH_NAME ] = { .type =NLA_NUL_STRING , .len = NF_CT_HELPER_NAME_LEN-1 }, [NFCTH_QUEUE_NUM] = { .type = NLA_U32, }, + [NFCTH_PRIV_DATA_LEN] = { .type = NLA_U32, }, + [NFCTH_STATUS] = { .type = NLA_U32, }, };static const struct nfnl_callback nfnl_cthelper_cb[NFNL_MSG_CTHELPER_MAX ] = {
Signature · 1 line
2.24.1
Pablo Neira Ayuso
maintainerQuoted 3 lines · Jakub Kicinski
Hi!
Netfilter and
nf_tablesis missing a handful of netlink policy entries.
Series applied, thank you!