Skip to contentSkip to conversation

configure: change a typo in zstd config

PATCH In review Denis Plotnikov 3 participants 4 messages Mar 3, 2020 – Mar 5, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: change a typo in zstd config

Package manager --exist flag is used instead of --exists. Fix it.

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index 7b373bc0bb..caa65f5883 100755
@@ -2464,7 +2464,7 @@ fi
 # zstd check
 
 if test "$zstd" != "no" ; then
-    if $pkg_config --exist libzstd ; then
+    if $pkg_config --exists libzstd ; then
         zstd_cflags="$($pkg_config --cflags libzstd)"
         zstd_libs="$($pkg_config --libs libzstd)"
         LIBS="$zstd_libs $LIBS"
Signature · 1 line
2.17.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Denis Plotnikov

Package manager --exist flag is used instead of --exists. Fix it.

queued.

thanks.

Quoted 17 lines
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index 7b373bc0bb..caa65f5883 100755
@@ -2464,7 +2464,7 @@ fi
 # zstd check
 
 if test "$zstd" != "no" ; then
-    if $pkg_config --exist libzstd ; then
+    if $pkg_config --exists libzstd ; then
         zstd_cflags="$($pkg_config --cflags libzstd)"
         zstd_libs="$($pkg_config --libs libzstd)"
         LIBS="$zstd_libs $LIBS"
#2 lore raw
Quoted 9 lines · Juan Quintela
Quoted 4 lines · Denis Plotnikov

Package manager --exist flag is used instead of --exists. Fix it.

queued.

It doesn't seem that trivial:
https://www.mail-archive.com/[email protected]/msg684754.html

Quoted 22 lines

thanks.

Quoted 17 lines
---
  configure | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index 7b373bc0bb..caa65f5883 100755
@@ -2464,7 +2464,7 @@ fi
  # zstd check
 
  if test "$zstd" != "no" ; then
-    if $pkg_config --exist libzstd ; then
+    if $pkg_config --exists libzstd ; then
          zstd_cflags="$($pkg_config --cflags libzstd)"
          zstd_libs="$($pkg_config --libs libzstd)"
          LIBS="$zstd_libs $LIBS"
#3 lore raw
Quoted 5 lines · Philippe Mathieu-Daudé
Quoted 4 lines · Juan Quintela
Quoted 3 lines · Denis Plotnikov

Package manager --exist flag is used instead of --exists. Fix it.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

queued.

It doesn't seem that trivial:
https://www.mail-archive.com/[email protected]/msg684754.html

I think you need to do a make clean.

And I found why I didn't catch that problem. Fedora pkg-config is soooo intelligent:

$ pkg-config --exist libzstd; echo $?
0
$ pkg-config --exists libzstd; echo $?
0
$ pkg-config --exists libzstd33; echo $?
1
$ pkg-config --exist libzstd33; echo $?
1
$ 

I tried with libzstd-devel installed and uninstalled, with --enable-zstd and --disable-zstd, and it always did the right thing for me.

Later, Juan.

Quoted 22 lines
Quoted 22 lines

thanks.

Quoted 16 lines
---
  configure | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index 7b373bc0bb..caa65f5883 100755
@@ -2464,7 +2464,7 @@ fi
  # zstd check
    if test "$zstd" != "no" ; then
-    if $pkg_config --exist libzstd ; then
+    if $pkg_config --exists libzstd ; then
          zstd_cflags="$($pkg_config --cflags libzstd)"
          zstd_libs="$($pkg_config --libs libzstd)"
          LIBS="$zstd_libs $LIBS"