Skip to contentSkip to conversation

systemd: Fix service file for race issues

PATCH In review Richard Purdie 3 participants 3 messages Mar 3, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 systemd: Fix service file for race issues

It seems this service needs both Requires: and After: according to the definitions in the systemd docs, else we see boot race failures.

---
 meta/recipes-core/psplash/files/psplash-systemd.service | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/psplash/files/psplash-systemd.service +1 -0
index 249aa540394..4e18980bb27 100644
@@ -2,6 +2,7 @@
 Description=Start psplash-systemd progress communication helper
 DefaultDependencies=no
 After=systemd-start.service
+After=psplash-start.service
 Requires=psplash-start.service
 RequiresMountsFor=/run
 
Signature · 1 line
2.25.0
#1 lore raw

✗ patchtest: failure for systemd: Fix service file for race issues

== Series Details ==

Series: systemd: Fix service file for race issues
Revision: 1
URL : https://patchwork.openembedded.org/series/23063/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at d6b1809e8c)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#2 lore raw
In reply to Richard Purdie

Yeah it's exactly like that, been bitten by that before.

Regards
//Ernst

tis 2020-03-03 klockan 13:05 +0000 skrev Richard Purdie:

It seems this service needs both Requires: and After: according to the definitions

in the systemd docs, else we see boot race failures.

Signed-off-by Richard Purdie <

<mailto:[email protected]>

[email protected]

Quoted 1 line

---

 meta/recipes-core/psplash/files/psplash-systemd.service | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/psplash/files/psplash-systemd.service +0 -0

index 249aa540394..4e18980bb27 100644

--- a/meta/recipes-core/psplash/files/psplash-systemd.service

+++ b/meta/recipes-core/psplash/files/psplash-systemd.service

@@ -2,6 +2,7 @@

Description=Start psplash-systemd progress communication helper

DefaultDependencies=no

After=systemd-start.service

+After=psplash-start.service

Requires=psplash-start.service

RequiresMountsFor=/run

--

2.25.0