Skip to contentSkip to conversation

spi: ath79: remove spi-master setup and cleanup assignment

PATCH New David Bauer 1 participant 1 message Mar 3, 2020 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: ath79: remove spi-master setup and cleanup assignment

This removes the assignment of setup and cleanup functions for the ath79 target. Assigning the setup-method will lead to 'setup_transfer' not being assigned in spi_bitbang_init. Because of this, performing any TX/RX operation will lead to a kernel oops.

Also drop the redundant cleanup assignment, as it's also assigned in spi_bitbang_init.

---
 drivers/spi/spi-ath79.c | 2 --
 1 file changed, 2 deletions(-)
drivers/spi/spi-ath79.c +0 -2
index eb9a243e9526..ae6baaba8a07 100644
@@ -156,8 +156,6 @@ static int ath79_spi_probe(struct platform_device *pdev)
 
 	master->use_gpio_descriptors = true;
 	master->bits_per_word_mask = SPI_BPW_RANGE_MASK(1, 32);
-	master->setup = spi_bitbang_setup;
-	master->cleanup = spi_bitbang_cleanup;
 	if (pdata) {
 		master->bus_num = pdata->bus_num;
 		master->num_chipselect = pdata->num_chipselect;
Signature · 1 line
2.25.1