gianfar: remove unnecessary zeroing coalesce settings
Jakub Kicinski
maintainerPATCH 1/1 gianfar: remove unnecessary zeroing coalesce settings
Core already zeroes out the struct ethtool_coalesce structure, drivers don't have to set every field to 0 individually.
Signed-off-by Jakub Kicinski <[email protected]>
--- .../net/ethernet/freescale/gianfar_ethtool.c | 29 ------------------- 1 file changed, 29 deletions(-)
drivers/net/ethernet/freescale/gianfar_ethtool.c +0 -29
@@ -276,35 +276,6 @@ static int gfar_gcoalesce(struct net_device *dev, cvals->tx_coalesce_usecs =gfar_ticks2usecs (priv, txtime); cvals->tx_max_coalesced_frames = txcount; - cvals->use_adaptive_rx_coalesce =0 ; - cvals->use_adaptive_tx_coalesce =0 ; - - cvals->pkt_rate_low =0 ; - cvals->rx_coalesce_usecs_low =0 ; - cvals->rx_max_coalesced_frames_low =0 ; - cvals->tx_coalesce_usecs_low =0 ; - cvals->tx_max_coalesced_frames_low =0 ; - -/* When the packet rate is below pkt_rate_high but above -* pkt_rate_low (both measured in packets per second) the -* normal {rx,tx}_* coalescing parameters are used. -*/ - -/* When the packet rate is (measured in packets per second) -* is above pkt_rate_high, the {rx,tx}_*_high parameters are -* used. -*/ - cvals->pkt_rate_high =0 ; - cvals->rx_coalesce_usecs_high =0 ; - cvals->rx_max_coalesced_frames_high =0 ; - cvals->tx_coalesce_usecs_high =0 ; - cvals->tx_max_coalesced_frames_high =0 ; - -/* How often to do adaptive coalescing packet rate sampling, -* measured in seconds. Must not be zero. -*/ - cvals->rate_sample_interval =0 ; -return 0 ; }
Signature · 1 line
2.24.1
David Miller
maintainerFrom: Jakub Kicinski <[email protected]>
Date: Tue, 3 Mar 2020 18:26:12 -0800
Quoted 4 lines
Core already zeroes out the struct
ethtool_coalescestructure, drivers don't have to set every field to 0 individually.Signed-off-by Jakub Kicinski <[email protected]>
Looks good, applied, thanks Jakub.