generic/258: check filesystem support for negative timestamps
PATCH 1/1 generic/258: check filesystem support for negative timestamps
Some filesystems do not support negative c/m/atime timestamps. And for these filesystems, generic/258 will fail. Since there's currently no way to check sb->s_time_min from userspace, this patch adds a new common/rc function _require_negative_timestamps() that will _notrun depending on the $FSTYP variable.
---
Hi!
I'm only adding 'ceph' to the _require_negative_timestamps() case because that was the only filesystem with s_time_min = 0 that I was able to test. However, a simple grep indicates there are a few other filesystems that would also be required there (e.g. nfs version < 4).
Cheers,
--
Luis
common/rc | 8 ++++++++ tests/generic/258 | 1 + 2 files changed, 9 insertions(+)
common/rc +8 -0
@@ -4157,6 +4157,14 @@ _check_xfs_scrub_does_unicode() { return 0 } +_require_negative_timestamps() { + case "$FSTYP" in + ceph) + _notrun "$FSTYP does not support negative timestamps" + ;; + esac +} + init_rc ################################################################################
tests/generic/258 +1 -0
@@ -30,6 +30,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15 _supported_fs generic _supported_os Linux _require_test +_require_negative_timestamps TESTFILE=$TEST_DIR/timestamp-test.txt
Quoted 8 lines · Luis Henriques
Some filesystems do not support negative c/m/atime timestamps. And for these filesystems, generic/258 will fail. Since there's currently no way to check
sb->s_time_minfrom userspace, this patch adds a new common/rc function_require_negative_timestamps()that will_notrundepending on the $FSTYP variable.Signed-off-by Luis Henriques <[email protected]>
Looks fine,
Quoted 47 lines
---
Hi!I'm only adding 'ceph' to the
_require_negative_timestamps()case because that was the only filesystem withs_time_min= 0 that I was able to test. However, a simple grep indicates there are a few other filesystems that would also be required there (e.g. nfs version < 4).Cheers,
--
Luiscommon/rc | 8 ++++++++ tests/generic/258 | 1 + 2 files changed, 9 insertions(+)common/rc +8
-0@@ -4157,6 +4157,14 @@ _check_xfs_scrub_does_unicode() { return 0 } +_require_negative_timestamps() { + case "$FSTYP" in + ceph) + _notrun "$FSTYP does not support negative timestamps" + ;; + esac +} + init_rc ################################################################################tests/generic/258 +1
-0@@ -30,6 +30,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15 _supported_fs generic _supported_os Linux _require_test +_require_negative_timestamps TESTFILE=$TEST_DIR/timestamp-test.txt
Quoted 8 lines · Amir Goldstein
Quoted 7 lines · Luis Henriques
Some filesystems do not support negative c/m/atime timestamps. And for these filesystems, generic/258 will fail. Since there's currently no way to check
sb->s_time_minfrom userspace, this patch adds a new common/rc function_require_negative_timestamps()that will_notrundepending on the $FSTYP variable.
Quoted 5 lines
Quoted 1 line
Signed-off-by Luis Henriques <[email protected]>Looks fine,
Reviewed-by Amir Goldstein <[email protected]>
Hi Eryu,
I forgot Cc'ing you in the initial email. Has this patch fell between the cracks, or is it not really acceptable?
Cheers,
--
Luis
Quoted 48 lines
Quoted 48 lines
---
Hi!I'm only adding 'ceph' to the
_require_negative_timestamps()case because that was the only filesystem withs_time_min= 0 that I was able to test. However, a simple grep indicates there are a few other filesystems that would also be required there (e.g. nfs version < 4).Cheers,
--
Luiscommon/rc | 8 ++++++++ tests/generic/258 | 1 + 2 files changed, 9 insertions(+)common/rc +8
-0@@ -4157,6 +4157,14 @@ _check_xfs_scrub_does_unicode() { return 0 } +_require_negative_timestamps() { + case "$FSTYP" in + ceph) + _notrun "$FSTYP does not support negative timestamps" + ;; + esac +} + init_rc ################################################################################tests/generic/258 +1
-0@@ -30,6 +30,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15 _supported_fs generic _supported_os Linux _require_test +_require_negative_timestamps TESTFILE=$TEST_DIR/timestamp-test.txt
Quoted 11 lines · Luis Henriques
Quoted 10 lines · Amir Goldstein
Quoted 8 lines · Luis Henriques
Some filesystems do not support negative c/m/atime timestamps. And for these filesystems, generic/258 will fail. Since there's currently no way to check
sb->s_time_minfrom userspace, this patch adds a new common/rc function_require_negative_timestamps()that will_notrundepending on the $FSTYP variable.Signed-off-by Luis Henriques <[email protected]>
Quoted 8 lines
Quoted 3 lines
Looks fine,
Reviewed-by Amir Goldstein <[email protected]>Hi Eryu,
I forgot Cc'ing you in the initial email. Has this patch fell between the cracks, or is it not really acceptable?
I missed it totally.. Thanks for the heads up! I'll pick it up in this week's update.
Thanks,
Eryu
Quoted 53 lines
Cheers,
--
LuisQuoted 48 lines
Quoted 48 lines
---
Hi!I'm only adding 'ceph' to the
_require_negative_timestamps()case because that was the only filesystem withs_time_min= 0 that I was able to test. However, a simple grep indicates there are a few other filesystems that would also be required there (e.g. nfs version < 4).Cheers,
--
Luiscommon/rc | 8 ++++++++ tests/generic/258 | 1 + 2 files changed, 9 insertions(+)common/rc +8
-0@@ -4157,6 +4157,14 @@ _check_xfs_scrub_does_unicode() { return 0 } +_require_negative_timestamps() { + case "$FSTYP" in + ceph) + _notrun "$FSTYP does not support negative timestamps" + ;; + esac +} + init_rc ################################################################################tests/generic/258 +1
-0@@ -30,6 +30,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15 _supported_fs generic _supported_os Linux _require_test +_require_negative_timestamps TESTFILE=$TEST_DIR/timestamp-test.txt
Quoted 16 lines · Eryu Guan
Quoted 15 lines · Luis Henriques
Quoted 13 lines · Amir Goldstein
Quoted 8 lines · Luis Henriques
Some filesystems do not support negative c/m/atime timestamps. And for these filesystems, generic/258 will fail. Since there's currently no way to check
sb->s_time_minfrom userspace, this patch adds a new common/rc function_require_negative_timestamps()that will_notrundepending on the $FSTYP variable.Signed-off-by Luis Henriques <[email protected]>Looks fine,
Reviewed-by Amir Goldstein <[email protected]>
Quoted 7 lines
Quoted 4 lines
Hi Eryu,
I forgot Cc'ing you in the initial email. Has this patch fell between the cracks, or is it not really acceptable?
I missed it totally.. Thanks for the heads up! I'll pick it up in this week's update.
Great, thanks!
Cheers,
--
Luis
Quoted 57 lines
Thanks,
EryuQuoted 53 lines
Cheers,
--
LuisQuoted 48 lines
Quoted 48 lines
---
Hi!I'm only adding 'ceph' to the
_require_negative_timestamps()case because that was the only filesystem withs_time_min= 0 that I was able to test. However, a simple grep indicates there are a few other filesystems that would also be required there (e.g. nfs version < 4).Cheers,
--
Luiscommon/rc | 8 ++++++++ tests/generic/258 | 1 + 2 files changed, 9 insertions(+)common/rc +8
-0@@ -4157,6 +4157,14 @@ _check_xfs_scrub_does_unicode() { return 0 } +_require_negative_timestamps() { + case "$FSTYP" in + ceph) + _notrun "$FSTYP does not support negative timestamps" + ;; + esac +} + init_rc ################################################################################tests/generic/258 +1
-0@@ -30,6 +30,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15 _supported_fs generic _supported_os Linux _require_test +_require_negative_timestamps TESTFILE=$TEST_DIR/timestamp-test.txt