Skip to contentSkip to conversation

docs: Update for stopping small mbr gap support

PATCH Superseded Michael Chang 3 participants 5 messages Mar 5, 2020 – Mar 6, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docs: Update for stopping small mbr gap support

Further to the discussion about disabling btrfs zstd support for i386-pc[1], this paragraph in manual about mbr gap size doesn't seem to hold true any longer.

"You must ensure that the first partition starts at least 31 KiB (63 sectors) from the start of the disk"

As in many occasions we inevitablely have to provide core image size that goes beyond 31 KiB, this statement becomes a true liability as people would be misguided and think it is still fine to use small MBR gap, that has always been a headache in distribution's upgrade path as growing new feature would render the size requirement bigger but no way for the user to relocate their partitions.

The patch tries to correct the paragraph with a more practical size that works for grub and also for modern computer systems in general.

[1] https://lists.gnu.org/archive/html/grub-devel/2019-11/msg00025.html

---
 docs/grub.texi | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)
docs/grub.texi +14 -6
index 83979af38..651468268 100644
@@ -845,12 +845,20 @@ only be used if the @file{/boot} filesystem is on the same disk that the
 BIOS boots from, so that GRUB does not have to rely on guessing BIOS drive
 numbers.
 
-The GRUB development team generally recommends embedding GRUB before the
-first partition, unless you have special requirements.  You must ensure that
-the first partition starts at least 31 KiB (63 sectors) from the start of
-the disk; on modern disks, it is often a performance advantage to align
-partitions on larger boundaries anyway, so the first partition might start 1
-MiB from the start of the disk.
+The GRUB development team generally recommends embedding GRUB before the first
+partition, unless you have special requirements. You must ensure that the first
+partition starts at least 1 MiB from the start of the disk; on modern disks, it
+is often a performance advantage to align partitions on larger boundaries and 1
+MiB is the least common multiple of many used alignment sizes. For SSD, it
+became crucial to have the partition correctly aligned to avoid excessive
+read-modify-write cycles and thus modern tools set to use 1 MiB as a stardard
+practice.
+
+In case legacy systems that cannot boot if first partition not on the cylinder
+boundary, the fallback blocklist install method should remain working for them
+if the core image growing too much someday. Here we just can't advertise that
+31 KiB (63 sectors) is a sensible size any longer as that would pose great
+constraint to include new features as time goes by.
 
 @heading GPT
 
Signature · 1 line
2.16.4
#1 lore raw
Quoted 7 lines · Michael Chang

Further to the discussion about disabling btrfs zstd support for i386-pc[1], this paragraph in manual about mbr gap size doesn't seem to hold true any longer.

"You must ensure that the first partition starts at least 31 KiB (63 sectors) from the start of the disk"

Quoted 6 lines

As in many occasions we inevitablely have to provide core image size that goes beyond 31 KiB, this statement becomes a true liability as people would be misguided and think it is still fine to use small MBR gap, that has always been a headache in distribution's upgrade path as growing new feature would render the size requirement bigger but no way for the user to relocate their partitions.

Could you split this paragraph into a few sentences? Now it does not read very well...

Quoted 17 lines

The patch tries to correct the paragraph with a more practical size that works for grub and also for modern computer systems in general.

[1] https://lists.gnu.org/archive/html/grub-devel/2019-11/msg00025.html

---
 docs/grub.texi | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)
docs/grub.texi +0 -0
index 83979af38..651468268 100644
@@ -845,12 +845,20 @@ only be used if the @file{/boot} filesystem is on the same disk that the
 BIOS boots from, so that GRUB does not have to rely on guessing BIOS drive
 numbers.

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 850

Quoted 10 lines
docs/grub.texi +3 -6
 
-The GRUB development team generally recommends embedding GRUB before the
-first partition, unless you have special requirements.  You must ensure that
-the first partition starts at least 31 KiB (63 sectors) from the start of
-the disk; on modern disks, it is often a performance advantage to align
-partitions on larger boundaries anyway, so the first partition might start 1
-MiB from the start of the disk.
+The GRUB development team generally recommends embedding GRUB before the first
+partition, unless you have special requirements. You must ensure that the first
+partition starts at least 1 MiB from the start of the disk; on modern disks, it

s/; on modern disks, it/. Additionally, on modern disks it/

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 852

Quoted 2 lines
docs/grub.texi +2 -0
+is often a performance advantage to align partitions on larger boundaries and 1
+MiB is the least common multiple of many used alignment sizes. For SSD, it

s/For SSD, it/E.g. SSD, it/

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 857

Quoted 5 lines
docs/grub.texi +5 -0
+became crucial to have the partition correctly aligned to avoid excessive
+read-modify-write cycles and thus modern tools set to use 1 MiB as a stardard
+practice.
+
+In case legacy systems that cannot boot if first partition not on the cylinder

s/In case legacy/In case of legacy/
s/partition not/partition is not/

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 861

Quoted 4 lines
docs/grub.texi +4 -0
+boundary, the fallback blocklist install method should remain working for them
+if the core image growing too much someday. Here we just can't advertise that
+31 KiB (63 sectors) is a sensible size any longer as that would pose great
+constraint to include new features as time goes by.

Daniel

#2 lore raw

Two small suggestions inlined in the quoted part.

Regards,
ecm

Quoted 48 lines · Daniel Kiper
Quoted 7 lines · Michael Chang

Further to the discussion about disabling btrfs zstd support for i386-pc[1], this paragraph in manual about mbr gap size doesn't seem to hold true any longer.

"You must ensure that the first partition starts at least 31 KiB (63 sectors) from the start of the disk"

Quoted 6 lines

As in many occasions we inevitablely have to provide core image size that goes beyond 31 KiB, this statement becomes a true liability as people would be misguided and think it is still fine to use small MBR gap, that has always been a headache in distribution's upgrade path as growing new feature would render the size requirement bigger but no way for the user to relocate their partitions.

Could you split this paragraph into a few sentences? Now it does not read very well...

Quoted 17 lines

The patch tries to correct the paragraph with a more practical size that works for grub and also for modern computer systems in general.

[1] https://lists.gnu.org/archive/html/grub-devel/2019-11/msg00025.html

---
 docs/grub.texi | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)
docs/grub.texi +0 -0
index 83979af38..651468268 100644
@@ -845,12 +845,20 @@ only be used if the @file{/boot} filesystem is on the same disk that the
 BIOS boots from, so that GRUB does not have to rely on guessing BIOS drive
 numbers.

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 850

Quoted 10 lines
docs/grub.texi +3 -6
 
-The GRUB development team generally recommends embedding GRUB before the
-first partition, unless you have special requirements.  You must ensure that
-the first partition starts at least 31 KiB (63 sectors) from the start of
-the disk; on modern disks, it is often a performance advantage to align
-partitions on larger boundaries anyway, so the first partition might start 1
-MiB from the start of the disk.
+The GRUB development team generally recommends embedding GRUB before the first
+partition, unless you have special requirements. You must ensure that the first
+partition starts at least 1 MiB from the start of the disk; on modern disks, it

s/; on modern disks, it/. Additionally, on modern disks it/

Quoted 8 lines

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 852

Quoted 2 lines
docs/grub.texi +2 -0
+is often a performance advantage to align partitions on larger boundaries and 1
+MiB is the least common multiple of many used alignment sizes. For SSD, it

s/For SSD, it/E.g. SSD, it/

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 855

Quoted 3 lines
docs/grub.texi +3 -0
+became crucial to have the partition correctly aligned to avoid excessive
+read-modify-write cycles and thus modern tools set to use 1 MiB as a stardard
+practice.

s/stardard/standard

Quoted 8 lines

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 857

Quoted 2 lines
docs/grub.texi +2 -0
+
+In case legacy systems that cannot boot if first partition not on the cylinder

s/In case legacy/In case of legacy/
s/partition not/partition is not/

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 859

Quoted 2 lines
docs/grub.texi +2 -0
+boundary, the fallback blocklist install method should remain working for them
+if the core image growing too much someday. Here we just can't advertise that

s/growing/grows/

Quoted 4 lines

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 861

Quoted 2 lines
docs/grub.texi +2 -0
+31 KiB (63 sectors) is a sensible size any longer as that would pose great
+constraint to include new features as time goes by.

Daniel

#4 lore raw
In reply to Daniel Kiper
Quoted 15 lines · Daniel Kiper
Quoted 7 lines · Michael Chang

Further to the discussion about disabling btrfs zstd support for i386-pc[1], this paragraph in manual about mbr gap size doesn't seem to hold true any longer.

"You must ensure that the first partition starts at least 31 KiB (63 sectors) from the start of the disk"

Quoted 6 lines

As in many occasions we inevitablely have to provide core image size that goes beyond 31 KiB, this statement becomes a true liability as people would be misguided and think it is still fine to use small MBR gap, that has always been a headache in distribution's upgrade path as growing new feature would render the size requirement bigger but no way for the user to relocate their partitions.

Quoted 2 lines

Could you split this paragraph into a few sentences? Now it does not read very well...

OK. I'll come up with a better expression next version.

Quoted 19 lines
Quoted 19 lines

The patch tries to correct the paragraph with a more practical size that works for grub and also for modern computer systems in general.

[1] https://lists.gnu.org/archive/html/grub-devel/2019-11/msg00025.html

---
 docs/grub.texi | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)
docs/grub.texi +0 -0
index 83979af38..651468268 100644
@@ -845,12 +845,20 @@ only be used if the @file{/boot} filesystem is on the same disk that the
 BIOS boots from, so that GRUB does not have to rely on guessing BIOS drive
 numbers.
 
Quoted 11 lines

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 850

Quoted 9 lines
docs/grub.texi +3 -6
-The GRUB development team generally recommends embedding GRUB before the
-first partition, unless you have special requirements.  You must ensure that
-the first partition starts at least 31 KiB (63 sectors) from the start of
-the disk; on modern disks, it is often a performance advantage to align
-partitions on larger boundaries anyway, so the first partition might start 1
-MiB from the start of the disk.
+The GRUB development team generally recommends embedding GRUB before the first
+partition, unless you have special requirements. You must ensure that the first
+partition starts at least 1 MiB from the start of the disk; on modern disks, it

s/; on modern disks, it/. Additionally, on modern disks it/

OK.

Quoted 5 lines

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 852

Quoted 3 lines
docs/grub.texi +2 -0
+is often a performance advantage to align partitions on larger boundaries and 1
+MiB is the least common multiple of many used alignment sizes. For SSD, it

s/For SSD, it/E.g. SSD, it/

OK.

Quoted 9 lines

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 857

Quoted 6 lines
docs/grub.texi +5 -0
+became crucial to have the partition correctly aligned to avoid excessive
+read-modify-write cycles and thus modern tools set to use 1 MiB as a stardard
+practice.
+
+In case legacy systems that cannot boot if first partition not on the cylinder

s/In case legacy/In case of legacy/
s/partition not/partition is not/

OK.

Quoted 5 lines

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 861

Quoted 5 lines
docs/grub.texi +4 -0
+boundary, the fallback blocklist install method should remain working for them
+if the core image growing too much someday. Here we just can't advertise that
+31 KiB (63 sectors) is a sensible size any longer as that would pose great
+constraint to include new features as time goes by.

Thanks a lot for taking time to review.

Regards,
Michael

Quoted 7 lines

Daniel

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

#3 lore raw
In reply to C. Masloch
Quoted 60 lines · C. Masloch

Two small suggestions inlined in the quoted part.

Regards,
ecm

Quoted 53 lines · Daniel Kiper
Quoted 7 lines · Michael Chang

Further to the discussion about disabling btrfs zstd support for i386-pc[1], this paragraph in manual about mbr gap size doesn't seem to hold true any longer.

"You must ensure that the first partition starts at least 31 KiB (63 sectors) from the start of the disk"

Quoted 6 lines

As in many occasions we inevitablely have to provide core image size that goes beyond 31 KiB, this statement becomes a true liability as people would be misguided and think it is still fine to use small MBR gap, that has always been a headache in distribution's upgrade path as growing new feature would render the size requirement bigger but no way for the user to relocate their partitions.

Could you split this paragraph into a few sentences? Now it does not read very well...

Quoted 17 lines

The patch tries to correct the paragraph with a more practical size that works for grub and also for modern computer systems in general.

[1] https://lists.gnu.org/archive/html/grub-devel/2019-11/msg00025.html

---
 docs/grub.texi | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)
docs/grub.texi +0 -0
index 83979af38..651468268 100644
@@ -845,12 +845,20 @@ only be used if the @file{/boot} filesystem is on the same disk that the
 BIOS boots from, so that GRUB does not have to rely on guessing BIOS drive
 numbers.

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 850

Quoted 10 lines
docs/grub.texi +3 -6
 
-The GRUB development team generally recommends embedding GRUB before the
-first partition, unless you have special requirements.  You must ensure that
-the first partition starts at least 31 KiB (63 sectors) from the start of
-the disk; on modern disks, it is often a performance advantage to align
-partitions on larger boundaries anyway, so the first partition might start 1
-MiB from the start of the disk.
+The GRUB development team generally recommends embedding GRUB before the first
+partition, unless you have special requirements. You must ensure that the first
+partition starts at least 1 MiB from the start of the disk; on modern disks, it

s/; on modern disks, it/. Additionally, on modern disks it/

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 852

Quoted 2 lines
docs/grub.texi +2 -0
+is often a performance advantage to align partitions on larger boundaries and 1
+MiB is the least common multiple of many used alignment sizes. For SSD, it

s/For SSD, it/E.g. SSD, it/

Quoted 5 lines
Quoted 3 lines

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 855

Quoted 3 lines
docs/grub.texi +3 -0
+became crucial to have the partition correctly aligned to avoid excessive
+read-modify-write cycles and thus modern tools set to use 1 MiB as a stardard
+practice.

s/stardard/standard

OK.

Quoted 11 lines
Quoted 9 lines

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 857

Quoted 3 lines
docs/grub.texi +2 -0
+
+In case legacy systems that cannot boot if first partition not on the cylinder

s/In case legacy/In case of legacy/
s/partition not/partition is not/

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 859

Quoted 2 lines
docs/grub.texi +2 -0
+boundary, the fallback blocklist install method should remain working for them
+if the core image growing too much someday. Here we just can't advertise that

s/growing/grows/

OK.

Many thanks for the review. :)

Regards,
Michael

Quoted 10 lines
Quoted 5 lines

docs/grub.texi only be used if the @file{/boot} filesystem is on the same disk that the · line 861

Quoted 3 lines
docs/grub.texi +2 -0
+31 KiB (63 sectors) is a sensible size any longer as that would pose great
+constraint to include new features as time goes by.

Daniel

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel