Skip to contentSkip to conversation

igc: Fix default MAC address filter override

PATCH New Andre Guedes 2 participants 2 messages Mar 9, 2020 – Mar 19, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 igc: Fix default MAC address filter override

This patch fixes a bug when the user adds the first MAC address filter via ethtool NFC mechanism.

When the first MAC address filter is added, it overwrites the default MAC address filter configured at RAL[0] and RAH[0]. As consequence, frames addressed to the interface MAC address are not sent to host anymore.

This patch fixes the bug by calling igc_set_default_mac_filter() during adapter init so the position 0 of adapter->mac_table[] is assigned to the default MAC address.

---
 drivers/net/ethernet/intel/igc/igc_main.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/intel/igc/igc_main.c +2 -0
index 025f2e439aef..3ddea16ec1da 100644
@@ -2350,7 +2350,9 @@ static void igc_configure(struct igc_adapter *adapter)
 	igc_setup_mrqc(adapter);
 	igc_setup_rctl(adapter);
 
+	igc_set_default_mac_filter(adapter);
 	igc_nfc_filter_restore(adapter);
+
 	igc_configure_tx(adapter);
 	igc_configure_rx(adapter);
 
Signature · 1 line
2.25.0
#1 lore raw

PATCH 1/1 igc: Fix default MAC address filter override

Quoted 14 lines

From: Intel-wired-lan <[email protected]> On Behalf Of Andre Guedes
Sent: Monday, March 9, 2020 4:11 PM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH] igc: Fix default MAC address filter override

This patch fixes a bug when the user adds the first MAC address filter via ethtool NFC mechanism.

When the first MAC address filter is added, it overwrites the default MAC address filter configured at RAL[0] and RAH[0]. As consequence, frames addressed to the interface MAC address are not sent to host anymore.

Quoted 8 lines

This patch fixes the bug by calling igc_set_default_mac_filter() during adapter init so the position 0 of adapter->mac_table[] is assigned to the default MAC address.

---
 drivers/net/ethernet/intel/igc/igc_main.c | 2 ++
 1 file changed, 2 insertions(+)