Skip to contentSkip to conversation

drm/i915/tgl: WaEnablePreemptionGranularityControlByUMD

PATCH In review Tvrtko Ursulin 4 participants 4 messages Mar 10, 2020 – Mar 11, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/tgl: WaEnablePreemptionGranularityControlByUMD

From: Tvrtko Ursulin <[email protected]>

Certain workloads need the ability to disable preemption completely so allow them to do that by whitelisting GEN8_CS_CHICKEN1.

Cc Michal Mrozek <[email protected]>
Cc Tony Ye <[email protected]>
Cc Rafael Antognolli <[email protected]>
Cc Jason Ekstrand <[email protected]>

---
We need confirmation and acks from all three userspace components here. Especially since my impression was some are for and some were against whitelisting this one.

---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/gt/intel_workarounds.c +3 -0
index 391f39b1fb26..37becdf77427 100644
@@ -1276,6 +1276,9 @@ static void tgl_whitelist_build(struct intel_engine_cs *engine)
 
 		/* Wa_1806527549:tgl */
 		whitelist_reg(w, HIZ_CHICKEN);
+
+		/* WaEnablePreemptionGranularityControlByUMD:tgl */
+		whitelist_reg(w, GEN8_CS_CHICKEN1);
 		break;
 	default:
 		break;
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/tgl: WaEnablePreemptionGranularityControlByUMD

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: drm/i915/tgl: WaEnablePreemptionGranularityControlByUMD
URL : https://patchwork.freedesktop.org/series/74494/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_8108 -> Patchwork_16902
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_16902 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_16902, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16902/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_16902:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@coherency:
- fi-gdg-551: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8108/fi-gdg-551/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16902/fi-gdg-551/igt@i915_selftest@[email protected]

Known issues
------------

Here are the changes found in Patchwork_16902 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [PASS][3] -> [FAIL][4] ([CI#94])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8108/fi-tgl-y/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16902/fi-tgl-y/igt@[email protected]

* igt@i915_selftest@live@gem_contexts:
- fi-cml-s: [PASS][5] -> [DMESG-FAIL][6] ([i915#877])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8108/fi-cml-s/igt@i915_selftest@live@gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16902/fi-cml-s/igt@i915_selftest@live@gem_contexts.html
- fi-cfl-guc: [PASS][7] -> [DMESG-FAIL][8] ([i915#623])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8108/fi-cfl-guc/igt@i915_selftest@live@gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16902/fi-cfl-guc/igt@i915_selftest@live@gem_contexts.html

* igt@kms_addfb_basic@addfb25-bad-modifier:
- fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([CI#94] / [i915#402])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8108/fi-tgl-y/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16902/fi-tgl-y/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][11] -> [FAIL][12] ([fdo#111096] / [i915#323])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8108/fi-kbl-7500u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16902/fi-kbl-7500u/igt@[email protected]

#### Possible fixes ####

* igt@kms_addfb_basic@bad-pitch-0:
- fi-tgl-y: [DMESG-WARN][13] ([CI#94] / [i915#402]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8108/fi-tgl-y/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16902/fi-tgl-y/igt@[email protected]

[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#623]: https://gitlab.freedesktop.org/drm/intel/issues/623
[i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877

Participating hosts (50 -> 43)
------------------------------

Additional (1): fi-kbl-7560u
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_8108 -> Patchwork_16902

CI-20190529: 20190529
CI_DRM_8108: 7616c3ce8d78b3c229e4dc27d795246a2677f0a9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5504: d6788bf0404f76b66170e18eb26c85004b5ccb25 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16902: 570b96641df630db8024417e39be06b265ee9cae @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

570b96641df6 drm/i915/tgl: WaEnablePreemptionGranularityControlByUMD

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16902/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Acked-by on v1 1/1
#3 lore raw
In reply to Tvrtko Ursulin
Quoted 10 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Certain workloads need the ability to disable preemption completely so allow them to do that by whitelisting GEN8_CS_CHICKEN1.

Cc Michal Mrozek <[email protected]>
Cc Tony Ye <[email protected]>
Cc Rafael Antognolli <[email protected]>
Cc Jason Ekstrand <[email protected]>
Quoted 4 lines

---
We need confirmation and acks from all three userspace components here. Especially since my impression was some are for and some were against whitelisting this one.

Media doesn't need this for TGL. But it's acceptable if other userspace wants to whitelist it.

Quoted 10 lines
---
  drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
  1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/gt/intel_workarounds.c +0 -0
index 391f39b1fb26..37becdf77427 100644

drivers/gpu/drm/i915/gt/intel_workarounds.c static void tgl_whitelist_build(struct intel_engine_cs *engine) · line 1284

Quoted 9 lines
drivers/gpu/drm/i915/gt/intel_workarounds.c +3 -0
@@ -1276,6 +1276,9 @@ static void tgl_whitelist_build(struct intel_engine_cs *engine)
 
  		/* Wa_1806527549:tgl */
  		whitelist_reg(w, HIZ_CHICKEN);
+
+		/* WaEnablePreemptionGranularityControlByUMD:tgl */
+		whitelist_reg(w, GEN8_CS_CHICKEN1);
  		break;
  	default:
  		break;

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx