Skip to contentSkip to conversation

nfs-utils: fix do_package error when enable PACKAGECONFIG[nfsv4]

PATCH Superseded Yi Zhao 3 participants 4 messages Mar 11, 2020 – Mar 23, 2020

lore
Share & tools
lore

Yi Zhao

author
#0 lore raw

PATCH 1/1 nfs-utils: fix do_package error when enable PACKAGECONFIG[nfsv4]

Fixes:
ERROR: nfs-utils-2.4.3-r0 do_package: QA Issue: nfs-utils:
Files/directories were installed but not shipped in any package:
/usr/lib/libnfsidmap/nsswitch.so /usr/lib/libnfsidmap/static.so
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
nfs-utils: 2 installed and not shipped files. [installed-vs-shipped]

---
 meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb +6 -4
index 42a4ba3dbd..9bdb6f4ae4 100644
@@ -67,9 +67,9 @@ PACKAGECONFIG_remove_libc-musl = "tcp-wrappers"
 PACKAGECONFIG[tcp-wrappers] = "--with-tcp-wrappers,--without-tcp-wrappers,tcp-wrappers"
 PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,"
 # libdevmapper is available in meta-oe
-PACKAGECONFIG[nfsv41] = "--enable-nfsv41,--disable-nfsv41,libdevmapper"
-# keyutils is available in meta-security
-PACKAGECONFIG[nfsv4] = "--enable-nfsv4,--disable-nfsv4,keyutils"
+PACKAGECONFIG[nfsv41] = "--enable-nfsv41,--disable-nfsv41,libdevmapper,libdevmapper"
+# keyutils is available in meta-oe
+PACKAGECONFIG[nfsv4] = "--enable-nfsv4,--disable-nfsv4,keyutils,python3-core"
 
 PACKAGES =+ "${PN}-client ${PN}-mount ${PN}-stats"
 
@@ -94,7 +94,9 @@ FILES_${PN}-mount = "${base_sbindir}/*mount.nfs*"
 FILES_${PN}-stats = "${sbindir}/mountstats ${sbindir}/nfsiostat"
 RDEPENDS_${PN}-stats = "python3-core"
 
-FILES_${PN} += "${systemd_unitdir}"
+FILES_${PN}-staticdev += "${libdir}/libnfsidmap/*.a"
+
+FILES_${PN} += "${systemd_unitdir} ${libdir}/libnfsidmap/"
 
 do_configure_prepend() {
         sed -i -e 's,sbindir = /sbin,sbindir = ${base_sbindir},g' \
Signature · 1 line
2.17.1
#1 lore raw
Quoted 19 lines · Yi Zhao

Fixes:
ERROR: nfs-utils-2.4.3-r0 do_package: QA Issue: nfs-utils:
Files/directories were installed but not shipped in any package:
/usr/lib/libnfsidmap/nsswitch.so /usr/lib/libnfsidmap/static.so
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
nfs-utils: 2 installed and not shipped files. [installed-vs-shipped]

---
  meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb | 10 ++++++----
  1 file changed, 6 insertions(+), 4 deletions(-)
meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb +0 -0
index 42a4ba3dbd..9bdb6f4ae4 100644

meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb PACKAGECONFIG_remove_libc-musl = "tcp-wrappers" · line 72

Quoted 9 lines
meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb +1 -3
@@ -67,9 +67,9 @@ PACKAGECONFIG_remove_libc-musl = "tcp-wrappers"
  PACKAGECONFIG[tcp-wrappers] = "--with-tcp-wrappers,--without-tcp-wrappers,tcp-wrappers"
  PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,"
  # libdevmapper is available in meta-oe
 
-PACKAGECONFIG[nfsv41] = "--enable-nfsv41,--disable-nfsv41,libdevmapper"
-# keyutils is available in meta-security
-PACKAGECONFIG[nfsv4] = "--enable-nfsv4,--disable-nfsv4,keyutils"
 
+PACKAGECONFIG[nfsv41] = "--enable-nfsv41,--disable-nfsv41,libdevmapper,libdevmapper"

Did you really mean to have libdevmapper twice?
If so, why not make it a mandatory DEPENDS?

meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb PACKAGECONFIG_remove_libc-musl = "tcp-wrappers" · line 72

Quoted 2 lines
meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb +2 -0
+# keyutils is available in meta-oe
+PACKAGECONFIG[nfsv4] = "--enable-nfsv4,--disable-nfsv4,keyutils,python3-core"

Why? This change wasn't explained in the long log.

The rest seems fine, v2 please.

../Randy

Quoted 15 lines
meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb +3 -1
  PACKAGES =+ "${PN}-client ${PN}-mount ${PN}-stats"
@@ -94,7 +94,9 @@ FILES_${PN}-mount = "${base_sbindir}/*mount.nfs*"
  FILES_${PN}-stats = "${sbindir}/mountstats ${sbindir}/nfsiostat"
  RDEPENDS_${PN}-stats = "python3-core"
 
-FILES_${PN} += "${systemd_unitdir}"
+FILES_${PN}-staticdev += "${libdir}/libnfsidmap/*.a"
+
+FILES_${PN} += "${systemd_unitdir} ${libdir}/libnfsidmap/"
 
  do_configure_prepend() {
          sed -i -e 's,sbindir = /sbin,sbindir = ${base_sbindir},g' \
Signature · 2 lines
# Randy MacLeod
# Wind River Linux
#2 lore raw
Quoted 28 lines · Randy MacLeod
Quoted 26 lines · Yi Zhao

Fixes:
ERROR: nfs-utils-2.4.3-r0 do_package: QA Issue: nfs-utils:
Files/directories were installed but not shipped in any package:
/usr/lib/libnfsidmap/nsswitch.so /usr/lib/libnfsidmap/static.so
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
nfs-utils: 2 installed and not shipped files. [installed-vs-shipped]

---
  meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb | 10 ++++++----

  1 file changed, 6 insertions(+), 4 deletions(-)
meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb +0 -0
index 42a4ba3dbd..9bdb6f4ae4 100644
@@ -67,9 +67,9 @@ PACKAGECONFIG_remove_libc-musl = "tcp-wrappers"

  PACKAGECONFIG[tcp-wrappers] = "--with-tcp-wrappers,--without-tcp-wrappers,tcp-wrappers" PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,"

  # libdevmapper is available in meta-oe
meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb +0 -3
-PACKAGECONFIG[nfsv41] = "--enable-nfsv41,--disable-nfsv41,libdevmapper"
-# keyutils is available in meta-security
-PACKAGECONFIG[nfsv4] = "--enable-nfsv4,--disable-nfsv4,keyutils"
Quoted 6 lines
Quoted 2 lines

+PACKAGECONFIG[nfsv41] = "--enable-nfsv41,--disable-nfsv41,libdevmapper,libdevmapper"

Did you really mean to have libdevmapper twice?
If so, why not make it a mandatory DEPENDS?

One of them is rdep and other is builddep, so it should be fine they only trigger when this knob is enabled.

Quoted 23 lines
Quoted 3 lines
meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb +2 -0
+# keyutils is available in meta-oe
+PACKAGECONFIG[nfsv4] = 

"--enable-nfsv4,--disable-nfsv4,keyutils,python3-core"

Why? This change wasn't explained in the long log.

The rest seems fine, v2 please.

../Randy

Quoted 11 lines

  PACKAGES =+ "${PN}-client ${PN}-mount ${PN}-stats"

meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb +0 -0
@@ -94,7 +94,9 @@ FILES_${PN}-mount = "${base_sbindir}/*mount.nfs*"

  FILES_${PN}-stats = "${sbindir}/mountstats ${sbindir}/nfsiostat" RDEPENDS_${PN}-stats = "python3-core"

meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb +3 -1
-FILES_${PN} += "${systemd_unitdir}"
+FILES_${PN}-staticdev += "${libdir}/libnfsidmap/*.a"
+
+FILES_${PN} += "${systemd_unitdir} ${libdir}/libnfsidmap/"

  do_configure_prepend() {
          sed -i -e 's,sbindir = /sbin,sbindir = ${base_sbindir},g' \

author
#3 lore raw

PATCH v2 1/1 nfs-utils: fix do_package error when enable PACKAGECONFIG[nfsv4]

In reply to Yi Zhao

Fixes:
ERROR: nfs-utils-2.4.3-r0 do_package: QA Issue: nfs-utils:
Files/directories were installed but not shipped in any package:
/usr/lib/libnfsidmap/nsswitch.so /usr/lib/libnfsidmap/static.so
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
nfs-utils: 2 installed and not shipped files. [installed-vs-shipped]

Add rdep on python3-core for PACKAGECONFIG[nfsv4] to fix:
ERROR: nfs-utils-2.4.3-r0 do_package_qa: QA Issue: /usr/sbin/clddb-tool contained in package nfs-utils requires /usr/bin/python3, but no providers found in RDEPENDS_nfs-utils? [file-rdeps]

Add rdep on libdevmapper for PACKAGECONFIG[nfsv41] to fix:
ERROR: nfs-utils-2.4.3-r0 do_package_qa: QA Issue: /usr/sbin/blkmapd contained in package nfs-utils requires libdevmapper.so.1.02()(64bit), but no providers found in RDEPENDS_nfs-utils? [file-rdeps]

---
Change in V2: Add more information in commit log

 meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb +6 -4
index 42a4ba3dbd..9bdb6f4ae4 100644
@@ -67,9 +67,9 @@ PACKAGECONFIG_remove_libc-musl = "tcp-wrappers"
 PACKAGECONFIG[tcp-wrappers] = "--with-tcp-wrappers,--without-tcp-wrappers,tcp-wrappers"
 PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,"
 # libdevmapper is available in meta-oe
-PACKAGECONFIG[nfsv41] = "--enable-nfsv41,--disable-nfsv41,libdevmapper"
-# keyutils is available in meta-security
-PACKAGECONFIG[nfsv4] = "--enable-nfsv4,--disable-nfsv4,keyutils"
+PACKAGECONFIG[nfsv41] = "--enable-nfsv41,--disable-nfsv41,libdevmapper,libdevmapper"
+# keyutils is available in meta-oe
+PACKAGECONFIG[nfsv4] = "--enable-nfsv4,--disable-nfsv4,keyutils,python3-core"
 
 PACKAGES =+ "${PN}-client ${PN}-mount ${PN}-stats"
 
@@ -94,7 +94,9 @@ FILES_${PN}-mount = "${base_sbindir}/*mount.nfs*"
 FILES_${PN}-stats = "${sbindir}/mountstats ${sbindir}/nfsiostat"
 RDEPENDS_${PN}-stats = "python3-core"
 
-FILES_${PN} += "${systemd_unitdir}"
+FILES_${PN}-staticdev += "${libdir}/libnfsidmap/*.a"
+
+FILES_${PN} += "${systemd_unitdir} ${libdir}/libnfsidmap/"
 
 do_configure_prepend() {
         sed -i -e 's,sbindir = /sbin,sbindir = ${base_sbindir},g' \
Signature · 1 line
2.17.1