mmc: vub300: Use scnprintf() for avoiding potential buffer overflow
PATCH 1/1 mmc: vub300: Use scnprintf() for avoiding potential buffer overflow
Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf().
Signed-off-by Takashi Iwai <[email protected]>
--- drivers/mmc/host/vub300.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/vub300.c +1 -1
@@ -1363,7 +1363,7 @@ static void download_offload_pseudocode(struct vub300_mmc_host *vub300)int retval;for (n =0 ; n < sdio_funcs; n++) {struct sdio_func *sf = card->sdio_func[n]; - l +=snprintf (vub300->vub_name + l, + l +=scnprintf (vub300->vub_name + l,sizeof (vub300->vub_name) - l,"_%04X%04X" , sf->vendor, sf->device); }
Signature · 1 line
2.16.4
Quoted 6 lines · Takashi Iwai
Since
snprintf()returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing withscnprintf().Signed-off-by Takashi Iwai <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 20 lines
--- drivers/mmc/host/vub300.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/host/vub300.c +1
-2@@ -1363,7 +1363,7 @@ static void download_offload_pseudocode(struct vub300_mmc_host *vub300)int retval;for (n =0 ; n < sdio_funcs; n++) {struct sdio_func *sf = card->sdio_func[n]; - l +=snprintf (vub300->vub_name + l, + l +=scnprintf (vub300->vub_name + l,sizeof (vub300->vub_name) - l,"_%04X%04X" , sf->vendor, sf->device); } --2.16.4