staging: fbtft: Reformat lines over 80 characters
Subsystems (2)
PATCH 1/1 staging: fbtft: Reformat lines over 80 characters
Multiple macro definitions crossings 80 character line length nakes it hard to understand. Reformating the these lines makes the code more readable and easy to understand. Issue flagged by checkpatch script.
--- drivers/staging/fbtft/fbtft.h | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
drivers/staging/fbtft/fbtft.h +11 -3
@@ -348,9 +348,17 @@ module_exit(fbtft_driver_module_exit);/* shorthand debug levels */ #define DEBUG_LEVEL_1 DEBUG_REQUEST_GPIOS -#define DEBUG_LEVEL_2 (DEBUG_LEVEL_1 | DEBUG_DRIVER_INIT_FUNCTIONS | DEBUG_TIME_FIRST_UPDATE) -#define DEBUG_LEVEL_3 (DEBUG_LEVEL_2 | DEBUG_RESET | DEBUG_INIT_DISPLAY | DEBUG_BLANK | DEBUG_REQUEST_GPIOS | DEBUG_FREE_GPIOS | DEBUG_VERIFY_GPIOS | DEBUG_BACKLIGHT | DEBUG_SYSFS) -#define DEBUG_LEVEL_4 (DEBUG_LEVEL_2 | DEBUG_FB_READ | DEBUG_FB_WRITE | DEBUG_FB_FILLRECT | DEBUG_FB_COPYAREA | DEBUG_FB_IMAGEBLIT | DEBUG_FB_BLANK) +#define DEBUG_LEVEL_2 (DEBUG_LEVEL_1 | DEBUG_DRIVER_INIT_FUNCTIONS \ + | DEBUG_TIME_FIRST_UPDATE) +#define DEBUG_LEVEL_3 (DEBUG_LEVEL_2 | DEBUG_RESET | DEBUG_INIT_DISPLAY \ + | DEBUG_BLANK | DEBUG_REQUEST_GPIOS \ + | DEBUG_FREE_GPIOS \ + | DEBUG_VERIFY_GPIOS \ + | DEBUG_BACKLIGHT | DEBUG_SYSFS) +#define DEBUG_LEVEL_4 (DEBUG_LEVEL_2 | DEBUG_FB_READ | DEBUG_FB_WRITE \ + | DEBUG_FB_FILLRECT \ + | DEBUG_FB_COPYAREA \ + | DEBUG_FB_IMAGEBLIT | DEBUG_FB_BLANK)#define DEBUG_LEVEL_5 (DEBUG_LEVEL_3 | DEBUG_UPDATE_DISPLAY)#define DEBUG_LEVEL_6 (DEBUG_LEVEL_4 | DEBUG_LEVEL_5)#define DEBUG_LEVEL_7 0xFFFFFFFF
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 8 lines · Deepak R Varma
Multiple macro definitions crossings 80 character line length nakes it hard to understand. Reformating the these lines makes the code more readable and easy to understand. Issue flagged by checkpatch script.
Signed-off-by Deepak R Varma <[email protected]>--- drivers/staging/fbtft/fbtft.h | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
You sent 2 patches with almost identical subject lines, yet they did different things to different files.
Please fix up and make them more unique and resend both of them.
thanks,
greg k-h
Quoted 10 lines · Greg KH
Quoted 8 lines · Deepak R Varma
Multiple macro definitions crossings 80 character line length nakes it hard to understand. Reformating the these lines makes the code more readable and easy to understand. Issue flagged by checkpatch script.
Signed-off-by Deepak R Varma <[email protected]>--- drivers/staging/fbtft/fbtft.h | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
Quoted 8 lines
You sent 2 patches with almost identical subject lines, yet they did different things to different files.
Please fix up and make them more unique and resend both of them.
thanks,
greg k-h
Hello Greg,
Sure, will do. Thank you.
Deepak.