ASoC: SOF: Intel: Fix stream cleanup on hw free
Subsystems (3)
PATCH v3 1/1 ASoC: SOF: Intel: Fix stream cleanup on hw free
Field "substream" gets assigned during stream setup in hda_dsp_pcm_hw_params() but it is never cleared afterwards during cleanup procedure. Now, any non-pcm operation e.g.: compress can mistakenly make use of that pointer as it's bypassing all "if (s->substream)" checks.
Nulling the pointer during hw_free operation ensures no wild pointers are left behind.
Fixes cdae3b9a47aa ("ASoC: SOF: Intel: Add Intel specific HDA PCM operations")
Signed-off-by Cezary Rojewski <[email protected]>
---
Changes in v3:
- simple rewording of commit title & message
Changes in v2:
- relocated stream->substream assignment from _pcm_close() to _hw_free()
sound/soc/sof/intel/hda-stream.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/sof/intel/hda-stream.c +2 -0
@@ -547,6 +547,8 @@ int hda_dsp_stream_hw_free(struct snd_sof_dev *sdev, SOF_HDA_REG_PP_PPCTL, mask, 0);spin_unlock_irq (&bus->reg_lock); + stream->substream =NULL ; +return 0 ; }
Signature · 1 line
2.17.1