Skip to contentSkip to conversation

staging: sm750fb: Fix longline in makefile variable

PATCH In review R Veera Kumar 2 participants 2 messages Mar 12, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: sm750fb: Fix longline in makefile variable

A simple fix of long line makefile variable assignment. Found using checkpatch.pl.

---
 drivers/staging/sm750fb/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/sm750fb/Makefile +4 -2
index 1cf3849cef23..6f832916ba65 100644
@@ -1,5 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-$(CONFIG_FB_SM750)	+= sm750fb.o
 
-sm750fb-objs		:= sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o ddk750_chip.o ddk750_power.o ddk750_mode.o
-sm750fb-objs		+= ddk750_display.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o
+sm750fb-objs		:= sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o
+sm750fb-objs		+= ddk750_chip.o ddk750_power.o ddk750_mode.o
+sm750fb-objs		+= ddk750_display.o ddk750_swi2c.o ddk750_sii164.o
+sm750fb-objs		+= ddk750_dvi.o ddk750_hwi2c.o
Signature · 1 line
2.20.1
#1 lore raw

Veera,

This doesn't address some observations I had about your previous version. Namely:

Quoted 5 lines · On Thu, 12 Mar 2020 18:05:17 +0530 R Veera Kumar <[email protected]> wrote:

A simple fix of long line makefile variable assignment. Found using checkpatch.pl.

---

1. you didn't note the revision log here. By the way, that would also assume this becomes a "v2" (indicated in title as well), and the next one becomes a "v3". Again, see recent discussions on this list.

Quoted 8 lines
 drivers/staging/sm750fb/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/sm750fb/Makefile +0 -0
index 1cf3849cef23..6f832916ba65 100644

drivers/staging/sm750fb/Makefile line 7

Quoted 9 lines
drivers/staging/sm750fb/Makefile +4 -2
@@ -1,5 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-$(CONFIG_FB_SM750)	+= sm750fb.o
 
-sm750fb-objs		:= sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o ddk750_chip.o ddk750_power.o ddk750_mode.o
-sm750fb-objs		+= ddk750_display.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o
+sm750fb-objs		:= sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o
+sm750fb-objs		+= ddk750_chip.o ddk750_power.o ddk750_mode.o
+sm750fb-objs		+= ddk750_display.o ddk750_swi2c.o ddk750_sii164.o
+sm750fb-objs		+= ddk750_dvi.o ddk750_hwi2c.o

2. this is redundant. You can use backslashes for continuation. "sm750fb-objs += " is an unnecessary left margin decoration in this file. I read your comment about "keeping the maintainer's style", but I had observations about that, and you didn't follow up.

Please re-send. I don't think this patch should be applied as it is.

Signature · 1 line
Stefano